Bruno Roustant created SOLR-17504:
-------------------------------------
Summary: DirectUpdateHandler2.closeWriter supports commit metadata
Key: SOLR-17504
URL: https://issues.apache.org/jira/browse/SOLR-17504
Project: Solr
Issue Type: Improvement
Security Level: Public (Default Security Level. Issues are Public)
Reporter: Bruno Roustant
DirectUpdateHandler2.closeWriter may commit if the update log is not empty (not
committed yet). But it does not call DirectUpdateHandler2.commit(), it copies
commit() code instead for some reasons (comments in the code mention test
failures).
The proposal is to add the same call to DirectUpdateHandler2.shouldCommit() as
in the commit() method, otherwise commit metadata are lost. In addition
shouldCommit() can be extended correctly, for example in the solr-sandbox
encryption module which needs to intercept calls to shouldCommit().
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
