janhoy commented on code in PR #2778:
URL: https://github.com/apache/solr/pull/2778#discussion_r1806099337
##########
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##########
@@ -792,11 +792,10 @@ public static String normalizeSolrUrl(CommandLine cli)
throws Exception {
String firstLiveNode = liveNodes.iterator().next();
solrUrl =
ZkStateReader.from(cloudSolrClient).getBaseUrlForNodeName(firstLiveNode);
- // solrUrl = normalizeSolrUrl(solrUrl, false);
+ solrUrl = normalizeSolrUrl(solrUrl, false);
}
}
}
- solrUrl = normalizeSolrUrl(solrUrl, false);
Review Comment:
Not sure about this - whether all use of this. Will caller always expect to
get `/solr` stripped after calling this? Guess they do, but started by
reverting some changes to see if I could get to previous state..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
