janhoy commented on code in PR #2778:
URL: https://github.com/apache/solr/pull/2778#discussion_r1806335724
##########
solr/core/src/java/org/apache/solr/cli/PostTool.java:
##########
@@ -315,8 +315,7 @@ public void runImpl(CommandLine cli) throws Exception {
throw new IllegalArgumentException(
"Must specify -c / --name parameter with --solr-url to post
documents.");
}
- String url =
- SolrCLI.normalizeSolrUrl(cli) + "/solr/" +
cli.getOptionValue("name") + "/update";
+ String url = SolrCLI.normalizeSolrUrl(cli) + "/" +
cli.getOptionValue("name") + "/update";
Review Comment:
That's how it is on main. But the "`/` as baseUrl" code is not (fully)
backPorted to 9x, so there are differences. In 99% of cases our context path is
`/solr` but some tests spin up Jetty's with other paths and they will break if
we start creeping in too many hardcoded `/solr`. Should be safe to do in a test
here and there though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
