bruno-roustant commented on PR #113: URL: https://github.com/apache/solr-sandbox/pull/113#issuecomment-2422961251
For the SolrIndexSplitter.doSplit, it is already handled in EncryptionUpdateHandler which extends DirectUpdateHandler2.split(). This method creates the SolrIndexSplitter and gives the Command which contains the metadata. For CoreContainer.reload, I missed it. Good point. I don't think there are other callers currently. But I agree this is fragile while Solr evolves. I hope that when this encryption module comes into Solr, we can encapsulate the Lucene IndexWriter in a way that it does the commit metadata transfer systematically at nearly the Lucene level. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
