gus-asf commented on PR #2493: URL: https://github.com/apache/solr/pull/2493#issuecomment-2423564458
That's an interesting observation, and it is worth noting that the strategy here is somewhat different and not necessarily duplicative of SOLR-17158. I did try to additionally add a short-circuit during the take cycle as inspired by this PR but found it prone to infrequent and subtle errors. Some of which were solved by substantially complicating the logic in cancelAll(), but a rare case where "omitted" was not properly returned never got solved. For those who might want to reconsider something like this my efforts (not included in SOLR-17158) are here: https://github.com/gus-asf/solr/tree/SOLR-17158-take-short-circuit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
