janhoy commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093794953
##
gradle/template.gradle.properties:
##
@@ -0,0 +1,106 @@
+#
+# Local developer settings #
+#
+#
+# The first invo
colvinco commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093704315
##
gradle/template.gradle.properties:
##
@@ -0,0 +1,106 @@
+#
+# Local developer settings #
+#
+#
+# The first in
colvinco commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093704315
##
gradle/template.gradle.properties:
##
@@ -0,0 +1,106 @@
+#
+# Local developer settings #
+#
+#
+# The first in
colvinco commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093698018
##
gradle/template.gradle.properties:
##
@@ -0,0 +1,43 @@
+# See gradlew :helpLocalSettings for more information on configuring this file.
Review Comment:
I've moved
colvinco commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093688816
##
buildSrc/src/main/java/org/apache/lucene/gradle/GradlePropertiesGenerator.java:
##
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
magibney commented on PR #1323:
URL: https://github.com/apache/solr/pull/1323#issuecomment-1412590583
@dweiss I'd like to make sure you have a chance to look at this, if you're
able. Particularly:
1. 3f6fb21ca7a36241520572ae9a906c829ecb10ef: I recall it was a bit tricky to
read project p
risdenk commented on PR #1221:
URL: https://github.com/apache/solr/pull/1221#issuecomment-141267
@heythm hope all is well - curious of the comments will be addressed? I
think this is a beneficial change
--
This is an automated message from the Apache Git Service.
To respond to the mes
risdenk commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093601498
##
buildSrc/src/main/java/org/apache/lucene/gradle/GradlePropertiesGenerator.java:
##
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
magibney opened a new pull request, #1323:
URL: https://github.com/apache/solr/pull/1323
This is a followup to SOLR-15455 / #304
I'm happy to open a Jira issue for this if that would be helpful, or push to
a branch that allows collaborative work.
In the course of exercising the
colvinco commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093596944
##
gradle/template.gradle.properties:
##
@@ -0,0 +1,43 @@
+# See gradlew :helpLocalSettings for more information on configuring this file.
Review Comment:
That comman
colvinco commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093596944
##
gradle/template.gradle.properties:
##
@@ -0,0 +1,43 @@
+# See gradlew :helpLocalSettings for more information on configuring this file.
Review Comment:
That comman
colvinco commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093595480
##
gradlew:
##
@@ -163,11 +163,16 @@ fi
CLASSPATH=$GRADLE_WRAPPER_JAR
-# Don't fork a daemon mode on initial run that generates local defaults.
-GRADLE_DAEMON_CTRL=
colvinco commented on PR #1320:
URL: https://github.com/apache/solr/pull/1320#issuecomment-1412537208
It's been a bit of a rollercoaster ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
risdenk commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093591631
##
gradlew:
##
@@ -163,11 +163,16 @@ fi
CLASSPATH=$GRADLE_WRAPPER_JAR
-# Don't fork a daemon mode on initial run that generates local defaults.
-GRADLE_DAEMON_CTRL=
+
colvinco commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093588158
##
gradlew:
##
@@ -163,10 +163,18 @@ fi
CLASSPATH=$GRADLE_WRAPPER_JAR
-# Don't fork a daemon mode on initial run that generates local defaults.
-GRADLE_DAEMON_CTRL=
colvinco commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093554041
##
gradlew:
##
@@ -163,10 +163,18 @@ fi
CLASSPATH=$GRADLE_WRAPPER_JAR
-# Don't fork a daemon mode on initial run that generates local defaults.
-GRADLE_DAEMON_CTRL=
janhoy commented on PR #1321:
URL: https://github.com/apache/solr/pull/1321#issuecomment-1412477182
My point is the property name could be delete… with a default of true.
Users would need to set it to false to override. In 10.0 the default could
change, unless we found a better / smar
colvinco commented on PR #1322:
URL: https://github.com/apache/solr/pull/1322#issuecomment-1412415473
Sorry, I'll close this one but I'll remember the comments on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
colvinco closed pull request #1322: SOLR-16641 - Generate gradle.properties
from template
URL: https://github.com/apache/solr/pull/1322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
colvinco commented on PR #1321:
URL: https://github.com/apache/solr/pull/1321#issuecomment-1412401969
> I'm ok with either _preserve_ or _delete_. If you rather want _delete_
then choose it, with a java-level default of "true".
>
> Do we need to treat this behaviour as a backward comp
[
https://issues.apache.org/jira/browse/SOLR-16642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683095#comment-17683095
]
Uwe Schindler commented on SOLR-16642:
--
This one should be reverted (no longer neede
uschindler commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093452719
##
gradlew:
##
@@ -163,10 +163,18 @@ fi
CLASSPATH=$GRADLE_WRAPPER_JAR
-# Don't fork a daemon mode on initial run that generates local defaults.
-GRADLE_DAEMON_CTRL
[
https://issues.apache.org/jira/browse/SOLR-16642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683079#comment-17683079
]
Uwe Schindler commented on SOLR-16642:
--
Don't forget: The startup script (solr.sh/so
uschindler commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093417783
##
gradlew:
##
@@ -163,10 +163,18 @@ fi
CLASSPATH=$GRADLE_WRAPPER_JAR
-# Don't fork a daemon mode on initial run that generates local defaults.
-GRADLE_DAEMON_CTRL
epugh commented on PR #1304:
URL: https://github.com/apache/solr/pull/1304#issuecomment-1412256804
@stillalex I was hoping to merge this, but going to leave it open for
another day and see if anyone has a tip on fixing the crave build...I don't
believe the crave build error has anything
dweiss commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093336382
##
gradlew:
##
@@ -163,10 +163,18 @@ fi
CLASSPATH=$GRADLE_WRAPPER_JAR
-# Don't fork a daemon mode on initial run that generates local defaults.
-GRADLE_DAEMON_CTRL=
+#
janhoy commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093334476
##
gradlew:
##
@@ -163,10 +163,18 @@ fi
CLASSPATH=$GRADLE_WRAPPER_JAR
-# Don't fork a daemon mode on initial run that generates local defaults.
-GRADLE_DAEMON_CTRL=
+#
janhoy commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093330100
##
gradlew:
##
@@ -163,10 +163,18 @@ fi
CLASSPATH=$GRADLE_WRAPPER_JAR
-# Don't fork a daemon mode on initial run that generates local defaults.
-GRADLE_DAEMON_CTRL=
+#
janhoy commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093324267
##
gradlew:
##
@@ -163,10 +163,18 @@ fi
CLASSPATH=$GRADLE_WRAPPER_JAR
-# Don't fork a daemon mode on initial run that generates local defaults.
-GRADLE_DAEMON_CTRL=
+#
janhoy commented on PR #1322:
URL: https://github.com/apache/solr/pull/1322#issuecomment-1412177554
Sorry for adding the review here instead of #1320, it was a mistake. I can
add it there if you want, or I'll wait a few days to see how that PR evolves
and review again.
--
This is an auto
janhoy commented on code in PR #1322:
URL: https://github.com/apache/solr/pull/1322#discussion_r1093312163
##
gradlew:
##
@@ -163,10 +163,18 @@ fi
CLASSPATH=$GRADLE_WRAPPER_JAR
-# Don't fork a daemon mode on initial run that generates local defaults.
-GRADLE_DAEMON_CTRL=
+#
dweiss commented on PR #1320:
URL: https://github.com/apache/solr/pull/1320#issuecomment-1412160755
If you're concerned about startup time of that one-time "gradle
localSettings" process then I'd suggest implementing this template logic/
retrieval of what's necessary as a java class - much
[
https://issues.apache.org/jira/browse/SOLR-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-16637.
--
Fix Version/s: main (10.0)
9.2
Assignee: Eric Pugh
Resolution: Fixed
[
https://issues.apache.org/jira/browse/SOLR-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683053#comment-17683053
]
ASF subversion and git services commented on SOLR-16637:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683052#comment-17683052
]
ASF subversion and git services commented on SOLR-16637:
Commit 5
epugh merged PR #1315:
URL: https://github.com/apache/solr/pull/1315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
dweiss commented on PR #1320:
URL: https://github.com/apache/solr/pull/1320#issuecomment-1412153419
> We can absolutely put a real default safe (albeit slow) gradle.properties
here and the existing .gitignore rule that already references gradle.properties
will prevent someone from accidenta
colvinco commented on PR #1320:
URL: https://github.com/apache/solr/pull/1320#issuecomment-1412153070
Yep I used to do that, but it makes it (slightly) harder to update the
defaults in the future and can be confusing because people don't expect
gitignored files to be in git - as you say peo
janhoy commented on code in PR #1321:
URL: https://github.com/apache/solr/pull/1321#discussion_r1093285558
##
solr/bin/solr.in.sh:
##
@@ -83,6 +83,12 @@
# By default Solr will try to connect to Zookeeper with 30 seconds in timeout;
override the timeout if needed
#SOLR_WAIT_FO
dsmiley commented on PR #1320:
URL: https://github.com/apache/solr/pull/1320#issuecomment-1412104815
> without messing around with gitignore
What many people don't realize about `.gitignore` is that it does *not*
prevent the file being a part of the repo (i.e. committed & pulled). We
bszabo97 commented on code in PR #1315:
URL: https://github.com/apache/solr/pull/1315#discussion_r1093240238
##
solr/solr-ref-guide/modules/configuration-guide/pages/commits-transaction-logs.adoc:
##
@@ -279,6 +279,21 @@ The number of buckets used to keep track of maximum
versi
janhoy commented on code in PR #1315:
URL: https://github.com/apache/solr/pull/1315#discussion_r1093195793
##
solr/solr-ref-guide/modules/configuration-guide/pages/commits-transaction-logs.adoc:
##
@@ -279,6 +279,21 @@ The number of buckets used to keep track of maximum
version
colvinco commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093190383
##
gradlew:
##
@@ -163,10 +163,18 @@ fi
CLASSPATH=$GRADLE_WRAPPER_JAR
-# Don't fork a daemon mode on initial run that generates local defaults.
-GRADLE_DAEMON_CTRL=
[
https://issues.apache.org/jira/browse/SOLR-16642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682991#comment-17682991
]
Bence Szabó commented on SOLR-16642:
If there are no other applicant I would gladly h
[
https://issues.apache.org/jira/browse/SOLR-16642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682991#comment-17682991
]
Bence Szabó edited comment on SOLR-16642 at 2/1/23 12:08 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-16642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke updated SOLR-16642:
---
Labels: newdev (was: )
> upgrade Solr to use Lucene 9.5.0
>
Christine Poerschke created SOLR-16642:
--
Summary: upgrade Solr to use Lucene 9.5.0
Key: SOLR-16642
URL: https://issues.apache.org/jira/browse/SOLR-16642
Project: Solr
Issue Type: Task
dweiss commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093100197
##
gradlew:
##
@@ -163,10 +163,18 @@ fi
CLASSPATH=$GRADLE_WRAPPER_JAR
-# Don't fork a daemon mode on initial run that generates local defaults.
-GRADLE_DAEMON_CTRL=
+#
dweiss commented on PR #1320:
URL: https://github.com/apache/solr/pull/1320#issuecomment-1411899975
> Windows as it's used much less and the need for this file is iffy. We're
doing something rather unusual in Lucene & Solr -- insisting on
gradle.properties when countless Gradle projects hav
colvinco commented on PR #1320:
URL: https://github.com/apache/solr/pull/1320#issuecomment-1411869912
> Don't force-push in PRs :-)
>
> PRs are anyways squash merged, so no need to squash them before. It also
makes it hard to review when you do changes.
Yep, I normally I wouldn
uschindler commented on PR #1320:
URL: https://github.com/apache/solr/pull/1320#issuecomment-1411867969
> The check on crave.io is failing to apply my commit... I'm guessing that's
because I've been force pushing to my branch and it's now a bit out of sync?
https://github.com/apache/solr/ac
uschindler commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093064393
##
gradle/generation/local-settings.gradle:
##
@@ -45,83 +45,4 @@ configure(rootProject) {
}
}
}
-
Review Comment:
Please keep the "deprecated" local
uschindler commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093064393
##
gradle/generation/local-settings.gradle:
##
@@ -45,83 +45,4 @@ configure(rootProject) {
}
}
}
-
Review Comment:
Please keep the "deprecated" local
colvinco opened a new pull request, #1322:
URL: https://github.com/apache/solr/pull/1322
This is a duplicate of #1320 atm, I just want to test the crave.io check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
colvinco commented on PR #1320:
URL: https://github.com/apache/solr/pull/1320#issuecomment-1411855713
The check on crave.io is failing to apply my commit... I'm guessing that's
because I've been force pushing to my branch and it's now a bit out of sync?
https://github.com/apache/solr/action
colvinco commented on PR #1320:
URL: https://github.com/apache/solr/pull/1320#issuecomment-1411849127
Hopefully we're getting there now :)
I didn't bother with trying to do variable substitution from batch as I
didn't see a good + easy option. But bash will set the two parameters that wer
colvinco commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093050442
##
gradle.properties.template:
##
@@ -0,0 +1,43 @@
+# See gradlew :helpLocalSettings for more information on configuring this file.
+systemProp.file.encoding=UTF-8
+
+# S
asalamon74 closed pull request #1311: SOLR-16632: Add core name to periodic
delete related log messages
URL: https://github.com/apache/solr/pull/1311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/SOLR-16632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Salamon resolved SOLR-16632.
---
Fix Version/s: main (10.0)
9.2
Resolution: Fixed
Thanks [~bszabo97]
asalamon74 commented on PR #1311:
URL: https://github.com/apache/solr/pull/1311#issuecomment-1411795175
Thanks @bszabo97 committed the change to `main` and `branch_9x`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
[
https://issues.apache.org/jira/browse/SOLR-16632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Salamon reassigned SOLR-16632:
-
Assignee: Andras Salamon
> Add core name to periodic delete related log messages
> -
[
https://issues.apache.org/jira/browse/SOLR-16632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682948#comment-17682948
]
ASF subversion and git services commented on SOLR-16632:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-16632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682945#comment-17682945
]
ASF subversion and git services commented on SOLR-16632:
Commit f
colvinco commented on PR #1320:
URL: https://github.com/apache/solr/pull/1320#issuecomment-1411718416
> A simplifying alternative would be to check gradle.properties into the
project (but still marked ignored in .gitignore) and with Gradle's own defaults
for number of workers & tests, or ch
64 matches
Mail list logo
