colvinco commented on PR #1320: URL: https://github.com/apache/solr/pull/1320#issuecomment-1411869912
> Don't force-push in PRs :-) > > PRs are anyways squash merged, so no need to squash them before. It also makes it hard to review when you do changes. Yep, I normally I wouldn't. But because the solution changed so drastically it seemed better this time around. Good to hear that squash merge is now the default/only option on here. I had a previous PR that got merged in with a standard merge last year, which was a bit messy :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
