dweiss commented on PR #1320: URL: https://github.com/apache/solr/pull/1320#issuecomment-1411899975
> Windows as it's used much less and the need for this file is iffy. We're doing something rather unusual in Lucene & Solr -- insisting on gradle.properties when countless Gradle projects have no such mandate. Well, depends on how you look at it. There is no way to configure reasonable static defaults for a 2-CPU laptop and a 128-core beast machine. And these "sane" defaults is what this file was originally about. If it were static, we could just commit it in to the repository (many projects do that, actually). But then folks wouldn't be able to tweak it and there's no way to split this configuration into multiple files (as far as I know, at least). gradle.properties can also be the only (required) option to, for example, open up jdk/gradle internals to plugins like spotless (it's where the JVM setup lives). I'd love those things to be configurable via different mechanism, but it's not something I invented or have much influence over. For portability, I'd leave those defaults inside gradle and call the generation task from gradlew if this file doesn't exist. I don't see any harm in it, to be honest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
