risdenk commented on code in PR #1320: URL: https://github.com/apache/solr/pull/1320#discussion_r1093591631
########## gradlew: ########## @@ -163,11 +163,16 @@ fi CLASSPATH=$GRADLE_WRAPPER_JAR -# Don't fork a daemon mode on initial run that generates local defaults. -GRADLE_DAEMON_CTRL= +# START OF SOLR CUSTOMIZATION +# Generate gradle.properties if they don't exist if [ ! -e "$APP_HOME/gradle.properties" ]; then - GRADLE_DAEMON_CTRL=--no-daemon + "$JAVACMD" $JAVA_OPTS --source 11 "$APP_HOME/buildSrc/src/main/java/org/apache/lucene/gradle/GradlePropertiesGenerator.java" "$APP_HOME/gradle/template.gradle.properties" "$APP_HOME/gradle.properties" Review Comment: `buildSrc/src/main/java/org/apache/lucene/gradle/GradlePropertiesGenerator.java` I think this file wasn't checked in? ########## gradle/template.gradle.properties: ########## @@ -0,0 +1,43 @@ +# See gradlew :helpLocalSettings for more information on configuring this file. Review Comment: Not sure this comment is still valid. ########## gradlew: ########## @@ -163,11 +163,16 @@ fi CLASSPATH=$GRADLE_WRAPPER_JAR -# Don't fork a daemon mode on initial run that generates local defaults. -GRADLE_DAEMON_CTRL= +# START OF SOLR CUSTOMIZATION +# Generate gradle.properties if they don't exist if [ ! -e "$APP_HOME/gradle.properties" ]; then - GRADLE_DAEMON_CTRL=--no-daemon + "$JAVACMD" $JAVA_OPTS --source 11 "$APP_HOME/buildSrc/src/main/java/org/apache/lucene/gradle/GradlePropertiesGenerator.java" "$APP_HOME/gradle/template.gradle.properties" "$APP_HOME/gradle.properties" + GENERATOR_STATUS=$? + if [ "$WRAPPER_STATUS" -ne 0 ]; then + exit $WRAPPER_STATUS + fi Review Comment: Should use `GENERATOR_STATUS`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
