janhoy commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093334476
##########
gradlew:
##########
@@ -163,10 +163,18 @@ fi
CLASSPATH=$GRADLE_WRAPPER_JAR
-# Don't fork a daemon mode on initial run that generates local defaults.
-GRADLE_DAEMON_CTRL=
+# Generate gradle.properties if they don't exist
if [ ! -e "$APP_HOME/gradle.properties" ]; then
- GRADLE_DAEMON_CTRL=--no-daemon
+ echo "Populating gradle.properties from gradle.properties.template."
+ # Do the copy first. If the next steps fail, the gradle.properties will
still be usable
+ cp gradle.properties.template gradle.properties
Review Comment:
```suggestion
cp gradle.properties.template "$APP_HOME/gradle.properties"
```
Also, could the `gradle.properties.template` file be inside `gradle/` folder
to avoid littering the root git folder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
