magibney commented on PR #1323: URL: https://github.com/apache/solr/pull/1323#issuecomment-1412590583
@dweiss I'd like to make sure you have a chance to look at this, if you're able. Particularly: 1. 3f6fb21ca7a36241520572ae9a906c829ecb10ef: I recall it was a bit tricky to read project properties at configuration time -- the solution that this replaces would read project props specified on the command-line, but wasn't able to read out of the `gradle.properties` file. The solution proposed here should be a bit cleaner, and is capable of doing both. 2. 600732f558e3052f5569ab3d189365f9b1edb5d3: I _think_ this is safe to do? If I'm right about it being arbitrary, this seems like the right way to go, and avoids conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
