colvinco commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093554041
##########
gradlew:
##########
@@ -163,10 +163,18 @@ fi
CLASSPATH=$GRADLE_WRAPPER_JAR
-# Don't fork a daemon mode on initial run that generates local defaults.
-GRADLE_DAEMON_CTRL=
+# Generate gradle.properties if they don't exist
if [ ! -e "$APP_HOME/gradle.properties" ]; then
- GRADLE_DAEMON_CTRL=--no-daemon
+ echo "Populating gradle.properties from gradle.properties.template."
+ # Do the copy first. If the next steps fail, the gradle.properties will
still be usable
+ cp gradle.properties.template gradle.properties
+ NUM_CORES=$(grep ^cpu\\scores /proc/cpuinfo | uniq | awk '{print $4}')
Review Comment:
I must admit, I hadn't realized Java 11+ supported execution without
compilation, I didn't pick up on that being used by gradlew. That's cool (even
if it is limited to self contained source files)
I will switch to that, that's much better.
> My idea would be to modify this script/class (executed without compiling
directly with java) to write the properties file.
I see [WrapperDownloader takes an
arg](https://github.com/apache/solr/blob/main/buildSrc/src/main/java/org/apache/lucene/gradle/WrapperDownloader.java#L48-L51)
for the destination it downloads the gradle wrapper jar to.
Do you think it's preferable to add this functionality to the
WrapperDownloader and it just grows a little, or create a separate class and
invoke it on its own?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
