[GitHub] [flink] tianchen92 closed pull request #8132: [FLINK-7916]Remove NetworkStackThroughputITCase

2019-05-12 Thread GitBox
tianchen92 closed pull request #8132: [FLINK-7916]Remove NetworkStackThroughputITCase URL: https://github.com/apache/flink/pull/8132 This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Updated] (FLINK-12495) Move PythonGatewayServer into flink-clients

2019-05-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12495: --- Labels: pull-request-available (was: ) > Move PythonGatewayServer into flink-clients >

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-05-12 Thread GitBox
zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283206923 ## File path: flink-runtime/src/test/java/org/apache/flink/

[GitHub] [flink] flinkbot commented on issue #8423: [FLINK-12495][python, client]Move PythonGatewayServer into flink-clie…

2019-05-12 Thread GitBox
flinkbot commented on issue #8423: [FLINK-12495][python, client]Move PythonGatewayServer into flink-clie… URL: https://github.com/apache/flink/pull/8423#issuecomment-491698755 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revi

[GitHub] [flink] sunjincheng121 opened a new pull request #8423: [FLINK-12495][python, client]Move PythonGatewayServer into flink-clie…

2019-05-12 Thread GitBox
sunjincheng121 opened a new pull request #8423: [FLINK-12495][python, client]Move PythonGatewayServer into flink-clie… URL: https://github.com/apache/flink/pull/8423 ## What is the purpose of the change Due to we add py4j dependency for `PythonGatewayServer` when we put the `PythonG

[GitHub] [flink] dawidwys commented on a change in pull request #8345: [FLINK-12402][table] Make validation error message for CallExpression more user friendly

2019-05-12 Thread GitBox
dawidwys commented on a change in pull request #8345: [FLINK-12402][table] Make validation error message for CallExpression more user friendly URL: https://github.com/apache/flink/pull/8345#discussion_r283206493 ## File path: flink-table/flink-table-planner/src/main/java/org/apache

[GitHub] [flink] tianchen92 commented on issue #8266: [FLINK-9904]Allow users to control MaxDirectMemorySize

2019-05-12 Thread GitBox
tianchen92 commented on issue #8266: [FLINK-9904]Allow users to control MaxDirectMemorySize URL: https://github.com/apache/flink/pull/8266#issuecomment-491697969 Hi @zentol, could you please help review this PR? thanks very much -

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-05-12 Thread GitBox
zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283204692 ## File path: flink-runtime/src/test/java/org/apache/flink/

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-05-12 Thread GitBox
zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283204043 ## File path: flink-runtime/src/test/java/org/apache/flink/

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-05-12 Thread GitBox
zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283203613 ## File path: flink-runtime/src/test/java/org/apache/flink/

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-05-12 Thread GitBox
zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283203263 ## File path: flink-runtime/src/test/java/org/apache/flink/

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-05-12 Thread GitBox
zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283202445 ## File path: flink-runtime/src/test/java/org/apache/flink/

[GitHub] [flink] beyond1920 commented on issue #8407: [FLINK-12374][table-planner-blink] Support translation from StreamExecTableSourceScan/BatchExecTableSourceScan to StreamTransformation.

2019-05-12 Thread GitBox
beyond1920 commented on issue #8407: [FLINK-12374][table-planner-blink] Support translation from StreamExecTableSourceScan/BatchExecTableSourceScan to StreamTransformation. URL: https://github.com/apache/flink/pull/8407#issuecomment-491693489 @KurtYoung Thanks for comment, I have already u

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-05-12 Thread GitBox
zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283199603 ## File path: flink-runtime/src/main/java/org/apache/flink/

[jira] [Created] (FLINK-12495) Move PythonGatewayServer into flink-clients

2019-05-12 Thread sunjincheng (JIRA)
sunjincheng created FLINK-12495: --- Summary: Move PythonGatewayServer into flink-clients Key: FLINK-12495 URL: https://issues.apache.org/jira/browse/FLINK-12495 Project: Flink Issue Type: Sub-tas

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-05-12 Thread GitBox
zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283198959 ## File path: flink-runtime/src/main/java/org/apache/flink/

[jira] [Assigned] (FLINK-12484) Drop unnecessary locking for code-paths that now use the mailbox

2019-05-12 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang reassigned FLINK-12484: Assignee: vinoyang > Drop unnecessary locking for code-paths that now use the mailbox > -

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-05-12 Thread GitBox
zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283197589 ## File path: flink-runtime/src/main/java/org/apache/flink/

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-05-12 Thread GitBox
zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283197233 ## File path: flink-core/src/main/java/org/apache/flink/cor

[jira] [Closed] (FLINK-11309) Make SpillableSubpartition repeatably read to enable

2019-05-12 Thread BoWang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BoWang closed FLINK-11309. -- Resolution: Fixed > Make SpillableSubpartition repeatably read to enable > ---

[jira] [Commented] (FLINK-12481) Make processing time timer trigger run via the mailbox

2019-05-12 Thread aitozi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838280#comment-16838280 ] aitozi commented on FLINK-12481: Hi, [~srichter] After going through the doc of this fea

[GitHub] [flink] yuyang08 edited a comment on issue #8067: [FLINK-11746][formats] Add thrift format support to Flink

2019-05-12 Thread GitBox
yuyang08 edited a comment on issue #8067: [FLINK-11746][formats] Add thrift format support to Flink URL: https://github.com/apache/flink/pull/8067#issuecomment-491611680 @Myasuka Updated the pr to fix build failure, and handle thrift binaries from different code generators. With this cha

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-05-12 Thread GitBox
zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283183410 ## File path: flink-runtime/src/test/java/org/apache/flink/

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-05-12 Thread GitBox
zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283183237 ## File path: flink-runtime/src/test/java/org/apache/flink/

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-05-12 Thread GitBox
zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283183177 ## File path: flink-runtime/src/test/java/org/apache/flink/

[jira] [Assigned] (FLINK-12494) JDBCOutputFormat support reconnect when link failure and flush by timeInterval

2019-05-12 Thread zhaoshijie (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhaoshijie reassigned FLINK-12494: -- Assignee: (was: zhaoshijie) > JDBCOutputFormat support reconnect when link failure and fl

[jira] [Updated] (FLINK-12494) JDBCOutputFormat support reconnect when link failure and flush by timeInterval

2019-05-12 Thread zhaoshijie (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhaoshijie updated FLINK-12494: --- Description: when i JDBCSink(flink-1.4.2) wite recode to mysql,find exception as flow :   {code:jav

[jira] [Assigned] (FLINK-12494) JDBCOutputFormat support reconnect when link failure and flush by timeInterval

2019-05-12 Thread zhaoshijie (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhaoshijie reassigned FLINK-12494: -- Assignee: zhaoshijie > JDBCOutputFormat support reconnect when link failure and flush by time

[jira] [Created] (FLINK-12494) JDBCOutputFormat support reconnect when link failure and flush by timeInterval

2019-05-12 Thread zhaoshijie (JIRA)
zhaoshijie created FLINK-12494: -- Summary: JDBCOutputFormat support reconnect when link failure and flush by timeInterval Key: FLINK-12494 URL: https://issues.apache.org/jira/browse/FLINK-12494 Project: F

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-05-12 Thread GitBox
zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283180286 ## File path: flink-runtime/src/main/java/org/apache/flink/

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-05-12 Thread GitBox
zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283180077 ## File path: flink-runtime/src/main/java/org/apache/flink/

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-05-12 Thread GitBox
zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283179736 ## File path: flink-runtime/src/main/java/org/apache/flink/

[GitHub] [flink] godfreyhe commented on a change in pull request #8356: [FLINK-12424] [table-planner-blink] Supports dag (multiple-sinks query) optimization

2019-05-12 Thread GitBox
godfreyhe commented on a change in pull request #8356: [FLINK-12424] [table-planner-blink] Supports dag (multiple-sinks query) optimization URL: https://github.com/apache/flink/pull/8356#discussion_r283179812 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/ap

[GitHub] [flink] zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-05-12 Thread GitBox
zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283179736 ## File path: flink-runtime/src/main/java/org/apache/flink/

[GitHub] [flink] sunnyholyd commented on issue #7803: [FLINK-11606][chinese-translation,Documentation] Translate the "Distr…

2019-05-12 Thread GitBox
sunnyholyd commented on issue #7803: [FLINK-11606][chinese-translation,Documentation] Translate the "Distr… URL: https://github.com/apache/flink/pull/7803#issuecomment-491664888 Hi @wuchong , I have rebase my commit to the latest master, please start review, thanks. --

[GitHub] [flink] KurtYoung commented on issue #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime

2019-05-12 Thread GitBox
KurtYoung commented on issue #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime URL: https://github.com/apache/flink/pull/8244#issuecomment-491664650 Thanks @XuQianJin-Stars for the PR, i will try to take a look soon. ---

[jira] [Closed] (FLINK-12457) Remove char support in blink

2019-05-12 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-12457. -- Resolution: Fixed Fix Version/s: 1.9.0 merged in 1.9.0: cf911b34facc0b298dccf6d24348fe9a3ccd3b8

[GitHub] [flink] KurtYoung merged pull request #8379: [FLINK-12457][table-planner-blink] Remove char support in blink

2019-05-12 Thread GitBox
KurtYoung merged pull request #8379: [FLINK-12457][table-planner-blink] Remove char support in blink URL: https://github.com/apache/flink/pull/8379 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] KurtYoung commented on a change in pull request #8356: [FLINK-12424] [table-planner-blink] Supports dag (multiple-sinks query) optimization

2019-05-12 Thread GitBox
KurtYoung commented on a change in pull request #8356: [FLINK-12424] [table-planner-blink] Supports dag (multiple-sinks query) optimization URL: https://github.com/apache/flink/pull/8356#discussion_r283178387 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/ap

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API

2019-05-12 Thread GitBox
sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API URL: https://github.com/apache/flink/pull/8359#discussion_r283174870 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API

2019-05-12 Thread GitBox
sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API URL: https://github.com/apache/flink/pull/8359#discussion_r283174796 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API

2019-05-12 Thread GitBox
sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API URL: https://github.com/apache/flink/pull/8359#discussion_r283164397 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API

2019-05-12 Thread GitBox
sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API URL: https://github.com/apache/flink/pull/8359#discussion_r283166175 ## File path: docs/dev/table/tableApi.md ## @@ -2066,16 +2066,37 @@ Table t

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API

2019-05-12 Thread GitBox
sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API URL: https://github.com/apache/flink/pull/8359#discussion_r283169490 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API

2019-05-12 Thread GitBox
sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API URL: https://github.com/apache/flink/pull/8359#discussion_r283164112 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API

2019-05-12 Thread GitBox
sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API URL: https://github.com/apache/flink/pull/8359#discussion_r283162046 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/o

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API

2019-05-12 Thread GitBox
sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API URL: https://github.com/apache/flink/pull/8359#discussion_r283175328 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API

2019-05-12 Thread GitBox
sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API URL: https://github.com/apache/flink/pull/8359#discussion_r283163670 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/p

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API

2019-05-12 Thread GitBox
sunjincheng121 commented on a change in pull request #8359: [FLINK-11051][table] Add streaming window FlatAggregate to Table API URL: https://github.com/apache/flink/pull/8359#discussion_r283162404 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/p

[jira] [Commented] (FLINK-12428) Translate the "Event Time" page into Chinese

2019-05-12 Thread YangFei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838231#comment-16838231 ] YangFei commented on FLINK-12428: - [~lyy900111] I have not started to do this issue . Yo

[GitHub] [flink] godfreyhe commented on a change in pull request #8356: [FLINK-12424] [table-planner-blink] Supports dag (multiple-sinks query) optimization

2019-05-12 Thread GitBox
godfreyhe commented on a change in pull request #8356: [FLINK-12424] [table-planner-blink] Supports dag (multiple-sinks query) optimization URL: https://github.com/apache/flink/pull/8356#discussion_r283175327 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/ap

[GitHub] [flink] wuchong commented on issue #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime

2019-05-12 Thread GitBox
wuchong commented on issue #8244: [FLINK-11945] [table-runtime-blink] Support over aggregation for blink streaming runtime URL: https://github.com/apache/flink/pull/8244#issuecomment-491659910 Thanks for the contribution @XuQianJin-Stars . It looks good to me now. @KurtYoung do you

[GitHub] [flink] dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

2019-05-12 Thread GitBox
dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283169262 ## File path: flink-python/pyflink/table/table.py ## @@ -118,3 +463,112 @@ def inser

[GitHub] [flink] dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

2019-05-12 Thread GitBox
dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283168926 ## File path: flink-python/pyflink/table/table.py ## @@ -118,3 +463,112 @@ def inser

[GitHub] [flink] dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

2019-05-12 Thread GitBox
dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283168536 ## File path: flink-python/pyflink/table/table.py ## @@ -106,6 +113,344 @@ def where

[GitHub] [flink] dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

2019-05-12 Thread GitBox
dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283172434 ## File path: flink-python/pyflink/table/table_config.py ## @@ -44,18 +47,55 @@ def

[GitHub] [flink] dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

2019-05-12 Thread GitBox
dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283167182 ## File path: flink-python/pyflink/table/table.py ## @@ -106,6 +113,344 @@ def where

[GitHub] [flink] dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

2019-05-12 Thread GitBox
dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283166998 ## File path: flink-python/pyflink/table/table.py ## @@ -106,6 +113,344 @@ def where

[GitHub] [flink] dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

2019-05-12 Thread GitBox
dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283169049 ## File path: flink-python/pyflink/table/table.py ## @@ -118,3 +463,112 @@ def inser

[GitHub] [flink] dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

2019-05-12 Thread GitBox
dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283169083 ## File path: flink-python/pyflink/table/table.py ## @@ -118,3 +463,112 @@ def inser

[GitHub] [flink] dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

2019-05-12 Thread GitBox
dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283172563 ## File path: flink-python/pyflink/table/table_config.py ## @@ -44,18 +47,55 @@ def

[GitHub] [flink] dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API.

2019-05-12 Thread GitBox
dianfu commented on a change in pull request #8401: [FLINK-12407][python] Add all table operators align Java Table API. URL: https://github.com/apache/flink/pull/8401#discussion_r283174219 ## File path: flink-python/pyflink/table/window.py ## @@ -0,0 +1,482 @@ +###

[GitHub] [flink] carryxyh commented on issue #8243: [FLINK-12299] ExecutionConfig#setAutoWatermarkInterval should check param(interval should not less than zero)

2019-05-12 Thread GitBox
carryxyh commented on issue #8243: [FLINK-12299] ExecutionConfig#setAutoWatermarkInterval should check param(interval should not less than zero) URL: https://github.com/apache/flink/pull/8243#issuecomment-491659489 @zentol Fix it soon. Thx for your review.

[GitHub] [flink] JingsongLi commented on issue #8379: [FLINK-12457][table-planner-blink] Remove char support in blink

2019-05-12 Thread GitBox
JingsongLi commented on issue #8379: [FLINK-12457][table-planner-blink] Remove char support in blink URL: https://github.com/apache/flink/pull/8379#issuecomment-491659432 > LGTM,btw does flink planner support CHAR right? In flink planner: There are some useless code (three lines)

[GitHub] [flink] beyond1920 commented on issue #8389: [FLINK-12399][table] Fix FilterableTableSource does not change after applyPredicate

2019-05-12 Thread GitBox
beyond1920 commented on issue #8389: [FLINK-12399][table] Fix FilterableTableSource does not change after applyPredicate URL: https://github.com/apache/flink/pull/8389#issuecomment-491659360 @walterddr good catch, we also encountered the problem in Blink before. The key question is that

[GitHub] [flink] tianchen92 edited a comment on issue #8121: [FLINK-10437]Some of keys under withDeprecatedKeys aren't marked as @…

2019-05-12 Thread GitBox
tianchen92 edited a comment on issue #8121: [FLINK-10437]Some of keys under withDeprecatedKeys aren't marked as @… URL: https://github.com/apache/flink/pull/8121#issuecomment-481077070 Hi, @zentol could you please help review this PR? thanks very much!

[GitHub] [flink] tianchen92 commented on issue #8171: [FLINK-9542]ExEnv#registerCachedFile should accept Path

2019-05-12 Thread GitBox
tianchen92 commented on issue #8171: [FLINK-9542]ExEnv#registerCachedFile should accept Path URL: https://github.com/apache/flink/pull/8171#issuecomment-491658630 @zentol Could you please help review this PR? thanks very much! ---

[GitHub] [flink] tianchen92 opened a new pull request #8266: [FLINK-9904]Allow users to control MaxDirectMemorySize

2019-05-12 Thread GitBox
tianchen92 opened a new pull request #8266: [FLINK-9904]Allow users to control MaxDirectMemorySize URL: https://github.com/apache/flink/pull/8266 ## What is the purpose of the change *This PR is related to [FLINK-9904](https://issues.apache.org/jira/browse/FLINK-9904). Make MaxDire

[GitHub] [flink] tianchen92 closed pull request #8266: [FLINK-9904]Allow users to control MaxDirectMemorySize

2019-05-12 Thread GitBox
tianchen92 closed pull request #8266: [FLINK-9904]Allow users to control MaxDirectMemorySize URL: https://github.com/apache/flink/pull/8266 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] shaoxuan-wang commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib

2019-05-12 Thread GitBox
shaoxuan-wang commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#discussion_r283172319 ## File path: flink-ml/pom.xml ## @@ -0,0 +1,39 @@ + + +http://maven.apache.org/POM

[jira] [Commented] (FLINK-11214) Support non mergable aggregates for group windows on batch table

2019-05-12 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838216#comment-16838216 ] Dian Fu commented on FLINK-11214: - Sounds good. BYW, you can take this ticket and contin

[jira] [Assigned] (FLINK-11214) Support non mergable aggregates for group windows on batch table

2019-05-12 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-11214: --- Assignee: (was: Dian Fu) > Support non mergable aggregates for group windows on batch table > -

[jira] [Commented] (FLINK-11214) Support non mergable aggregates for group windows on batch table

2019-05-12 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16838211#comment-16838211 ] Hequn Cheng commented on FLINK-11214: - [~dian.fu] Hi, great job! Thanks for reportin

[GitHub] [flink] KurtYoung commented on a change in pull request #8356: [FLINK-12424] [table-planner-blink] Supports dag (multiple-sinks query) optimization

2019-05-12 Thread GitBox
KurtYoung commented on a change in pull request #8356: [FLINK-12424] [table-planner-blink] Supports dag (multiple-sinks query) optimization URL: https://github.com/apache/flink/pull/8356#discussion_r283169722 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/ap

[GitHub] [flink] KurtYoung commented on a change in pull request #8356: [FLINK-12424] [table-planner-blink] Supports dag (multiple-sinks query) optimization

2019-05-12 Thread GitBox
KurtYoung commented on a change in pull request #8356: [FLINK-12424] [table-planner-blink] Supports dag (multiple-sinks query) optimization URL: https://github.com/apache/flink/pull/8356#discussion_r283169137 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/ap

[GitHub] [flink] KurtYoung commented on a change in pull request #8356: [FLINK-12424] [table-planner-blink] Supports dag (multiple-sinks query) optimization

2019-05-12 Thread GitBox
KurtYoung commented on a change in pull request #8356: [FLINK-12424] [table-planner-blink] Supports dag (multiple-sinks query) optimization URL: https://github.com/apache/flink/pull/8356#discussion_r283168624 ## File path: flink-table/flink-table-planner-blink/src/main/scala/org/ap

[GitHub] [flink] bowenli86 commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib

2019-05-12 Thread GitBox
bowenli86 commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#discussion_r283168261 ## File path: flink-ml/flink-ml-api/src/main/java/org/apache/flink/ml/api/misc/persist/Persistab

[GitHub] [flink] bowenli86 commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib

2019-05-12 Thread GitBox
bowenli86 commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#discussion_r283166023 ## File path: flink-ml/flink-ml-api/pom.xml ## @@ -0,0 +1,45 @@ + + +http://maven.apach

[GitHub] [flink] bowenli86 commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib

2019-05-12 Thread GitBox
bowenli86 commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#discussion_r283167391 ## File path: flink-ml/flink-ml-api/src/main/java/org/apache/flink/ml/api/core/Pipeline.java ##

[GitHub] [flink] KurtYoung commented on a change in pull request #8302: [FLINK-12269][table-blink] Support Temporal Table Join in blink planner and runtime

2019-05-12 Thread GitBox
KurtYoung commented on a change in pull request #8302: [FLINK-12269][table-blink] Support Temporal Table Join in blink planner and runtime URL: https://github.com/apache/flink/pull/8302#discussion_r283168033 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apa

[GitHub] [flink] KurtYoung commented on a change in pull request #8407: [FLINK-12374][table-planner-blink] Support translation from StreamExecTableSourceScan/BatchExecTableSourceScan to StreamTransfor

2019-05-12 Thread GitBox
KurtYoung commented on a change in pull request #8407: [FLINK-12374][table-planner-blink] Support translation from StreamExecTableSourceScan/BatchExecTableSourceScan to StreamTransformation. URL: https://github.com/apache/flink/pull/8407#discussion_r283167016 ## File path: flink-t

[jira] [Closed] (FLINK-12487) Introduce planner rules to rewrite expression and merge calc

2019-05-12 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-12487. -- Resolution: Implemented Fix Version/s: 1.9.0 merge in 1.9.0: b47b5910c16a423504171a2a29230ff1d8

[GitHub] [flink] dianfu commented on a change in pull request #8392: [FLINK-12370][python][travis] Integrated Travis for Python Table API.

2019-05-12 Thread GitBox
dianfu commented on a change in pull request #8392: [FLINK-12370][python][travis] Integrated Travis for Python Table API. URL: https://github.com/apache/flink/pull/8392#discussion_r283166413 ## File path: tools/travis_python_watchdog.sh ## @@ -0,0 +1,196 @@ +#!/usr/bin/env

[GitHub] [flink] KurtYoung merged pull request #8411: [FLINK-12487] [table-planner-blink] Introduce planner rules to rewrite expression and merge calc

2019-05-12 Thread GitBox
KurtYoung merged pull request #8411: [FLINK-12487] [table-planner-blink] Introduce planner rules to rewrite expression and merge calc URL: https://github.com/apache/flink/pull/8411 This is an automated message from the Apach

[GitHub] [flink] dianfu commented on a change in pull request #8392: [FLINK-12370][python][travis] Integrated Travis for Python Table API.

2019-05-12 Thread GitBox
dianfu commented on a change in pull request #8392: [FLINK-12370][python][travis] Integrated Travis for Python Table API. URL: https://github.com/apache/flink/pull/8392#discussion_r283164819 ## File path: tools/travis/stage.sh ## @@ -23,6 +23,7 @@ STAGE_LIBRARIES="librarie

[jira] [Updated] (FLINK-12485) Add a tool to check the user interface of Python Table API aligns with Java Table API.

2019-05-12 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-12485: Description: After FLINK-12407 Python Table API will align with current Java Table API. So, In th

[jira] [Updated] (FLINK-12485) Add a tool to check the user interface of Python Table API aligns with Java Table API.

2019-05-12 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-12485: Environment:     was: After FLINK-12407 Python Table API will align with current Java Table AP

[GitHub] [flink] flinkbot edited a comment on issue #8338: [BP-1.6][FLINK-12296][StateBackend] Fix local state directory collision with state loss for chained keyed operators

2019-05-12 Thread GitBox
flinkbot edited a comment on issue #8338: [BP-1.6][FLINK-12296][StateBackend] Fix local state directory collision with state loss for chained keyed operators URL: https://github.com/apache/flink/pull/8338#issuecomment-489284633 Thanks a lot for your contribution to the Apache Flink project.

[GitHub] [flink] klion26 commented on issue #8338: [BP-1.6][FLINK-12296][StateBackend] Fix local state directory collision with state loss for chained keyed operators

2019-05-12 Thread GitBox
klion26 commented on issue #8338: [BP-1.6][FLINK-12296][StateBackend] Fix local state directory collision with state loss for chained keyed operators URL: https://github.com/apache/flink/pull/8338#issuecomment-491642057 @flinkbot attention @StefanRRichter -

[GitHub] [flink] walterddr commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib

2019-05-12 Thread GitBox
walterddr commented on a change in pull request #8402: [FLINK-12473][ml] Add the interface of ML pipeline and ML lib URL: https://github.com/apache/flink/pull/8402#discussion_r283158556 ## File path: flink-ml/pom.xml ## @@ -0,0 +1,39 @@ + + +http://maven.apache.org/POM/4.0

[GitHub] [flink] flinkbot commented on issue #8422: FLINK-12493 [docs] Add step to export Hadoop classpath

2019-05-12 Thread GitBox
flinkbot commented on issue #8422: FLINK-12493 [docs] Add step to export Hadoop classpath URL: https://github.com/apache/flink/pull/8422#issuecomment-491633527 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull req

[jira] [Updated] (FLINK-12493) AWS EMR instructions lead to ClassNotFoundException

2019-05-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12493: --- Labels: pull-request-available (was: ) > AWS EMR instructions lead to ClassNotFoundExceptio

[GitHub] [flink] a-romero opened a new pull request #8422: FLINK-12493 [docs] Add step to export Hadoop classpath

2019-05-12 Thread GitBox
a-romero opened a new pull request #8422: FLINK-12493 [docs] Add step to export Hadoop classpath URL: https://github.com/apache/flink/pull/8422 ## What is the purpose of the change Add reference to ensure Hadoop classpath is present before submitting jobs to EMR.

[GitHub] [flink] yuyang08 edited a comment on issue #8067: [FLINK-11746][formats] Add thrift format support to Flink

2019-05-12 Thread GitBox
yuyang08 edited a comment on issue #8067: [FLINK-11746][formats] Add thrift format support to Flink URL: https://github.com/apache/flink/pull/8067#issuecomment-491611680 @Myasuka With this change, we can use the following code to have `ThriftSerializer` work with Flink SQL. Any reason th

[jira] [Updated] (FLINK-12493) AWS EMR instructions lead to ClassNotFoundException

2019-05-12 Thread Alberto Romero (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alberto Romero updated FLINK-12493: --- Priority: Major (was: Critical) > AWS EMR instructions lead to ClassNotFoundException > ---

[jira] [Created] (FLINK-12493) AWS EMR instructions lead to ClassNotFoundException

2019-05-12 Thread Alberto Romero (JIRA)
Alberto Romero created FLINK-12493: -- Summary: AWS EMR instructions lead to ClassNotFoundException Key: FLINK-12493 URL: https://issues.apache.org/jira/browse/FLINK-12493 Project: Flink Issue

[GitHub] [flink] yuyang08 edited a comment on issue #8067: [FLINK-11746][formats] Add thrift format support to Flink

2019-05-12 Thread GitBox
yuyang08 edited a comment on issue #8067: [FLINK-11746][formats] Add thrift format support to Flink URL: https://github.com/apache/flink/pull/8067#issuecomment-491611680 @Myasuka With this change, we can use the following code to have `ThriftSerializer` work with Flink SQL. Any reason th

[GitHub] [flink] yuyang08 edited a comment on issue #8067: [FLINK-11746][formats] Add thrift format support to Flink

2019-05-12 Thread GitBox
yuyang08 edited a comment on issue #8067: [FLINK-11746][formats] Add thrift format support to Flink URL: https://github.com/apache/flink/pull/8067#issuecomment-491611680 @Myasuka With this change, we can use the following code to have `ThriftSerializer` work with Flink SQL. Any reason th

[GitHub] [flink] yuyang08 commented on issue #8067: [FLINK-11746][formats] Add thrift format support to Flink

2019-05-12 Thread GitBox
yuyang08 commented on issue #8067: [FLINK-11746][formats] Add thrift format support to Flink URL: https://github.com/apache/flink/pull/8067#issuecomment-491611680 @Myasuka With this change, we can use the following code to have `ThriftSerializer` work with Flink SQL. Any reason that we n

[GitHub] [flink] flinkbot edited a comment on issue #8421: [FLINK-12492]Minor optimize the cep operator by avoiding unnecessary copy

2019-05-12 Thread GitBox
flinkbot edited a comment on issue #8421: [FLINK-12492]Minor optimize the cep operator by avoiding unnecessary copy URL: https://github.com/apache/flink/pull/8421#issuecomment-491605949 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

  1   2   >