zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce 
partition/gate setup to decouple task registration with NetworkEnvironment
URL: https://github.com/apache/flink/pull/8416#discussion_r283203613
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/InputChannelBuilder.java
 ##########
 @@ -46,6 +48,7 @@
        private int maxBackoff = 0;
        private InputChannelMetrics metrics =
                new 
InputChannelMetrics(UnregisteredMetricGroups.createUnregisteredTaskMetricGroup());
 
 Review comment:
   Here we could use `InputChannelTestUtils.newUnregisteredInputChannelMetrics`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to