zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce
partition/gate setup to decouple task registration with NetworkEnvironment
URL: https://github.com/apache/flink/pull/8416#discussion_r283202445
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
##########
@@ -203,14 +205,20 @@ public void testCancelBeforeActive() throws Exception {
//
---------------------------------------------------------------------------------------------
+ static RemoteInputChannel createRemoteInputChannel(SingleInputGate
inputGate) throws Exception {
+ return createRemoteInputChannel(inputGate,
InputChannelTestUtils.StubMemorySegmentProvider.getInstance());
+ }
+
/**
* Creates and returns a remote input channel for the specific input
gate.
*
* @param inputGate The input gate owns the created input channel.
* @return The new created remote input channel.
*/
- static RemoteInputChannel createRemoteInputChannel(SingleInputGate
inputGate) throws Exception {
- return createRemoteInputChannel(inputGate,
mock(PartitionRequestClient.class));
+ static RemoteInputChannel createRemoteInputChannel(
+ SingleInputGate inputGate, MemorySegmentProvider
memorySegmentProvider) throws Exception {
+
+ return createRemoteInputChannel(inputGate,
mock(PartitionRequestClient.class), 0, 0, memorySegmentProvider);
Review comment:
It is better to avoid mock `PartitionRequestClient` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
