KurtYoung commented on a change in pull request #8356: [FLINK-12424] [table-planner-blink] Supports dag (multiple-sinks query) optimization URL: https://github.com/apache/flink/pull/8356#discussion_r283168624
########## File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/optimize/RelNodeBlock.scala ########## @@ -0,0 +1,402 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.plan.optimize + +import org.apache.flink.table.api.{PlannerConfigOptions, TableConfig, TableEnvironment} +import org.apache.flink.table.plan.nodes.calcite.Sink +import org.apache.flink.table.plan.reuse.SubplanReuser.{SubplanReuseContext, SubplanReuseShuttle} +import org.apache.flink.table.plan.rules.logical.WindowPropertiesRules +import org.apache.flink.table.plan.util.{DefaultRelShuttle, ExpandTableScanShuttle} +import org.apache.flink.util.Preconditions + +import com.google.common.collect.Sets +import org.apache.calcite.rel._ +import org.apache.calcite.rel.core.{Aggregate, Project, Snapshot, TableFunctionScan, Union} +import org.apache.calcite.rex.RexNode + +import java.util + +import scala.collection.JavaConversions._ +import scala.collection.mutable + +/** + * A [[RelNodeBlock]] is a sub-tree in the [[RelNode]] plan. All [[RelNode]]s in + * each block have only one [[Sink]] output. + * The nodes in different block will be optimized independently. + * Review comment: I think you need add some comments about how you break a plan into multiple blocks. What kind of operators will be the boundary of the block and why ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
