zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce
partition/gate setup to decouple task registration with NetworkEnvironment
URL: https://github.com/apache/flink/pull/8416#discussion_r283179736
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -98,15 +99,15 @@ private NetworkEnvironment(
ConnectionManager connectionManager,
ResultPartitionManager resultPartitionManager,
TaskEventPublisher taskEventPublisher,
- IOManager ioManager) {
+ ResultPartitionFactory resultPartitionFactory) {
this.config = config;
this.networkBufferPool = networkBufferPool;
this.connectionManager = connectionManager;
this.resultPartitionManager = resultPartitionManager;
this.taskEventPublisher = taskEventPublisher;
- this.ioManager = ioManager;
this.isShutdown = false;
+ this.resultPartitionFactory = resultPartitionFactory;
Review comment:
`this.resultPartitionFactory = resultPartitionFactory` in front of
`this.isShutdown = false`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
