zhijiangW commented on a change in pull request #8416: [FLINK-12331] Introduce
partition/gate setup to decouple task registration with NetworkEnvironment
URL: https://github.com/apache/flink/pull/8416#discussion_r283203263
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
##########
@@ -237,7 +254,8 @@ static RemoteInputChannel createRemoteInputChannel(
SingleInputGate inputGate,
PartitionRequestClient client,
int initialBackoff,
- int maxBackoff) throws Exception {
+ int maxBackoff,
+ MemorySegmentProvider memorySegmentProvider) throws
Exception {
final ConnectionManager connectionManager =
mock(ConnectionManager.class);
when(connectionManager.createPartitionRequestClient(any(ConnectionID.class)))
Review comment:
There are already too many utils here to construct the `RemoteInputChannel`,
but we still miss the units of `{SingleInputGate, PartitionRequestClient,
MemorySegmentProvider}` which could avoid pass
`createRemoteInputChannel(inputGate, client, 0, 0, networkBufferPool)` in
`CreditBasedPartitionRequestClientHandlerTest`.
Maybe we need a separate hotfix for refactoring these parts to make
`connectionManager.createPartitionRequestClient` call in separate tests if
necessary, then we only need one type to construct `RemoteInputChannel`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
