sunjincheng121 commented on a change in pull request #8359:
[FLINK-11051][table] Add streaming window FlatAggregate to Table API
URL: https://github.com/apache/flink/pull/8359#discussion_r283163670
##########
File path:
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/plan/rules/logical/ExtendedAggregateExtractProjectRule.java
##########
@@ -195,8 +206,7 @@ private RelNode getNewAggregate(Aggregate oldAggregate,
RelBuilder relBuilder, M
}
}
- private int getWindowTimeFieldIndex(LogicalWindowAggregate aggregate,
RelNode input) {
- LogicalWindow logicalWindow = aggregate.getWindow();
+ private int getWindowTimeFieldIndex(LogicalWindow logicalWindow,
RelNode input) {
Review comment:
Why we should do this change? I can see one reason is for
`LogicalWindowTableAggregate`, but I do not find out the change about
`LogicalWindowTableAggregate` deal with the time field. Can explain more about
this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
