alamb commented on PR #14616:
URL: https://github.com/apache/datafusion/pull/14616#issuecomment-2653424551
FWIW I think we can merge this PR and then keep moving code around as follow
on PRs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
alamb commented on PR #14625:
URL: https://github.com/apache/datafusion/pull/14625#issuecomment-2653416218
Thank you @xudong963 and @jayzhan211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
Blizzara commented on PR #14553:
URL: https://github.com/apache/datafusion/pull/14553#issuecomment-2654013073
Thanks, seems like a clear enough bug, appreciate both the report and the PR
to fix it!
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
jkosh44 commented on code in PR #14532:
URL: https://github.com/apache/datafusion/pull/14532#discussion_r1952912279
##
datafusion/expr-common/src/signature.rs:
##
@@ -286,6 +258,72 @@ impl Display for ArrayFunctionSignature {
}
}
+/// A wrapper around a vec of [`ArrayFun
kazantsev-maksim commented on PR #1343:
URL:
https://github.com/apache/datafusion-comet/pull/1343#issuecomment-2654088772
Thanks @kazuyukitanimura. I've fixed the formatting in the `native` module
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
codecov-commenter commented on PR #1392:
URL:
https://github.com/apache/datafusion-comet/pull/1392#issuecomment-2654124657
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1392?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
andygrove commented on PR #1380:
URL:
https://github.com/apache/datafusion-comet/pull/1380#issuecomment-2654127513
> It's hard to spot the two functional changes made in this PR because of
the large amount of code moved. Can you tag the places where the changes were
made?
Sure, func
jkosh44 commented on PR #14532:
URL: https://github.com/apache/datafusion/pull/14532#issuecomment-2654129469
> It is because of this, I think we now only coerce to list if the flag is
set
Are you saying that the function should look something like this?
```Rust
fn array(
andygrove commented on code in PR #1380:
URL: https://github.com/apache/datafusion-comet/pull/1380#discussion_r1952928795
##
spark/src/main/scala/org/apache/comet/serde/aggregates.scala:
##
@@ -0,0 +1,734 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Blizzara opened a new issue, #14632:
URL: https://github.com/apache/datafusion/issues/14632
### Describe the bug
When a Substrait plan contains e.g. an CASE WHEN statement, where one arm
returns a named struct, and another arm returns a non-named struct, the names
are handled incorre
EmilyMatt opened a new issue, #1393:
URL: https://github.com/apache/datafusion-comet/issues/1393
### What is the problem the feature request solves?
I think the documentation is not clear enough on this.
Using a clean main branch, I tried running
`./mvnw -pl spark
-Dsuites="org.
Dandandan commented on PR #14411:
URL: https://github.com/apache/datafusion/pull/14411#issuecomment-2654136409
> > > I wonder why tpch_mem_sf10 is slower for some queries? Might it be
possible the created memtable is not created evenly because of the new round
robin (that might be fixable e
jkosh44 commented on code in PR #14532:
URL: https://github.com/apache/datafusion/pull/14532#discussion_r1952948300
##
datafusion/functions-nested/src/array_has.rs:
##
@@ -94,7 +94,7 @@ impl Default for ArrayHas {
impl ArrayHas {
pub fn new() -> Self {
Self {
-
andygrove commented on PR #60:
URL: https://github.com/apache/datafusion-ray/pull/60#issuecomment-2654222146
Thanks @robtandy. There has been a lot of progress and I agree that it would
be good to merge this.
The Kubernetes CI tests are failing, which is not surprising. Do we want to
Omega359 commented on PR #12116:
URL: https://github.com/apache/datafusion/pull/12116#issuecomment-2655362249
@alamb should be, yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
Omega359 commented on PR #14636:
URL: https://github.com/apache/datafusion/pull/14636#issuecomment-2655363307
I'll check this out tomorrow. we've been chatting about our approaches on
#14563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
skyzh commented on PR #14595:
URL: https://github.com/apache/datafusion/pull/14595#issuecomment-2655639889
Okay, I just realized that the plan is not correct. I'll need to do more
transformation to make it work :(
So back to the semantics of the lateral join,
```
SELECT *
jayzhan211 commented on issue #14634:
URL: https://github.com/apache/datafusion/issues/14634#issuecomment-2655380153
Even though `Expr::Wildcard` has been removed, we still need an equivalent
concept and a way to "expand wildcard"
--
This is an automated message from the Apache Git Servic
parthchandra commented on code in PR #1376:
URL: https://github.com/apache/datafusion-comet/pull/1376#discussion_r1953768242
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -145,88 +145,134 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPla
zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1953772428
##
datafusion/common/src/dfschema.rs:
##
@@ -1028,21 +1028,41 @@ impl SchemaExt for Schema {
})
}
-fn logically_equivalent_names_and_ty
milenkovicm commented on issue #1180:
URL:
https://github.com/apache/datafusion-ballista/issues/1180#issuecomment-2655674033
Client need access to files during logical planning phase in order to setup
appropriate table scan
--
This is an automated message from the Apache Git Service.
To
2010YOUY01 commented on PR #14566:
URL: https://github.com/apache/datafusion/pull/14566#issuecomment-2655677717
Thank you, this looks good to me. Let's get the CI fixed.
https://github.com/apache/datafusion/blob/main/datafusion/core/tests/fuzz_cases/aggregate_fuzz.rs
should have good
jkosh44 commented on PR #14532:
URL: https://github.com/apache/datafusion/pull/14532#issuecomment-2655302737
> It might because of `array_coercion` you set for the function is incorrect
🤔
The query that fails is `array.slt:1221` which is
```
query IT
select array_element(arro
rkrishn7 commented on issue #14634:
URL: https://github.com/apache/datafusion/issues/14634#issuecomment-2655366067
@jayzhan211 Definitely, I don't think it's blocking either. I guess I was
just thinking that if `Expr::Wildcard` gets removed, then it removes the need
for this work. But sound
djanderson commented on PR #14286:
URL: https://github.com/apache/datafusion/pull/14286#issuecomment-2655439836
I checked out this PR and tried to add a test to reproduce the issue.
Including here although it's definitely too dependency heavy for a unit test:
#[tokio::test
parthchandra commented on PR #1387:
URL:
https://github.com/apache/datafusion-comet/pull/1387#issuecomment-2655443473
I had the impression that this PR had originally reduced the number of
failures in native_iceberg_compat as well but that is no longer true after the
cleanup. Is that corre
xudong963 opened a new issue, #14638:
URL: https://github.com/apache/datafusion/issues/14638
### Is your feature request related to a problem or challenge?
```
> select to_char(arrow_cast('2023-09-04'::date, 'Timestamp(Second,
Some("UTC"))'), '%Y-%m-%dT%H:%M:%S%.3f');
This featu
parthchandra commented on code in PR #1387:
URL: https://github.com/apache/datafusion-comet/pull/1387#discussion_r1953778478
##
native/core/src/parquet/parquet_support.rs:
##
@@ -618,174 +143,20 @@ fn cast_array(
Dictionary(_, _) => Arc::new(casted_dictionary.cl
xudong963 commented on PR #14624:
URL: https://github.com/apache/datafusion/pull/14624#issuecomment-2655349713
Thanks all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
xudong963 closed issue #14522: Nullable doesn't work when create memory table
URL: https://github.com/apache/datafusion/issues/14522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
xudong963 merged PR #14624:
URL: https://github.com/apache/datafusion/pull/14624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@data
wForget commented on code in PR #1379:
URL: https://github.com/apache/datafusion-comet/pull/1379#discussion_r1953731417
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -1354,9 +1354,14 @@ object CometSparkSessionExtensions extends Logging {
dhegberg opened a new pull request, #14639:
URL: https://github.com/apache/datafusion/pull/14639
## Which issue does this PR close?
- Partially addresses #13570 .
## Rationale for this change
Add basic documentation for SQL PREPARE and the handling in Data
wForget opened a new pull request, #1396:
URL: https://github.com/apache/datafusion-comet/pull/1396
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## How are these changes t
zhuqi-lucas commented on issue #12136:
URL: https://github.com/apache/datafusion/issues/12136#issuecomment-2655549725
Thanks @xuchen-plus , unluckily after change to 32MB for
sort_spill_reservation_bytes, it still failed, i am not sure which i am missing.
--
This is an automated message f
Ramjee194 commented on PR #14611:
URL: https://github.com/apache/datafusion/pull/14611#issuecomment-2654294377
#14611 A cache control header is missing or empty .
A cache control header is mising or empty
meta[name=theme-color]' is not supported by Firefox.
Button type attribute has
andygrove commented on PR #1390:
URL:
https://github.com/apache/datafusion-comet/pull/1390#issuecomment-2654307818
Thanks @EmilyMatt. Would it be possible to add a test to reproduce the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
milenkovicm commented on issue #1180:
URL:
https://github.com/apache/datafusion-ballista/issues/1180#issuecomment-2654359041
> I can confirm the scheduler has the file loaded onto it because I can "sh"
into the cluster and view the file with "ls".
client needs to list the files and e
andygrove commented on code in PR #1386:
URL: https://github.com/apache/datafusion-comet/pull/1386#discussion_r1953178365
##
common/src/main/scala/org/apache/comet/CometConf.scala:
##
@@ -504,8 +504,8 @@ object CometConf extends ShimCometConf {
.doc(
"The type of mem
andygrove commented on code in PR #1386:
URL: https://github.com/apache/datafusion-comet/pull/1386#discussion_r1953180065
##
native/core/src/execution/jni_api.rs:
##
@@ -319,6 +320,7 @@ fn parse_memory_pool_config(
"greedy_global" =>
MemoryPoolConfig::new(MemoryPoo
kazuyukitanimura commented on PR #1386:
URL:
https://github.com/apache/datafusion-comet/pull/1386#issuecomment-2654507066
Merged, thanks @parthchandra @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
kazuyukitanimura merged PR #1386:
URL: https://github.com/apache/datafusion-comet/pull/1386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
kazuyukitanimura commented on code in PR #1386:
URL: https://github.com/apache/datafusion-comet/pull/1386#discussion_r1953181357
##
common/src/main/scala/org/apache/comet/CometConf.scala:
##
@@ -504,8 +504,8 @@ object CometConf extends ShimCometConf {
.doc(
"The type
mildbyte commented on issue #14633:
URL: https://github.com/apache/datafusion/issues/14633#issuecomment-2654526480
https://github.com/search?q=repo%3Aapache%2Fdatafusion-sqlparser-rs%20supports_filter_during_aggregation&type=code
So as a workaround we could use any dialect that suppor
rkrishn7 commented on issue #14618:
URL: https://github.com/apache/datafusion/issues/14618#issuecomment-2654832263
+1
I'd be happy to help here. I can start by taking on moving
`ExpandWildcardRule`
--
This is an automated message from the Apache Git Service.
To respond to the messa
rkrishn7 opened a new issue, #14634:
URL: https://github.com/apache/datafusion/issues/14634
### Is your feature request related to a problem or challenge?
Related to #14618.
The first step in integrating analyzer rules in the builder stage is moving
`ExpandWildcardRule` out of
kazuyukitanimura commented on code in PR #1377:
URL: https://github.com/apache/datafusion-comet/pull/1377#discussion_r1953403442
##
.github/actions/setup-builder/action.yaml:
##
@@ -34,6 +34,7 @@ runs:
run: |
apt-get update
apt-get install -y protobuf-co
findepi opened a new issue, #14635:
URL: https://github.com/apache/datafusion/issues/14635
`Wildcard` is not an expression. It should not be part of `Expr` enum
it doesn't even have a type
https://github.com/apache/datafusion/blob/68e372f2952bae884590f0589f23e28fb8bc3eaf/datafusion/ex
findepi commented on issue #14618:
URL: https://github.com/apache/datafusion/issues/14618#issuecomment-2654864803
> The role of the Analyzer is unclear to me. Having two types of
"optimization" after the plan is completed doesn’t seem necessary. Instead, we
should have one optimization step
findepi closed issue #14635: Remove `Wildcard` from `Expr`
URL: https://github.com/apache/datafusion/issues/14635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
robtandy commented on PR #60:
URL: https://github.com/apache/datafusion-ray/pull/60#issuecomment-2654267535
I don't know much yet about setting up CI, if you/we can disable, please do.
My preference would be land this, and sort out the housekeeping like tasks we
need to do in order to get
blaginin commented on issue #14563:
URL: https://github.com/apache/datafusion/issues/14563#issuecomment-2654717456
I really like that idea, Bruce! I tried to break your branch, but everything
seems to work 🙂 I think the issue was that on every rename, we tried to
recursively normalize _ever
mbutrovich commented on PR #1387:
URL:
https://github.com/apache/datafusion-comet/pull/1387#issuecomment-2654730899
Updated the test failures in the original description.
`native_iceberg_compat` really does not like this change.
--
This is an automated message from the Apache Git Service
kazuyukitanimura commented on code in PR #1379:
URL: https://github.com/apache/datafusion-comet/pull/1379#discussion_r1953331376
##
spark/src/main/scala/org/apache/spark/Plugins.scala:
##
@@ -62,7 +62,13 @@ class CometDriverPlugin extends DriverPlugin with Logging
with ShimCome
codecov-commenter commented on PR #1390:
URL:
https://github.com/apache/datafusion-comet/pull/1390#issuecomment-2654449945
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1390?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
jkosh44 commented on issue #14633:
URL: https://github.com/apache/datafusion/issues/14633#issuecomment-2654537260
> So as a workaround we could use any dialect that supports it (e.g.
postgresql), gotcha.
That sounds like it should work. From some googling it looks like the
`FILTER` c
Omega359 commented on issue #14563:
URL: https://github.com/apache/datafusion/issues/14563#issuecomment-2654798363
I'll be honest - I'm pretty out of my element with these changes. I don't
know what is 'correct behaviour' and what isn't here. My thinking for the
changes in my current branch
djanderson commented on PR #14286:
URL: https://github.com/apache/datafusion/pull/14286#issuecomment-2654795222
Is there extra work I'd need to do to get this to work with the
`ParquetSink`? This isn't a full reproducer but just a quick copy of the
relevant section of the `do_put_statement_
benrsatori commented on code in PR #1723:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1723#discussion_r1953366365
##
tests/sqlparser_postgres.rs:
##
@@ -2057,13 +2057,13 @@ fn parse_pg_custom_binary_ops() {
// Here, we test the ones used by common extension
kazuyukitanimura commented on code in PR #1379:
URL: https://github.com/apache/datafusion-comet/pull/1379#discussion_r1953334086
##
spark/src/main/scala/org/apache/spark/Plugins.scala:
##
@@ -62,7 +62,13 @@ class CometDriverPlugin extends DriverPlugin with Logging
with ShimCome
benrsatori commented on code in PR #1723:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1723#discussion_r1953345423
##
src/ast/operator.rs:
##
@@ -121,11 +136,11 @@ pub enum BinaryOperator {
MyIntegerDivide,
/// Support for custom operators (such as Post
benrsatori commented on code in PR #1723:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1723#discussion_r1953345106
##
src/ast/operator.rs:
##
@@ -53,6 +53,16 @@ pub enum UnaryOperator {
PGAbs,
/// Unary logical not operator: e.g. `! false` (Hive-specifi
anlinc commented on code in PR #14553:
URL: https://github.com/apache/datafusion/pull/14553#discussion_r1953345644
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -1090,11 +1090,31 @@ impl LogicalPlanBuilder {
group_expr: impl IntoIterator>,
aggr_expr: im
benrsatori commented on code in PR #1723:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1723#discussion_r1953344303
##
src/ast/operator.rs:
##
@@ -77,13 +92,13 @@ impl fmt::Display for UnaryOperator {
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
kazuyukitanimura commented on code in PR #1379:
URL: https://github.com/apache/datafusion-comet/pull/1379#discussion_r195448
##
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##
@@ -1354,9 +1354,14 @@ object CometSparkSessionExtensions extends Loggi
benrsatori commented on code in PR #1723:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1723#discussion_r1953347665
##
src/ast/operator.rs:
##
@@ -253,6 +268,40 @@ pub enum BinaryOperator {
/// Specifies a test for an overlap between two datetime periods:
benrsatori commented on code in PR #1723:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1723#discussion_r1953348633
##
src/parser/mod.rs:
##
@@ -1411,6 +1420,33 @@ impl<'a> Parser<'a> {
),
})
}
+tok @
anlinc commented on code in PR #14553:
URL: https://github.com/apache/datafusion/pull/14553#discussion_r1953345644
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -1090,11 +1090,31 @@ impl LogicalPlanBuilder {
group_expr: impl IntoIterator>,
aggr_expr: im
benrsatori commented on code in PR #1723:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1723#discussion_r1953349274
##
src/test_utils.rs:
##
@@ -284,6 +284,17 @@ where
dialects
}
+pub fn only_psql_redshift() -> TestedDialects {
+TestedDialects {
+
benrsatori commented on code in PR #1723:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1723#discussion_r1953348166
##
src/parser/mod.rs:
##
@@ -1350,7 +1351,15 @@ impl<'a> Parser<'a> {
Ok(Some(expr)) => Ok(expr),
// No
anlinc commented on code in PR #14553:
URL: https://github.com/apache/datafusion/pull/14553#discussion_r1953347407
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -1090,11 +1090,31 @@ impl LogicalPlanBuilder {
group_expr: impl IntoIterator>,
aggr_expr: im
benrsatori commented on code in PR #1723:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1723#discussion_r1953345692
##
src/ast/operator.rs:
##
@@ -253,6 +268,40 @@ pub enum BinaryOperator {
/// Specifies a test for an overlap between two datetime periods:
alamb commented on PR #14286:
URL: https://github.com/apache/datafusion/pull/14286#issuecomment-2654986803
> Is there extra work I'd need to do to get this to work with the
`ParquetSink`? This isn't a full reproducer but just a quick copy of the
relevant section of the `do_put_statement_ing
alamb commented on issue #3843:
URL: https://github.com/apache/datafusion/issues/3843#issuecomment-2654991464
Thanks @clflushopt
I don't have a great handle in my head on the current state of Boundary and
Selectivity anaylsis. Maybe your first PRs could focus on adding some docs and
rkrishn7 commented on issue #14634:
URL: https://github.com/apache/datafusion/issues/14634#issuecomment-2654992676
Waiting until we decide on a path forward in
https://github.com/apache/datafusion/issues/7765
--
This is an automated message from the Apache Git Service.
To respond to the m
kazuyukitanimura commented on PR #1351:
URL:
https://github.com/apache/datafusion-comet/pull/1351#issuecomment-2654992219
Question @andygrove @parthchandra @comphead
Can any of the child node be decimal calculations? Calling
`exprToProtoInternal` will skip `DecimalPrecision.promote()`.
mbutrovich commented on PR #1150:
URL:
https://github.com/apache/datafusion-comet/pull/1150#issuecomment-2654998780
I'll see about reviving it tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
djanderson commented on code in PR #14286:
URL: https://github.com/apache/datafusion/pull/14286#discussion_r1953482293
##
datafusion-examples/examples/thread_pools.rs:
##
@@ -0,0 +1,238 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
alamb closed pull request #13370: feat: Support `Utf8View` for `get_wider_type`
+ `binary_to_string_coercion` functions
URL: https://github.com/apache/datafusion/pull/13370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
alamb commented on issue #14607:
URL: https://github.com/apache/datafusion/issues/14607#issuecomment-2655004320
> Seems like the best way would be to configure FileGroupPartitioner through
FileSource. The other option would be to make FileRange an enum, but that would
still mean we (and any
alamb commented on PR #12116:
URL: https://github.com/apache/datafusion/pull/12116#issuecomment-2655006559
What is the status of this PR? Is is ready for a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
alamb commented on PR #14567:
URL: https://github.com/apache/datafusion/pull/14567#issuecomment-2655007520
This is on my list of PRs to review tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
anlinc commented on code in PR #14553:
URL: https://github.com/apache/datafusion/pull/14553#discussion_r1953514409
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -1090,11 +1090,31 @@ impl LogicalPlanBuilder {
group_expr: impl IntoIterator>,
aggr_expr: im
anlinc commented on code in PR #14553:
URL: https://github.com/apache/datafusion/pull/14553#discussion_r1953514141
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -1090,11 +1090,31 @@ impl LogicalPlanBuilder {
group_expr: impl IntoIterator>,
aggr_expr: im
djanderson commented on code in PR #14286:
URL: https://github.com/apache/datafusion/pull/14286#discussion_r1953490590
##
datafusion-examples/examples/thread_pools.rs:
##
@@ -0,0 +1,238 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lic
dependabot[bot] opened a new pull request, #14619:
URL: https://github.com/apache/datafusion/pull/14619
Bumps [clap](https://github.com/clap-rs/clap) from 4.5.28 to 4.5.29.
Release notes
Sourced from https://github.com/clap-rs/clap/releases";>clap's releases.
v4.5.29
[4.5.
dependabot[bot] opened a new pull request, #14621:
URL: https://github.com/apache/datafusion/pull/14621
Bumps [prost](https://github.com/tokio-rs/prost) from 0.13.4 to 0.13.5.
Changelog
Sourced from https://github.com/tokio-rs/prost/blob/master/CHANGELOG.md";>prost's
changelog.
dependabot[bot] opened a new pull request, #14620:
URL: https://github.com/apache/datafusion/pull/14620
Bumps [bzip2](https://github.com/trifectatechfoundation/bzip2-rs) from 0.5.0
to 0.5.1.
Commits
https://github.com/trifectatechfoundation/bzip2-rs/commit/dbbc3b46809ed15d6dc40
dependabot[bot] opened a new pull request, #14623:
URL: https://github.com/apache/datafusion/pull/14623
Bumps [prost-build](https://github.com/tokio-rs/prost) from 0.13.4 to 0.13.5.
Changelog
Sourced from https://github.com/tokio-rs/prost/blob/master/CHANGELOG.md";>prost-build's
ch
alamb commented on PR #13370:
URL: https://github.com/apache/datafusion/pull/13370#issuecomment-2655005676
I think we have merged all relevant parts of this PR so closing this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
wiedld opened a new pull request, #14637:
URL: https://github.com/apache/datafusion/pull/14637
## Which issue does this PR close?
I'll make a new issue, once we confirm this reproducer is a bug.
## Rationale for this change
We have physical plans which are failing in the
djanderson commented on PR #14286:
URL: https://github.com/apache/datafusion/pull/14286#issuecomment-2655024463
> What is the panic error message?
Panic error message is just
> error=status: DataLoss, message: "data write failed: IO error: Error
joining spawned task: task 93
codecov-commenter commented on PR #1395:
URL:
https://github.com/apache/datafusion-comet/pull/1395#issuecomment-2655116606
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1395?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
TylerBrinks commented on PR #1715:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1715#issuecomment-2655131625
@alamb Anything else I need to address? I'm learning the standard Rust way
of doing things, hoping I got it right based on the PR checks in place.
--
This is an au
jayzhan211 commented on code in PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#discussion_r1953648058
##
datafusion/expr-common/src/signature.rs:
##
@@ -365,7 +365,12 @@ impl TypeSignature {
}
}
-/// get all possible types for the given `Type
parthchandra commented on code in PR #1376:
URL: https://github.com/apache/datafusion-comet/pull/1376#discussion_r1953648631
##
spark/src/test/scala/org/apache/comet/CometArrayExpressionSuite.scala:
##
@@ -39,12 +39,14 @@ class CometArrayExpressionSuite extends CometTestBase wit
alamb commented on code in PR #14637:
URL: https://github.com/apache/datafusion/pull/14637#discussion_r1953591399
##
datafusion/core/tests/physical_optimizer/enforce_sorting.rs:
##
@@ -2280,3 +2285,62 @@ async fn
test_not_replaced_with_partial_sort_for_unbounded_input() -> Resu
slyons commented on code in PR #14286:
URL: https://github.com/apache/datafusion/pull/14286#discussion_r1953478390
##
datafusion-examples/examples/thread_pools.rs:
##
@@ -0,0 +1,238 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
andygrove commented on code in PR #1395:
URL: https://github.com/apache/datafusion-comet/pull/1395#discussion_r1953532505
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2722,7 +2721,16 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde
andygrove commented on code in PR #1376:
URL: https://github.com/apache/datafusion-comet/pull/1376#discussion_r1953540948
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -145,88 +145,134 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHe
101 - 200 of 253 matches
Mail list logo
