benrsatori commented on code in PR #1723:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1723#discussion_r1953344303
##########
src/ast/operator.rs:
##########
@@ -77,13 +92,13 @@ impl fmt::Display for UnaryOperator {
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
pub enum BinaryOperator {
- /// Plus, e.g. `a + b`
+ /// `+` Addition, also Translation (PostgreSQL/Redshift geometric
operator), e.g. `box '((0,0),(1,1))' + point '(2.0,0)'`
Plus,
- /// Minus, e.g. `a - b`
+ /// `-` Subtraction, Translation (PostgreSQL/Redshift geometric operator),
e.g. `box '((0,0),(1,1))' - point '(2.0,0)'`
Minus,
- /// Multiply, e.g. `a * b`
+ /// `*` Multiplication, also Scaling (PostgreSQL/Redshift geometric
operator), e.g. `box '((0,0),(1,1))' * point '(2.0,0)'`
Multiply,
- /// Divide, e.g. `a / b`
+ /// `/` Division, also Scaling (PostgreSQL/Redshift geometric operator),
e.g. `box '((0,0),(2,2))' / point '(2.0,0)'`
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
