jkosh44 commented on PR #14532:
URL: https://github.com/apache/datafusion/pull/14532#issuecomment-2654129469
> It is because of this, I think we now only coerce to list if the flag is
set
Are you saying that the function should look something like this?
```Rust
fn array(
array_type: &DataType,
array_coercion: Option<&ListCoercion>,
) -> Option<DataType> {
match (array_type, array_coercion) {
(
DataType::FixedSizeList(field, _),
Some(ListCoercion::FixedSizedListToList),
) => Some(DataType::List(Arc::clone(field))),
(
DataType::List(_)
| DataType::LargeList(_)
| DataType::FixedSizeList(_, _),
_,
) => Some(array_type.clone()),
_ => None,
}
}
```
Doing that causes some tests in `array.slt` to fail and I'm not really sure
why. It also doesn't match the previous behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
