Blizzara opened a new issue, #14632:
URL: https://github.com/apache/datafusion/issues/14632
### Describe the bug
When a Substrait plan contains e.g. an CASE WHEN statement, where one arm
returns a named struct, and another arm returns a non-named struct, the names
are handled incorrectly.
### To Reproduce
Add the following to roundtrip_logical_plans.rs:
```
#[tokio::test]
async fn roundtrip_named_struct() -> Result<()> {
roundtrip("SELECT (CASE WHEN column1 IS NOT NULL THEN named_struct('f1',
column1) ELSE NULL END) as res FROM (VALUES ('a'), (NULL))").await
}
```
This results in an error:
```
assertion `left == right` failed
left: "Projection: CASE WHEN column1 IS NOT NULL THEN
named_struct(Utf8(\"f1\"), column1) ELSE Struct({f1:}) END AS res\n Values:
(Utf8(\"a\")), (Utf8(NULL))"
right: "Projection: CASE WHEN column1 IS NOT NULL THEN
CAST(named_struct(Utf8(\"f1\"), column1) AS Struct([Field { name: \"c0\",
data_type: Utf8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata:
{} }])) ELSE Struct({c0:}) END AS res\n Values: (Utf8(\"a\")), (Utf8(NULL))"
```
The test might fail anyways, but what's meaningful is that the error says DF
is trying to cast the named_struct into having "c0" as the field name, rather
than "f1" as was intended. This is despite the Substrait plan defining the
output names correctly: `names: ["res", "f1"]`. The issue is likely due to the
two arms of the case-when statement having differing output types, which
confuses the renaming logic somehow.
### Expected behavior
The names of the named_struct should take precedence, if names mismatch then
an error should likely be thrown.
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
