benrsatori commented on code in PR #1723: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1723#discussion_r1953345423
########## src/ast/operator.rs: ########## @@ -121,11 +136,11 @@ pub enum BinaryOperator { MyIntegerDivide, /// Support for custom operators (such as Postgres custom operators) Custom(String), - /// Bitwise XOR, e.g. `a # b` (PostgreSQL-specific) + // `#` PostgreSQL Bitwise XOR, also Intersection (PostgreSQL/Redshift geometric operator), e.g. `box '((1,-1),(-1,1))' # box '((1,1),(-2,-2))'` PGBitwiseXor, - /// Bitwise shift left, e.g. `a << b` (PostgreSQL-specific) + /// `<<` PostgreSQL Bitwise Shift Left, also Left of? (PostgreSQL/Redshift geometric operator), e.g. circle '((0,0),1)' << circle '((5,0),1)' PGBitwiseShiftLeft, - /// Bitwise shift right, e.g. `a >> b` (PostgreSQL-specific) + /// `>>` PostgreSQL Bitwise Shift Right, Right of? (PostgreSQL/Redshift geometric operator), e.g. circle '((5,0),1)' >> circle '((0,0),1)' Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org