benrsatori commented on code in PR #1723:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1723#discussion_r1953366365
##########
tests/sqlparser_postgres.rs:
##########
@@ -2057,13 +2057,13 @@ fn parse_pg_custom_binary_ops() {
// Here, we test the ones used by common extensions
let operators = [
// PostGIS
- "&&&", // n-D bounding boxes intersect
- "&<", // (is strictly to the left of)
- "&>", // (is strictly to the right of)
+ "&&&", // n-D bounding boxes intersect
+ //"&<", // (is strictly to the left of) // Same as
OverlapsToLeft, causes duplicate failure
+ //"&>", // (is strictly to the right of) // Same as
OverlapsToRight, causes duplicate failure
"|=|", // distance between A and B trajectories at their closest
point of approach
"<<#>>", // n-D distance between A and B bounding boxes
- "|>>", // A's bounding box is strictly above B's.
- "~=", // bounding box is the same
+ //"|>>", // A's bounding box is strictly above B's. // Same as
IsStrictlyAbove, causes duplicate failure
+ //"~=", // bounding box is the same // Same as
SameAs, causes duplicate failure
Review Comment:
The commented-out operators are already defined under different names in the
code,
so they can no longer be considered custom operators.
If we include these again under their original symbols, it causes a
duplicate match failure.
so I have now completely removed them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
