findepi commented on issue #14618: URL: https://github.com/apache/datafusion/issues/14618#issuecomment-2654864803
> The role of the Analyzer is unclear to me. Having two types of "optimization" after the plan is completed doesn’t seem necessary. Instead, we should have one optimization step **during plan construction** and another **after the plan is finalized**. I believe these rules can be placed either in the SQL → LogicalPlan building stage or in the optimizer. I would not call them "optimizations". They are simply logical ingredients towards building fully resolved Logical Plan (LP). If we do this issue (+1 from me), we should be able to do - https://github.com/apache/datafusion/issues/12604 - move all the coercion logic out of optimizer and thus achieve https://github.com/apache/datafusion/issues/12723 Even without introducing new IR, just making current LP the IR. So if LP is to be the real IR, we should also plan on making the Expr a real expression: - https://github.com/apache/datafusion/issues/1468 - https://github.com/apache/datafusion/issues/7765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
