[edk2-devel] Tools and CI Meeting no longer on calendar

Has the Tools and CI meeting expired? I’m not seeing any future entries (including today) on the calendar. Rebecca -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120859): https://edk2.groups.io/g/devel/message/120859 Mute This Topic: ht

Re: [edk2-devel] Debugging EFI Runtime crash when trying to update DBX for Secure Boot in Linux (fwupdmgr update)

On 12/2/24 4:29 PM, Pedro Falcato wrote: On Mon, Dec 2, 2024 at 9:25 PM Rebecca Cran via groups.io wrote: I have no idea how to go about debugging why the SetVariable call is causing the crash. Is it likely to be the way I've got dbxDefault set up, or does anyone know how I could deb

[edk2-devel] Debugging EFI Runtime crash when trying to update DBX for Secure Boot in Linux (fwupdmgr update)

I've set up Secure Boot for my firmware, but I'm having problems when trying to have fwupdmgr install a DBX update. Since I've run into problems setting up arm64_DBXUpdate.bin from uefi.org or DefaultDbx.bin from a build of secureboot_objects I'm generating my own certificate and installing th

[edk2-devel] Secure Boot: error enrolling dbx from uefi.org into dbxDefault (file is in wrong format?)

sing as X509. Has anyone else come across this and knows of a solution? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120848): https://edk2.groups.io/g/devel/message/120848 Mute This Topic: https://groups.io/mt/

[edk2-devel] Help getting Capsule-On-Disk working (CapsuleOnDiskLoadPei and gEdkiiPeiBootInCapsuleOnDiskModePpiGuid)

each platform supposed to implement it? I'm working on an AArch64 system where I'm pretty sure memory isn't retained between reboots so Capsule-In-Memory won't work. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Rep

Re: [edk2-devel] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

ups.io; rebe...@os.amperecomputing.com; Rebecca Cran ; leif.lindh...@oss.qualcomm.com Cc: Kinney, Michael D Subject: RE: [edk2-devel] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5) VS1015, VS2017, GCC5 Mike -Original Message- From: devel@edk2.groups.io

Re: [edk2-devel] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

-Original Message- From: Rebecca Cran Sent: Thursday, November 21, 2024 9:05 PM To: Kinney, Michael D ; devel@edk2.groups.io; leif.lindh...@oss.qualcomm.com Subject: Re: [edk2-devel] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5) Hi Mike, I was wondering if

Re: [edk2-devel] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

n Tue, 22 Oct 2024 at 12:19, Rebecca Cran wrote: In addition, since GCC48, GCC49 and GCC5 have been marked deprecated for over a year, I'd like to proceed with removing them as well. Please provide feedback by Thursday October 31st. In the absence of feedback I'll plan to proceed with

Re: [edk2-devel] Capsule validation tool?

Not sure if you want to use the same tool again, but GenerateCapsule can be used to validate them too - it runs 'openssl smime -verify'. e.g.: bcran@delano:/tiano> GenerateCapsule --signer-private-cert certs/cert.pem --other-public-cert certs/intermediate.pub.pem --trusted-public-cert certs/r

Re: [edk2-devel] ArmPlatformPkg: does SecureBootDefaultKeys.fdf.inc need updated to add more DB files?

On 11/5/24 9:46 AM, Doug Flick via groups.io wrote: Hey Rebecca! We actually have the following repo on github/secureboot_objects where you can get Secure Boot default releases and ask questions directly to the team that manages secure boot a

Re: [edk2-devel] ArmPkg,ArmPlatformPkg: Adding nasm files to allow builds with VS2022

On 11/5/24 8:40 AM, Gerd Hoffmann wrote: Has nasm gained support for arm? IIRC it's a x86-only assembler (and the website says so too ...). Yup, you're right - I'd completely forgotten about that. I guess my point was that on Windows the .S files that we have for Arm don't get built, so we l

Re: [edk2-devel] RFC: Updating IA32/X64 cross-compilation to work like other archs

Thanks, I’ll merge this after the stable tag. On Tue, Nov 5, 2024, at 5:45 AM, Gerd Hoffmann wrote: > On Thu, Oct 17, 2024 at 08:21:54PM -0600, Rebecca Cran wrote: >> Cross-compilation to platforms other than IA32 and X64 work by setting an >> environment variable such as GCC_AARC

Re: [edk2-devel] ArmPkg,ArmPlatformPkg: Adding nasm files to allow builds with VS2022

On 11/5/24 5:58 AM, Gerd Hoffmann wrote: On Wed, Oct 23, 2024 at 05:48:46PM -0600, Rebecca Cran wrote: I've been wondering if it might be worth adding nasm files to ArmPkg, ArmPlatformPkg etc. to allow platforms to be built with VS2022 - mainly because different compilers can detect diff

Re: [edk2-devel] Could we reconsider the GitHub stale PR bot please?

On 11/5/24 6:08 AM, Gerd Hoffmann wrote: On Mon, Oct 28, 2024 at 08:34:34PM -0600, Rebecca Cran wrote: See the attached screenshot or https://github.com/tianocore/edk2/pull/5907#issuecomment-2408745999 . The PR was marked stale by the bot and the PR author only responded two weeks later

[edk2-devel] ArmPlatformPkg: does SecureBootDefaultKeys.fdf.inc need updated to add more DB files?

keys/ms_db3.cer curl -L https://go.microsoft.com/fwlink/?linkid=2239872 -o keys/ms_db4.cer Do we only want 3 of the available files, or are all of them relevant? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120715):

[edk2-devel] Hash2DxeCrypto.inf missing from NetworkComponents.dsc.inc (needed for TcpDxe)?

;ing Doug Flick since it looks like he added the dependency on gEfiHash2ServiceBindingProtocolGuid in May with the CVE-2023-45238 patch. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120698): https://edk2.groups.io/

Re: [edk2-devel] Could we reconsider the GitHub stale PR bot please?

> > Mike > >> -Original Message----- >> From: Rebecca Cran >> Sent: Monday, October 28, 2024 7:35 PM >> To: devel@edk2.groups.io >> Cc: Kinney, Michael D >> Subject: Could we reconsider the GitHub stale PR bot please? >> >> See the att

[edk2-devel] Could we reconsider the GitHub stale PR bot please?

See the attached screenshot or https://github.com/tianocore/edk2/pull/5907#issuecomment-2408745999 . The PR was marked stale by the bot and the PR author only responded two weeks later - which would have been one week too late. Fortunately I noticed and commented to keep it open, but I think

Re: [edk2-devel] [PATCH edk2-non-osi 0/1] (RFC) Drivers/Intel/IntelUndiBin: Add binaries for Intel UNDI 29.3 drivers

I got feedback in today's CI and Tools meeting that this isn't something we want in edk2-non-osi. There should be a single source of the binaries, and that's Intel's site, so please ignore this patch. -- Rebecca On 10/27/24 9:50 AM, Rebecca Cran wrote: Add binarie

[edk2-devel] [PATCH edk2-non-osi 0/1] (RFC) Drivers/Intel/IntelUndiBin: Add binaries for Intel UNDI 29.3 drivers

L header. Given Intel are publishing the sources on their website I suspect this is an oversight but I'd like to get confirmation if possible. Rebecca Cran (1): Drivers/Intel/IntelUndiBin: Add binaries for Intel UNDI 29.3 drivers Drivers/Intel/IntelUndiBin/GigUndiBinDebug.inf | 24

Re: [edk2-devel] ArmPkg,ArmPlatformPkg: Adding nasm files to allow builds with VS2022

Awesome, thanks! On Thu, Oct 24, 2024, at 9:48 AM, Oliver Smith-Denny wrote: > On 10/24/2024 2:08 AM, Sami Mujawar wrote: >> Hi Rebecca, >> >> Thank you for bringing up this topic. >> >> I agree we should get Visual Studio compiler support for Arm in edk2. >> The Visual Studio static analysis h

Re: [edk2-devel] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

ated toolchains (GCC48, GCC49, GCC5) >> >> On Tue, 22 Oct 2024 at 12:19, Rebecca Cran wrote: >> > In addition, since GCC48, GCC49 and GCC5 have been marked deprecated >> for >> > over a year, I'd like to proceed with removing them as well. >> > >&g

[edk2-devel] ArmPkg,ArmPlatformPkg: Adding nasm files to allow builds with VS2022

I've been wondering if it might be worth adding nasm files to ArmPkg, ArmPlatformPkg etc. to allow platforms to be built with VS2022 - mainly because different compilers can detect different issues with the code. What do people think: would it be worthwhile, or should we stick with GCC and CLA

[edk2-devel] Adding Intel UNDI source or binaries to tianocore repo(s)

Intel provides the UEFI driver source code for many of their popular network chips at https://www.intel.com/content/www/us/en/download/15755/intel-ethernet-connections-boot-utility-preboot-images-and-efi-drivers.html including: Intel® Ethernet 800 Series -- * Intel® Eth

Re: [edk2-devel] [PATCH] Emulator/X86EmulatorDxe: Replace with MultiArchUefiPkg build

On 10/22/24 5:44 PM, Pedro Falcato wrote: You can build whatever GPL-violating contraption as long as you don't distribute it. If you do, you need to comply with the terms of the license. FWIW, GNU seems to think merely including this module would be a GPL violation (https://www.gnu.org/licenses

Re: [edk2-devel] [edk2-discuss] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

hanks Sean From: mailto:disc...@edk2.groups.io <mailto:disc...@edk2.groups.io> on behalf of Rebecca Cran <mailto:rebe...@bsdio.com> Sent: Tuesday, October 22, 2024 4:18:51 AM To: mailto:devel@edk2.groups.io <mailto:devel@edk2.groups.io>; mailto:disc...@edk2.groups.io &l

[edk2-devel] Removal of VS2015 (and maybe VS2017) and deprecated toolchains (GCC48, GCC49, GCC5)

VS2015, GCC48, GCC49 and GCC5. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120649): https://edk2.groups.io/g/devel/message/120649 Mute This Topic: https://groups.io/mt/109150018/21656 Group Owner: devel+ow...@edk

Re: [edk2-devel] [PATCH] Emulator/X86EmulatorDxe: Replace with MultiArchUefiPkg build

On 10/22/2024 2:48 AM, Chao Li wrote: I see the final licence in non-osi is GPL2.0, so it that allowed for some people build the EmulatorDxe.efi into their FW and release it? I believe it is allowed because tools like Fiano allow you to remove drivers such as EmulatorDxe from the firmware ima

Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

ssage- From: Rebecca Cran Sent: Thursday, October 10, 2024 6:21 PM To: Kinney, Michael D ; devel@edk2.groups.io Cc: Rebecca Cran Subject: [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC` A while ago a decision was made on the edk2-devel ma

[edk2-devel] RFC: Updating IA32/X64 cross-compilation to work like other archs

Cross-compilation to platforms other than IA32 and X64 work by setting an environment variable such as GCC_AARCH64_PREFIX that contains the path/name of the cross-compiler without the "gcc", "objcopy" etc. suffix. On IA32 and X64 however, the environment variable GCC_BIN has been used instead.

[edk2-devel] Intel platform support: does AlderlakeOpenBoardPkg work on the UP Xtreme i12?

I was wondering if Platform/Intel/Readme.md was up-to-date regarding which publicly-available platforms the BoardPkgs can run on (as opposed to the Intel Reference and Validation Platforms which aren't available for purchase)? For example the only board listed for AAEON is the Whiskey Lake boa

Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

On 10/14/24 9:22 AM, Oliver Smith-Denny wrote: In GoogleTest, you often cannot directly include the C file in the GoogleTest file, because C++ complains about many Cisms, mostly our use of casting. Do you have an example of that? Also, I've seen suggestions (I think on the FreeBSD mailing list

Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

...@linux.microsoft.com> has proposed keeping the macro STATIC as a way to enable cleaner and easier unit tests. Did that get resolved? Thanks Sean *From:* devel@edk2.groups.io on behalf of Rebecca Cran *Sent:* Thursd

[edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

p the revision to 2.4 and turn off the draft status. Signed-off-by: Rebecca Cran --- 5_source_files/54_code_file_structure.md| 8 +--- 5_source_files/56_declarations_and_types.md | 2 +- README.md | 3 ++- book.json | 4 ++

Re: [edk2-devel] [PATCH edk2-non-osi v2 0/1] Emulator/X86EmulatorDxe: Replace with MultiArchUefiPkg build

5daf3 (sorry, I forgot to edit the commit message to add your ack before pushing). -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120575): https://edk2.groups.io/g/devel/message/120575 Mute This Topic: https://groups.

Re: [edk2-devel] [PATCH edk2-non-osi v2 0/1] Emulator/X86EmulatorDxe: Replace with MultiArchUefiPkg build

I'm still waiting for a review on this. Andrei suggested we might want to have both versions available for people to use, but unless there's a problem with the new version being GPL I think replacing it makes more sense. -- Rebecca On 9/9/2024 10:10 AM, Rebecca Cran via group

Re: [edk2-devel] [PATCH edk2-non-osi v2 1/1] Emulator/X86EmulatorDxe: Replace with MultiArchUefiPkg build

On 9/9/24 10:13 AM, Ard Biesheuvel via groups.io wrote: On Mon, 9 Sept 2024 at 18:11, Rebecca Cran wrote: Replace the old X86EmulatorDxe with one built from https://github.com/intel/MultiArchUefiPkg. This is a much more modern, recent implementation that's more reliable and is act

[edk2-devel] [PATCH edk2-non-osi v2 0/1] Emulator/X86EmulatorDxe: Replace with MultiArchUefiPkg build

Changes from v1 to v2: Updated the LICENSE file to indicate it's licensed under the GPL. Updated the commit message with an explanation of the licensing. Rebecca Cran (1): Emulator/X86EmulatorDxe: Replace with MultiArchUefiPkg build Emulator/X86EmulatorDxe/X86EmulatorDxe.inf

Re: [edk2-devel] [PATCH] Emulator/X86EmulatorDxe: Replace with MultiArchUefiPkg build

On 9/6/2024 9:25 AM, Ard Biesheuvel via groups.io wrote: arm64 firmware? Or RISC-V? There are many more options now for native drivers on arm64, so I'd expect the relevance of this hack to diminish but I guess RISC-V is at a different point on this curve. arm64. The big thing that's missing is

Re: [edk2-devel] [PATCH] Emulator/X86EmulatorDxe: Replace with MultiArchUefiPkg build

the original did, or because I actively tripped on the NULL accesses from some x86 code I was testing... A -Original Message- From: Ard Biesheuvel Sent: Sunday, September 1, 2024 3:05 AM To: Rebecca Cran ; Warkentin, Andrei Cc: devel@edk2.groups.io; quic_llind...@quicinc.com

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: Move to github pull request workflow

Reviewed-by: Rebecca Cran -- Rebecca On 9/4/24 9:20 AM, Jayaprakash N wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4840 Migrate data from Maintainers.txt to the GitHub standard CODEOWNERS and CONTRIBUTORS.md. The latter file contains mappings from name to email address and

Re: [edk2-devel] [PATCH edk2-platforms v5 1/1] Move to the GitHub Pull Request workflow

Thanks! On 9/4/24 9:59 AM, Kinney, Michael D wrote: Thanks. I found the setting that caused this failure. It is working now. Mike -Original Message- From: Marcin Juszkiewicz Sent: Wednesday, September 4, 2024 8:28 AM To: devel@edk2.groups.io; Kinney, Michael D ; Rebecca Cran

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: Move to github pull request workflow

nt of the CODEOWNERS file. Cc: Rebecca Cran Cc: Michael D Kinney Cc: Jayaprakash N Signed-off-by: Jayaprakash N --- .github/workflows/AssignReviewers.yaml | 34 CODEOWNERS | 21 CONTRIBUTORS.md| 13 + Maintainer

Re: [edk2-devel] [PATCH edk2-platforms v5 1/1] Move to the GitHub Pull Request workflow

49a843ff..f709251f5b Mike -Original Message- From: Rebecca Cran Sent: Tuesday, September 3, 2024 12:44 PM To: devel@edk2.groups.io; Kinney, Michael D ; Leif Lindholm ; Michael Kubacki Subject: Re: [edk2-devel] [PATCH edk2-platforms v5 1/1] Move to the GitHub Pull Request workflow Could you

Re: [edk2-devel] [PATCH edk2-platforms v5 1/1] Move to the GitHub Pull Request workflow

Could you push it please? On Tue, Sep 3, 2024, at 1:25 PM, Michael D Kinney wrote: > Reviewed-by: Michael D Kinney > > >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Rebecca >> Cran >> Sent: Tuesday, September 3, 2024 7:03 AM >>

[edk2-devel] SbsaQemu: SIP_SVC_GET_CPU_TOPOLOGY call failed (need updated binaries in edk2-non-osi?)

Do the TF-A binaries in edk2-non-osi need updated for SbsaQemu? With the binaries in Platform/Qemu/Sbsa I get the following error during boot: GetCpuCount: We have 4 cpus. GetMpidr: MPIDR for CPU0: = 0 GetMpidr: MPIDR for CPU1: = 1 GetMpidr: MPIDR for CPU2: = 2 GetMpidr: MPIDR for CPU3: = 3 Ge

Re: [edk2-devel] [RFC PATCH 1/1] MdePkg/IndustryStandard: add definitions for ACPI 6.4 CEDT

Also, leading underscores are supposed to be reserved for compiler implementations (and there only needs to be a single trailing underscore) so it should really be: __CXL_Early_Discovery_TABLE_H__ -> CXL_EARLY_DISCOVERY_TABLE_H_ -- Rebecca On 8/30/2024 12:06 PM, Michael D Kinney via groups.

Re: [edk2-devel] [PATCH 1/2] AmpereSiliconPkg: Implement BMC Configuration screen

On 8/13/2024 9:18 PM, Nhi Pham wrote: +/** + This function updates the BMC information. + + @param[in] VOID + + @retval EFI_SUCCESS The entry point is executed successfully. + @retval Other Some error occurs when executing this entry point. + +**/ +EFI_STATUS +UpdateBmcConfi

[edk2-devel] [PATCH edk2-platforms v5 1/1] Move to the GitHub Pull Request workflow

/AssignReviewers.yml which adds reviewers to a Pull Request based on the content of the REVIEWERS file. Signed-off-by: Rebecca Cran --- .github/workflows/AssignReviewers.yml | 34 ++ CODEOWNERS| 147 +++ CONTRIBUTORS.md | 70 +++ Maintainers.txt

[edk2-devel] [PATCH edk2-platforms v5 0/1] Move to the GitHub Pull Request workflow

Changes from v4 to v5: Changed "Beagleboard:" comment in CODEOWNERS to "Beagleboard" to improve consistency. Added entries in CONTRIBUTORS.md and CODEOWNERS for new Bosc platform. Rebecca Cran (1): Move to the GitHub Pull Request workflow .github/workflows/Assig

Re: [edk2-devel] [PATCH edk2-platforms v4 1/1] Move to the GitHub Pull Request workflow

inney -Original Message- From: Rebecca Cran Sent: Saturday, August 31, 2024 1:58 PM To: devel@edk2.groups.io; Leif Lindholm ; Kinney, Michael D ; Michael Kubacki Cc: Rebecca Cran Subject: [PATCH edk2-platforms v4 1/1] Move to the GitHub Pull Request workflow Migrate data from Maintainers.txt t

[edk2-devel] [PATCH edk2-platforms v4 1/1] Move to the GitHub Pull Request workflow

/AssignReviewers.yml which adds reviewers to a Pull Request based on the content of the REVIEWERS file. Signed-off-by: Rebecca Cran --- .github/workflows/AssignReviewers.yml | 34 ++ CODEOWNERS| 143 +++ CONTRIBUTORS.md | 68 +++ Maintainers.txt

[edk2-devel] [PATCH edk2-platforms v4 0/1] Move to the GitHub Pull Request workflow

was copied from, since this copy in edk2-platforms should be considered the original. Rebased against latest master and removed the entry for Zailiang Sun. Fixed AssignReviewers.yml etc. based on feedback in the Pull Request (https://github.com/tianocore/edk2-platforms/pull/175). Rebecca Cran (1

Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Maintainers.txt: Use my personal email address

As mentioned on the v1 patch, please ignore this. On 8/21/24 11:00 AM, Rebecca Cran via groups.io wrote: Work with upstream/community is done on my own time, so update my entry to contain my personal email address. Signed-off-by: Rebecca Cran --- Maintainers.txt | 2 +- 1 file changed, 1

Re: [edk2-devel] [PATCH] Maintainers.txt: Use my personal email address

Please ignore this patch. There's been some discussion internally and I'll use my Ampere email address for contributions to {Platform,Silicon}/Ampere. -- Rebecca On 8/21/24 11:27 AM, Michael D Kinney wrote: Reviewed-by: Michael D Kinney -Original Message----- From: Re

[edk2-devel] [PATCH edk2-platforms v2 1/1] Maintainers.txt: Use my personal email address

Work with upstream/community is done on my own time, so update my entry to contain my personal email address. Signed-off-by: Rebecca Cran --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 824838486072..27f4056a6f49

[edk2-devel] [PATCH] Maintainers.txt: Use my personal email address

Work with upstream/community is done on my own time, so update my entry to contain my personal email address. Signed-off-by: Rebecca Cran --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 8248384860..27f4056a6f 100644

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: BKM document to build Python UEFI using Visual Studio Tools

P -Original Message- From: Rebecca Cran Sent: Tuesday, August 20, 2024 9:43 PM To: devel@edk2.groups.io; Jayaprakash, N Cc: Kinney, Michael D Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: BKM document to build Python UEFI using Visual Studio Tools On 8/20/24 9:57 AM, Jayap

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: BKM document to build Python UEFI using Visual Studio Tools

On 8/20/24 9:57 AM, Jayaprakash, N wrote: +c. Run the below command to setup the tool chain environment variables and build the BaseTools: +```cmd + edksetup.bat + edksetup.bat Rebuild VS2022 Should we suggest people use Edk2ToolsBuild.py instead? -- Rebecca -=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the GitHub Pull Request workflow

n use the app that is already available. The main update that is needed is adding secrets to edk2-platforms repo Mike -Original Message- From: Rebecca Cran Sent: Monday, August 19, 2024 3:15 PM To: Kinney, Michael D ; devel@edk2.groups.io; Leif Lindholm ; Kubacki, Michael Subject: Re:

Re: [edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the GitHub Pull Request workflow

required the use of a GitHub App credentials to run the AssignReviewers.yml. See this change for reference: https://github.com/tianocore/edk2/pull/6050 Mike -Original Message- From: Rebecca Cran Sent: Tuesday, August 6, 2024 10:36 AM To: devel@edk2.groups.io; Leif Lindholm ; Kinney

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] JadePkg: Add ACPI SPMI table

On 8/13/2024 9:33 PM, Nhi Pham via groups.io wrote: This could be a static function. +EFI_STATUS +EFIAPI +AcpiInstallSpmiTable ( + VOID + ); + #endif /* ACPI_PLATFORM_H_ */ diff --git a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c b/Platform/Ampere/JadePkg/Drivers/AcpiPl

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] AmpereAltraPkg/FlashFvbDxe: Sync up NVRAM FV with NVRAM cached

Reviewed-by: Rebecca Cran On 8/8/2024 9:12 PM, Nhi Pham wrote: From: Tam Chi Nguyen Currently, the NVRAM FV region is only updated once at FlashPei that makes the data in NVRAM FV outdated with data in NVRAM region in SPI-NOR. It causes the duplication of the valid NV variables when the

[edk2-devel] Please re-open and review https://github.com/tianocore/edk2/pull/5701

I created the PR https://github.com/tianocore/edk2/pull/5701 ("EmbeddedPkg: Improve error handling in LocateAndInstallAcpiFromFvConditional") on May 30th but it was never reviewed. Could someone re-open it and review it for the stable tag please? -- Rebecca -=-=-=-=-=-=-=-=-=-=-=- Groups.

Re: [edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the GitHub Pull Request workflow

, Michael D wrote: I suspect you will run into the same permissions issues that required the use of a GitHub App credentials to run the AssignReviewers.yml. See this change for reference: https://github.com/tianocore/edk2/pull/6050 Mike -Original Message- From: Rebecca Cran Sent

Re: [edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the GitHub Pull Request workflow

Could I get some reviews on this please? -- Rebecca On 8/1/24 3:43 PM, Rebecca Cran wrote: Changes from v2 to v3: Added note to AssignReviewers.yml to say where it was copied from. Sorted platforms in CODEOWNERS and REVIEWERS alphabetically. Sorted entries in CONTRIBUTORS.md by first name

Re: [edk2-devel] Migrating edk2-libc to use GitHub PR review process

On 8/6/2024 3:10 AM, Jayaprakash, N wrote: Hi Rebecca, Mike suggested me to talk to you to see the possibility of getting edk2-libc repo to the GitHub PR review process. It’s a relatively small repo with few contributors. Would like to understand what it takes to migrate to the new process?

Re: [edk2-devel] [tianocore/edk2] Tools and CI Meeting - Date 8/5 (Discussion #6047)

> > Current status of enabling PRs in edk2-platforms > Last week's update: #6001 (comment) > "Sent patch to create CODEOWNERS, REVIEWERS, CONTRIBUTORS and the GitHub workflow script to assign reviewers, currently waiting for people to review it." > @bcran - C

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

On 8/1/24 12:50, Jeremy Linton wrote: On 8/1/24 10:50, Rebecca Cran wrote: On 8/1/24 9:43 AM, Ard Biesheuvel wrote: Haven't noticed this one myself. The only issue I hit once in a while (but only with DEBUG builds as far as I am aware) is an ASSERT() on some XhciDxe control register rea

[edk2-devel] [PATCH edk2-platforms v3 1/1] Move to the GitHub Pull Request workflow

/AssignReviewers.yml which adds reviewers to a Pull Request based on the content of the REVIEWERS file. Signed-off-by: Rebecca Cran --- .github/workflows/AssignReviewers.yml | 31 ++ CODEOWNERS| 146 +++ CONTRIBUTORS.md | 68 +++ Maintainers.txt

[edk2-devel] [PATCH edk2-platforms v3 0/1] Move to the GitHub Pull Request workflow

people own _areas_ of the repo, not specifically packages. Rebecca Cran (1): Move to the GitHub Pull Request workflow .github/workflows/AssignReviewers.yml | 31 ++ CODEOWNERS| 146 +++ CONTRIBUTORS.md | 68 +++ Maintainers.txt

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Switch all platforms to [Peiless]Sec

On 8/1/24 9:43 AM, Ard Biesheuvel wrote: Haven't noticed this one myself. The only issue I hit once in a while (but only with DEBUG builds as far as I am aware) is an ASSERT() on some XhciDxe control register read (or perhaps a timeout?) This might be the XHCI bug where there's missing error h

Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Move to the GitHub Pull Request workflow

On 8/1/24 8:51 AM, Leif Lindholm wrote: On 2024-08-01 13:49, Rebecca Cran wrote: Would you like me to add a note to .github/workflows/AssignReviewers.yml to say that's where it came from? I'd like to see it added *somewhere*. Where it came from and the (short) commit hash at the v

Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Move to the GitHub Pull Request workflow

Replies inline. On 8/1/24 3:45 AM, Leif Lindholm wrote: On Sat, Jul 27, 2024 at 14:31:56 -0600, Rebecca Cran wrote: Migrate data from Maintainers.txt to the GitHub standard CODEOWNERS files plus REVIEWERS and CONTRIBUTORS.md. The latter file contains mappings from name to email address and

Re: [edk2-devel] [PATCH edk2-platforms 1/2] Platform/Beagle: Fix DSC line endings

On 7/31/24 04:42, Ard Biesheuvel wrote: Use CR-LF as required for DSC files. Signed-off-by: Ard Biesheuvel --- Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc b/

[edk2-devel] Unable to build OvmfPkgX64.dsc with VS2022 ("PE image Section-Alignment and File-Alignment do not match")

I guess it might be fairly uncommon, I'm building on a ReFS volume on Windows Server 2022. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120134): https://edk2.groups.io/g/devel/message/120134 Mute This Topic: https:/

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: remove gitmodules file added through accidental commit

Reviewed-by: Rebecca Cran On 7/30/24 10:17 AM, Jayaprakash N wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4822 Due to an accidental commit went into edk2-libc while experimenting with some inner-source repos lead to the addition of gitmodules file and a submodule. This commit

Re: [edk2-devel] [PATCH RFC edk2-platforms 0/5] Phase out MPCore SEC drivers

ote: From: Ard Biesheuvel The original EDK2 port to 32-bit ARM supported multi-core but on today's ARM systems, only a single CPU enters the non-secure firmware and the MPCore drivers are obsolete. Stop using them in edk2-platforms so we can remove them entirely from edk2. Cc: Leif Lindho

Re: [edk2-devel] [PATCH RFC edk2-platforms 0/5] Phase out MPCore SEC drivers

For the series: Reviewed-by: Rebecca Cran I see this is marked as an RFC, but I think it's a change that should be committed. -- Rebecca On 7/29/24 06:22, Ard Biesheuvel wrote: From: Ard Biesheuvel The original EDK2 port to 32-bit ARM supported multi-core but on today's ARM sys

Re: [edk2-devel] [PATCH edk2-platforms v2 0/1] Move to the GitHub Pull Request workflow

I know it's only been a couple of days, but would it be possible to get some reviews on this please? I have a new platform (Platform/Ampere/ComHpcAltPkg) plus fixes to JadePkg that are waiting for the switchover to the PR workflow so I'm eager to get this committed. -- Rebecca C

[edk2-devel] Error building CmockaLib and NetworkPkgHostTest.dsc on AARCH64

-point code. I know in CmockaLib.inf it says "VALID_ARCHITECTURES = IA32 X64" but do we want it to be able to build on other platforms too? -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120066): https://edk2.g

Re: [edk2-devel] Quick Change to Improve edk2 CI Time

n a strong reluctance against using anything that isn't cloud-based. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120057): https://edk2.groups.io/g/devel/message/120057 Mute This Topic: https://groups.io/mt/107567

[edk2-devel] [PATCH edk2-platforms v2 1/1] Move to the GitHub Pull Request workflow

/AssignReviewers.yml which adds reviewers to a Pull Request based on the content of the REVIEWERS file. Signed-off-by: Rebecca Cran --- .github/workflows/AssignReviewers.yml | 28 ++ CODEOWNERS| 146 +++ CONTRIBUTORS.md | 68 +++ Maintainers.txt

[edk2-devel] [PATCH edk2-platforms v2 0/1] Move to the GitHub Pull Request workflow

CONTRIBUTORS.md to delete the second email address. Updated the commit message to indicate that this change is to enable the GitHub PR workflow, not just in preparation for it. Rebecca Cran (1): Move to the GitHub Pull Request workflow .github/workflows/AssignReviewers.yml | 28 ++ CODEOWNERS

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Prepare for move to GitHub Pull Request workflow

On 7/26/24 11:37, Michael D Kinney via groups.io wrote: Members with more than one email address is confusing. Can we limit to single email address for TianoCore activities? Also, should Maintainer.txt be removed yet? There is a GitHub Action active in edk2 now that assigns reviews from Maint

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Prepare for move to GitHub Pull Request workflow

Platform/Intel/TigerlakeOpenBoardPkg and Silicon/Intel/TigerlakeSiliconPkg Tomas Abraham for Platform/ARM Graeme Gregory for {Platform,Silicon}/Qemu/SbsaQemu -- Rebecca Cran On 7/26/24 7:20 AM, Rebecca Cran wrote: Migrate data from Maintainers.txt to the GitHub standard CODEOWNERS files plu

[edk2-devel] [PATCH edk2-platforms 1/1] Prepare for move to GitHub Pull Request workflow

](https://github.com/chuongtranle) | +| Rebecca Cran | rebe...@os.amperecomputing.com | [@rcran-ampere](https://github.com/rcran-ampere) | +|| rebe...@bsdio.com| [@bcran](https://github.com/bcran)| +| Thomas Abraham

Re: [edk2-devel] edk2 Automatic PR Reviewers

On 7/24/24 20:35, Michael Kubacki wrote: A change was just pushed to edk2 to automatically add reviewers to pull request based on those listed in Maintainers.txt. For more details and in case of any issues, I put some information on this wiki page: https://github.com/tianocore/tianocore.gith

[edk2-devel] Proposed new file CONTRIBUTORS.md for edk2-platforms

ewers and their email addresses and github usernames? Then we can eventually delete Maintainers.txt. e.g. | Name | e-mail address | Github username | | Rebecca Cran | rebe...@bsdio.com| @bcran | -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Grou

Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: add .gitattributes to ensure right line endings in .sh .bat

: Rebecca Cran Cc: Michael D Kinney Cc: Jayaprakash N Signed-off-by: Jayaprakash N --- .gitattributes | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 .gitattributes diff --git a/.gitattributes b/.gitattributes new file mode 100644 index 000..3fd9ec8 --- /dev/null +++ b

Re: [edk2-devel] Drop VS2015 Support

On 7/9/24 14:01, Michael D Kinney wrote: What do you mean by drop? Remove from CI or remove from both CI and tools_def.txt? I'm thinking remove it from both. -- Rebecca Cran Mike -Original Message- From: devel@edk2.groups.io On Behalf Of Oliver Smith- Denny Sent: Tuesday,

Re: [edk2-devel] RedfishPlatformConfigDxe needs Depex on gEfiRegularExpressionProtocolGuid?

I'm ok keeping the current behavior as long as the DEBUG_ERROR message is removed or downgraded to DEBUG_INFO. As it is, it makes it look as though the driver has failed when error messages are highlighted during the boot. -- Rebecca Cran On 7/8/24 21:53, Nickle Wang wrote: Shoul

[edk2-devel] RedfishPlatformConfigDxe needs Depex on gEfiRegularExpressionProtocolGuid?

+60,4 @@ gEfiRedfishPkgTokenSpaceGuid.PcdRedfishPlatformConfigDebugProperty [Depex] - TRUE + gEfiRegularExpressionProtocolGuid^M -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119815): https://edk2.groups.io/g/devel/message/119815 Mute This

Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests

On 7/1/24 13:16, Rebecca Cran via groups.io wrote: Now that edk2 has been using PRs for a few weeks, I'd like to propose enabling the same workflow for edk2-platfoms. As maintainers or reviewers of platforms in the edk2-platforms repo, I'd like to get any feedback on moving from e

[edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests

oncerns or issues people might have with it. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119747): https://edk2.groups.io/g/devel/message/119747 Mute This Topic: https://groups.io/mt/106986207/21656 Group Owner: devel+

Re: [edk2-devel] Alignment fault in __memcpy when SbsaQemu is built uncompressed

NumBlocks, offsets etc. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119729): https://edk2.groups.io/g/devel/message/119729 Mute This Topic: https://groups.io/mt/106820121/21656 Group Owner: devel+ow...@edk2.groups.io

Re: [edk2-devel] Topic for Monday Tools, CI, Code Base construction meeting

Add edk2-devel On 6/23/24 11:38 AM, Rebecca Cran wrote: I have two items I'd like to discuss for tomorrow (Monday's) Tools, CI, Code base construction meeting: 1. Enabling the PR process for edk2-platforms and other TianoCore repositories. 2. Status of the BaseTools C

[edk2-devel] Alignment fault in __memcpy when SbsaQemu is built uncompressed

9000200   0010007F41920: 45037614462CAA21 312366F4B68A6E83 01000753D098 ASSERT [ArmCpuDxe] DefaultExceptionHandler.c(343): ((BOOLEAN)(0==1)) -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (

[edk2-devel] Adding AArch64 support to the mu_nasm package (nasm_ext_dep.yaml)

lease? I've looked through mu_basecore and from BaseTools/NugetPublishing/Mu-Basetools.md it looks like it's a manual process? If anyone needs access to an AArch64 system I can provide a remote login to an Ubuntu VM. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links:

[edk2-devel] GitHub PRs and Mergify: " Allow edits from maintainers" needs to be enabled

It looks like we need to require users creating PRs to enable the "Allow edits from maintainers" settin*g?* * * *-- Rebecca Cran * -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119593): https://edk2.groups.io/g/devel/message/1195

  1   2   3   4   5   6   7   8   9   10   >