On 8/13/2024 9:33 PM, Nhi Pham via groups.io wrote: This could be a static function.
+EFI_STATUS +EFIAPI +AcpiInstallSpmiTable ( + VOID + ); + #endif /* ACPI_PLATFORM_H_ */ diff --git a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c index 28c422dff166..a82a93d23fa2 100644 --- a/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c +++ b/Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.c
I believe the project now prefers the use of the C keyword "static".
+ // BCD Format + SpmiTable->SpecificationRevision = DeviceId.SpecificationVersion & 0xF0; + SpmiTable->SpecificationRevision |= (DeviceId.SpecificationVersion & 0x0F) << 8;
It took a second to understand this. Maybe combine it into a single line, or change the '0x0F' to just '0xF'?
-- Rebecca -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120338): https://edk2.groups.io/g/devel/message/120338 Mute This Topic: https://groups.io/mt/107889268/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
