zjffdu commented on a change in pull request #4116:
URL: https://github.com/apache/zeppelin/pull/4116#discussion_r633582560
##
File path:
zeppelin-plugins/launcher/flink/src/main/java/org/apache/zeppelin/interpreter/launcher/FlinkInterpreterLauncher.java
##
@@ -45,25 +48,44 @@
zjffdu commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-842418305
It looks like cause spark/flink tests fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
zjffdu commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-842418305
It looks like cause spark/flink tests fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Reamer commented on pull request #4117:
URL: https://github.com/apache/zeppelin/pull/4117#issuecomment-842040976
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For q
PrarthiJain commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-842189288
@Reamer @zjffdu @prabhjyotsingh. I have uploaded a new patch with thrift
dependency addition. We can remove that later on the 4.0 version upgrade. Let
me know your thoughts
xiejiajun commented on pull request #4119:
URL: https://github.com/apache/zeppelin/pull/4119#issuecomment-842091804
> > The close method of LdapCtx will call the close method of LdapClient to
return the connection to the connection pool. If we rely on the GC mechanism,
although the Context
zjffdu edited a comment on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-842054131
@Reamer Actually `YarnRemoteInterpreterProcess` doesn't do the downloading,
it just upload the conda to hdfs as yarn app resource, and yarn will download
it from hdfs bef
Reamer commented on a change in pull request #4116:
URL: https://github.com/apache/zeppelin/pull/4116#discussion_r633466544
##
File path: flink/interpreter/pom.xml
##
@@ -95,6 +96,13 @@
${project.version}
+
+ io.fabric8
+ kubernetes-client
+ ${
zjffdu commented on a change in pull request #4116:
URL: https://github.com/apache/zeppelin/pull/4116#discussion_r633565472
##
File path: flink/interpreter/pom.xml
##
@@ -95,6 +96,13 @@
${project.version}
+
+ io.fabric8
+ kubernetes-client
+ ${
xiejiajun closed pull request #4119:
URL: https://github.com/apache/zeppelin/pull/4119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, ple
cuspymd commented on pull request #4119:
URL: https://github.com/apache/zeppelin/pull/4119#issuecomment-841980605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For querie
cuspymd commented on a change in pull request #4116:
URL: https://github.com/apache/zeppelin/pull/4116#discussion_r633402731
##
File path:
zeppelin-plugins/launcher/flink/src/main/java/org/apache/zeppelin/interpreter/launcher/FlinkInterpreterLauncher.java
##
@@ -45,25 +48,44 @
zjffdu commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-842054131
@Reamer Actually `YarnRemoteInterpreterProcess` doesn't do the downloading,
it just upload the conda to hdfs as yarn app resource, and yarn will download
it from hdfs before sta
zjffdu commented on pull request #4117:
URL: https://github.com/apache/zeppelin/pull/4117#issuecomment-842029559
Will merge if no more comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #4117:
URL: https://github.com/apache/zeppelin/pull/4117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
zjffdu commented on pull request #4104:
URL: https://github.com/apache/zeppelin/pull/4104#issuecomment-842768798
@cuspymd Any more comment ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
Reamer commented on a change in pull request #4118:
URL: https://github.com/apache/zeppelin/pull/4118#discussion_r634058596
##
File path: zeppelin-plugins/pom.xml
##
@@ -25,10 +25,8 @@
zeppelin
org.apache.zeppelin
0.10.0-SNAPSHOT
-..
Review c
Reamer commented on a change in pull request #4116:
URL: https://github.com/apache/zeppelin/pull/4116#discussion_r634075607
##
File path:
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java
##
@@ -142,6 +141,7 @@
private Sc
Reamer commented on a change in pull request #4116:
URL: https://github.com/apache/zeppelin/pull/4116#discussion_r634085242
##
File path: flink/interpreter/pom.xml
##
@@ -95,6 +96,13 @@
${project.version}
+
+ io.fabric8
+ kubernetes-client
+ ${
zjffdu commented on a change in pull request #4116:
URL: https://github.com/apache/zeppelin/pull/4116#discussion_r634151978
##
File path:
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java
##
@@ -142,6 +141,7 @@
private Sc
cuspymd commented on a change in pull request #4120:
URL: https://github.com/apache/zeppelin/pull/4120#discussion_r634442983
##
File path:
flink/interpreter/src/main/java/org/apache/zeppelin/flink/JobManager.java
##
@@ -254,11 +255,12 @@ public void run() {
if (
cuspymd commented on a change in pull request #4116:
URL: https://github.com/apache/zeppelin/pull/4116#discussion_r634453738
##
File path:
flink/interpreter/src/main/scala/org/apache/zeppelin/flink/FlinkScalaInterpreter.scala
##
@@ -182,16 +182,27 @@ class FlinkScalaInterprete
Reamer commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-843240046
Hi @zjffdu,
> We can leverage yarn's resource cache mechanism. That means the same conda
env downloaded by yarn_app_1 can be reused by yarn_app_2. If we download it in
Ju
Reamer edited a comment on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-843240046
Hi @zjffdu,
> We can leverage yarn's resource cache mechanism. That means the same conda
env downloaded by yarn_app_1 can be reused by yarn_app_2. If we download it
cuspymd commented on a change in pull request #4118:
URL: https://github.com/apache/zeppelin/pull/4118#discussion_r634479834
##
File path: zeppelin-plugins/pom.xml
##
@@ -25,10 +25,8 @@
zeppelin
org.apache.zeppelin
0.10.0-SNAPSHOT
-..
Review
cuspymd commented on a change in pull request #4118:
URL: https://github.com/apache/zeppelin/pull/4118#discussion_r634479834
##
File path: zeppelin-plugins/pom.xml
##
@@ -25,10 +25,8 @@
zeppelin
org.apache.zeppelin
0.10.0-SNAPSHOT
-..
Review
cuspymd commented on a change in pull request #4118:
URL: https://github.com/apache/zeppelin/pull/4118#discussion_r634501953
##
File path: zeppelin-plugins/pom.xml
##
@@ -25,10 +25,8 @@
zeppelin
org.apache.zeppelin
0.10.0-SNAPSHOT
-..
cuspymd commented on a change in pull request #4118:
URL: https://github.com/apache/zeppelin/pull/4118#discussion_r634501953
##
File path: zeppelin-plugins/pom.xml
##
@@ -25,10 +25,8 @@
zeppelin
org.apache.zeppelin
0.10.0-SNAPSHOT
-..
zjffdu commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-843283503
> I was aware of this, but it seems that downloading dependencies several
times is the way of `spark.archives`. It is clear that this is not optimal.
If I read spark c
cuspymd opened a new pull request #4121:
URL: https://github.com/apache/zeppelin/pull/4121
### What is this PR for?
Polish server and service package codes of zeppelin-server
- Delete unused import
- Delete and optimize redundant codes
- Add `final` keyword to some variables that
zjffdu commented on a change in pull request #4121:
URL: https://github.com/apache/zeppelin/pull/4121#discussion_r634876091
##
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/service/NoAuthenticationService.java
##
@@ -30,7 +30,7 @@
import org.slf4j.LoggerFactory
zjffdu commented on a change in pull request #4121:
URL: https://github.com/apache/zeppelin/pull/4121#discussion_r634876522
##
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/service/ShiroAuthenticationService.java
##
@@ -407,8 +407,8 @@ public boolean isAuthentic
zjffdu commented on a change in pull request #4120:
URL: https://github.com/apache/zeppelin/pull/4120#discussion_r634877594
##
File path:
flink/interpreter/src/main/java/org/apache/zeppelin/flink/JobManager.java
##
@@ -254,11 +255,12 @@ public void run() {
if (c
Reamer commented on a change in pull request #4118:
URL: https://github.com/apache/zeppelin/pull/4118#discussion_r634925921
##
File path: zeppelin-plugins/pom.xml
##
@@ -25,10 +25,8 @@
zeppelin
org.apache.zeppelin
0.10.0-SNAPSHOT
-..
Review c
Reamer commented on a change in pull request #4118:
URL: https://github.com/apache/zeppelin/pull/4118#discussion_r634938512
##
File path: zeppelin-plugins/pom.xml
##
@@ -25,10 +25,8 @@
zeppelin
org.apache.zeppelin
0.10.0-SNAPSHOT
-..
-
Reamer commented on a change in pull request #4118:
URL: https://github.com/apache/zeppelin/pull/4118#discussion_r634951058
##
File path: zeppelin-plugins/pom.xml
##
@@ -25,10 +25,8 @@
zeppelin
org.apache.zeppelin
0.10.0-SNAPSHOT
-..
-
cuspymd commented on a change in pull request #4121:
URL: https://github.com/apache/zeppelin/pull/4121#discussion_r635277266
##
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/service/NoAuthenticationService.java
##
@@ -30,7 +30,7 @@
import org.slf4j.LoggerFactor
cuspymd commented on a change in pull request #4121:
URL: https://github.com/apache/zeppelin/pull/4121#discussion_r635299987
##
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/service/ShiroAuthenticationService.java
##
@@ -407,8 +407,8 @@ public boolean isAuthenti
zjffdu commented on a change in pull request #4121:
URL: https://github.com/apache/zeppelin/pull/4121#discussion_r635330507
##
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/service/NoAuthenticationService.java
##
@@ -30,7 +30,7 @@
import org.slf4j.LoggerFactory
zjffdu commented on a change in pull request #4121:
URL: https://github.com/apache/zeppelin/pull/4121#discussion_r635330507
##
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/service/NoAuthenticationService.java
##
@@ -30,7 +30,7 @@
import org.slf4j.LoggerFactory
mnmhouse closed pull request #4115:
URL: https://github.com/apache/zeppelin/pull/4115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
mnmhouse opened a new pull request #4122:
URL: https://github.com/apache/zeppelin/pull/4122
### What is this PR for?
when download distirbution package , run zeppelin server ,do not config
zeppelin-site.xml ,i found LIST_CONFIGURATIONS command cannot return the
default configur
cuspymd commented on a change in pull request #4122:
URL: https://github.com/apache/zeppelin/pull/4122#discussion_r635757279
##
File path:
zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
##
@@ -871,6 +871,10 @@ public boolean isPrometheus
Reamer opened a new pull request #4123:
URL: https://github.com/apache/zeppelin/pull/4123
### What is this PR for?
This PR correct a comment in ZeppelinConfiguration.java
### What type of PR is it?
- Documentation
### What is the Jira issue?
* https://issues.apach
Reamer commented on a change in pull request #4122:
URL: https://github.com/apache/zeppelin/pull/4122#discussion_r635814385
##
File path:
zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
##
@@ -871,6 +871,10 @@ public boolean isPrometheusM
Reamer commented on a change in pull request #4122:
URL: https://github.com/apache/zeppelin/pull/4122#discussion_r635821821
##
File path:
zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
##
@@ -871,6 +871,10 @@ public boolean isPrometheusM
Reamer commented on a change in pull request #4121:
URL: https://github.com/apache/zeppelin/pull/4121#discussion_r635848055
##
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/service/JobManagerService.java
##
@@ -65,9 +65,10 @@ public JobManagerService(Notebook no
mnmhouse commented on a change in pull request #4122:
URL: https://github.com/apache/zeppelin/pull/4122#discussion_r635916805
##
File path:
zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
##
@@ -871,6 +871,10 @@ public boolean isPrometheu
asfgit closed pull request #4123:
URL: https://github.com/apache/zeppelin/pull/4123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
cuspymd commented on a change in pull request #4121:
URL: https://github.com/apache/zeppelin/pull/4121#discussion_r636196272
##
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/service/NoAuthenticationService.java
##
@@ -30,7 +30,7 @@
import org.slf4j.LoggerFactor
cuspymd commented on a change in pull request #4118:
URL: https://github.com/apache/zeppelin/pull/4118#discussion_r636204724
##
File path: zeppelin-plugins/pom.xml
##
@@ -25,10 +25,8 @@
zeppelin
org.apache.zeppelin
0.10.0-SNAPSHOT
-..
Reamer commented on pull request #4118:
URL: https://github.com/apache/zeppelin/pull/4118#issuecomment-845220748
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For q
zjffdu opened a new pull request #4124:
URL: https://github.com/apache/zeppelin/pull/4124
### What is this PR for?
This PR add scripts folder in the binary distribution, so that user can
build images via these scripts
### What type of PR is it?
[ Improvement ]
### To
Reamer commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-845683022
Thank you for the clarification. I have created a [Jira
ticket](https://issues.apache.org/jira/browse/ZEPPELIN-5384).
--
This is an automated message from the Apache Git Servi
Reamer commented on a change in pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#discussion_r636668467
##
File path:
zeppelin-jupyter-interpreter/src/main/java/org/apache/zeppelin/jupyter/JupyterKernelInterpreter.java
##
@@ -183,8 +195,43 @@ public String
cuspymd opened a new pull request #4125:
URL: https://github.com/apache/zeppelin/pull/4125
### What is this PR for?
- Add `final` keyword to variables which are not re-assigned
- Delete unnecessary and unused codes
### What type of PR is it?
[Refactoring]
### What
PrarthiJain commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-848525337
@Reamer @zjffdu @prabhjyotsingh, The build failed with `Could not resolve
dependencies for...from/to maven-default-http-blocker (http://0.0.0.0/):
Blocked mirror for reposi
zjffdu commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-848528028
@PrarthiJain I also notice that today, I am looking into this issue, will
keep you updated
--
This is an automated message from the Apache Git Service.
To respond to the mess
zjffdu commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-849325647
@PrarthiJain I made a hotfix for the CI, please rebase your PR and trigger
the CI again.
--
This is an automated message from the Apache Git Service.
To respond to the messa
zjffdu commented on pull request #4125:
URL: https://github.com/apache/zeppelin/pull/4125#issuecomment-849326766
LGTM, thanks @cuspymd I made a hotfix for the flink CI failure, could you
rebase your PR and trigger the CI again ?
--
This is an automated message from the Apache Git Servic
zjffdu commented on pull request #4120:
URL: https://github.com/apache/zeppelin/pull/4120#issuecomment-849326934
Will merge if no more comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
zjffdu commented on pull request #4113:
URL: https://github.com/apache/zeppelin/pull/4113#issuecomment-849327181
Will merge if no more comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
zjffdu commented on pull request #4104:
URL: https://github.com/apache/zeppelin/pull/4104#issuecomment-849327345
Will merge if no more comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
NicolasGong closed pull request #4110:
URL: https://github.com/apache/zeppelin/pull/4110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
PrarthiJain commented on pull request #4089:
URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-849673788
Thanks @zjffdu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
cuspymd commented on pull request #4125:
URL: https://github.com/apache/zeppelin/pull/4125#issuecomment-849701071
> LGTM, thanks @cuspymd I made a hotfix for the flink CI failure, could you
rebase your PR and trigger the CI again ?
I have rebased latest commit and triggered the CI.
cuspymd opened a new pull request #4126:
URL: https://github.com/apache/zeppelin/pull/4126
### What is this PR for?
- Add final keyword to variables which are not re-assigned
- Delete unnecessary and unused codes
### What type of PR is it?
[Refactoring]
### What is
Reamer commented on pull request #4113:
URL: https://github.com/apache/zeppelin/pull/4113#issuecomment-850299078
Does it make a difference in your environment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
Reamer commented on pull request #4125:
URL: https://github.com/apache/zeppelin/pull/4125#issuecomment-850415778
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For q
nilroy opened a new pull request #4127:
URL: https://github.com/apache/zeppelin/pull/4127
### What is this PR for?
To be able to parse SPARK_SUBMIT_OPTIONS which has whitespace in between
like
```
export SPARK_SUBMIT_OPTIONS="$SPARK_SUBMIT_OPTIONS --conf
'spark.driver.extraJa
zjffdu opened a new pull request #4128:
URL: https://github.com/apache/zeppelin/pull/4128
### What is this PR for?
This is to support scala 2.12 of flink interpreter. Here's the main changes:
1. Copy `FlinkILoop`, `FlinkShell`, `ScalaShellEnvironment`,
`ScalaShellStreamEnviron
chillinger commented on pull request #4113:
URL: https://github.com/apache/zeppelin/pull/4113#issuecomment-851379000
@zjffdu based on your MR we built the zeppelin-server jar for our
environment and will test it - I will share the results as soon as we have
solid feedback.
One quest
zjffdu commented on pull request #4113:
URL: https://github.com/apache/zeppelin/pull/4113#issuecomment-851397091
Thank @chillinger for the help. Regarding `synchronized`, it is done in
https://issues.apache.org/jira/browse/ZEPPELIN-1480.
--
This is an automated message from the Apac
Reamer commented on pull request #4128:
URL: https://github.com/apache/zeppelin/pull/4128#issuecomment-851512360
I don't like the symlinks and the Maven build helper steps because this
construct breaks some IDEs. Is it not possible to create only one submodule
with two Scala compiler profi
Reamer edited a comment on pull request #4128:
URL: https://github.com/apache/zeppelin/pull/4128#issuecomment-851512360
I don't like the symlinks and the Maven build helper steps because this
construct breaks some IDEs. Is it not possible to create only one submodule
with two Scala compile
Reamer commented on pull request #4118:
URL: https://github.com/apache/zeppelin/pull/4118#issuecomment-851513784
@cuspymd Please rebase to current master to fix CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
asfgit closed pull request #4104:
URL: https://github.com/apache/zeppelin/pull/4104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
zjffdu commented on pull request #4128:
URL: https://github.com/apache/zeppelin/pull/4128#issuecomment-851755290
@Reamer Using profiles won't work here, because our goal is to make one
zeppelin instance to work with multiple scala version. Building different
zeppelin distribution for each
asfgit closed pull request #4124:
URL: https://github.com/apache/zeppelin/pull/4124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
jongyoul commented on pull request #4126:
URL: https://github.com/apache/zeppelin/pull/4126#issuecomment-851985261
Who can verify if some test failures are flaky or not? I've checked the
changes and LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the mess
cuspymd commented on pull request #4118:
URL: https://github.com/apache/zeppelin/pull/4118#issuecomment-852172380
> @cuspymd Please rebase to current master to fix CI.
I have done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
zjffdu commented on a change in pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#discussion_r643680742
##
File path:
zeppelin-plugins/launcher/yarn/src/main/java/org/apache/zeppelin/interpreter/launcher/YarnRemoteInterpreterProcess.java
##
@@ -316,6 +347,2
zjffdu commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-852767277
CI is failed, I am looking at that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
zjffdu commented on pull request #4126:
URL: https://github.com/apache/zeppelin/pull/4126#issuecomment-852848147
@Reamer It looks like the K8s UT fails again
```
PodPhaseWatcherTest.testPhase:69 null
```
--
This is an automated message from the Apache Git Service.
To respond to t
zjffdu commented on pull request #4126:
URL: https://github.com/apache/zeppelin/pull/4126#issuecomment-852848359
@Reamer It looks like the K8s UT fails again
```
PodPhaseWatcherTest.testPhase:69 null
```
https://github.com/apache/zeppelin/pull/4126/checks?check_run_id=2686162242
asfgit closed pull request #4125:
URL: https://github.com/apache/zeppelin/pull/4125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
cuspymd commented on a change in pull request #4128:
URL: https://github.com/apache/zeppelin/pull/4128#discussion_r644049588
##
File path:
flink/flink-scala-parent/src/main/java/org/apache/zeppelin/flink/FlinkInterpreter.java
##
@@ -25,45 +26,74 @@
import org.apache.zeppelin.
Reamer commented on pull request #4128:
URL: https://github.com/apache/zeppelin/pull/4128#issuecomment-853111506
> Regarding the code structure in IDE, I do have some tips to make it work
in intellij, let me add one contribution doc to clarify that
That would be great. Thank you
--
zjffdu commented on pull request #4126:
URL: https://github.com/apache/zeppelin/pull/4126#issuecomment-853119076
@Reamer It looks like the K8s UT fails again
```
PodPhaseWatcherTest.testPhase:69 null
```
https://github.com/apache/zeppelin/pull/4126/checks?check_run_id=2686162242
Reamer commented on pull request #4126:
URL: https://github.com/apache/zeppelin/pull/4126#issuecomment-853144470
> @Reamer It looks like the K8s UT fails again
>
> ```
> PodPhaseWatcherTest.testPhase:69 null
> ```
>
> https://github.com/apache/zeppelin/pull/4126/checks?ch
zjffdu closed pull request #4120:
URL: https://github.com/apache/zeppelin/pull/4120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
zjffdu commented on pull request #4122:
URL: https://github.com/apache/zeppelin/pull/4122#issuecomment-853596439
LGTM, will merge if no more comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
zjffdu commented on pull request #4128:
URL: https://github.com/apache/zeppelin/pull/4128#issuecomment-853621487
@Reamer `README` is added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
Reamer opened a new pull request #4129:
URL: https://github.com/apache/zeppelin/pull/4129
### What is this PR for?
This PR polish the K8s launcher and tries to fix the flapping UT test
### What type of PR is it?
- Refactoring
### What is the Jira issue?
* https://issu
Reamer commented on pull request #4126:
URL: https://github.com/apache/zeppelin/pull/4126#issuecomment-853938757
@zjffdu I have created PR #4129. Hopefully this will fix the flapping test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Reamer commented on pull request #4127:
URL: https://github.com/apache/zeppelin/pull/4127#issuecomment-853941348
I think an empty delimiter is wrong, possibly something like "--conf" would
be better.
--
This is an automated message from the Apache Git Service.
To respond to the message,
zjffdu commented on pull request #4129:
URL: https://github.com/apache/zeppelin/pull/4129#issuecomment-854371460
Thanks @Reamer It is better to run the tests several times to make sure the
flaky test is fixed.
--
This is an automated message from the Apache Git Service.
To respond to th
zjffdu commented on pull request #4128:
URL: https://github.com/apache/zeppelin/pull/4128#issuecomment-854371551
Will merge if no more comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #4122:
URL: https://github.com/apache/zeppelin/pull/4122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
zjffdu commented on pull request #4097:
URL: https://github.com/apache/zeppelin/pull/4097#issuecomment-854380073
CI is fixed now, ready for review @Reamer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
301 - 400 of 8406 matches
Mail list logo
