[GitHub] [zeppelin] mnmhouse commented on a change in pull request #4122: [ZEPPELIN-5379] LIST_CONFIGURATIONS command cannot return the default…

[GitBox]

mnmhouse commented on a change in pull request #4122:
URL: https://github.com/apache/zeppelin/pull/4122#discussion_r635916805



##########
File path: 
zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
##########
@@ -871,6 +871,10 @@ public boolean isPrometheusMetricEnabled() {
         completeConfiguration.put(c.getVarName(), 
sysConfig.getString(c.getVarName()));
       } else if (envConfig.containsKey(c.name())) {
         completeConfiguration.put(c.getVarName(), 
envConfig.getString(c.name()));
+      }else {
+        if (getString(c)!=null){
+          completeConfiguration.put(c.getVarName(),getString(c));
+        }

Review comment:
       @cuspymd   You look  very carefully，i did not notice  the getString() 
method  
   @Reamer  thank you ,I will modify according to the code  you provided 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org