Reamer commented on a change in pull request #4116:
URL: https://github.com/apache/zeppelin/pull/4116#discussion_r634075607
##########
File path:
zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java
##########
@@ -142,6 +141,7 @@
private ScheduledExecutorService resultCleanService =
Executors.newSingleThreadScheduledExecutor();
private boolean isTest;
+ private boolean isFlinkK8sApplicationMode = false;
Review comment:
I agree with @cuspymd, changing `RemoteInterpreterServer` for a specific
interpreter is not good.
In general, calling `System.exit()` is not good style, so we should wait for
#4089 and help @PrarthiJain if necessary. This PR removes a `System.exit(0)`.
Maybe we are also able to remove the second
[`System.exit(1)`](https://github.com/apache/zeppelin/blob/97ce203a7fb72fd0300ff84ea5fa8e52f6125ebc/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterServer.java#L705)
If we cannot remove the `System.exit()`, then we should work with an
interpreter-independent variable that should be set via the start command or
evaluated at start-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
