Reamer commented on a change in pull request #4118:
URL: https://github.com/apache/zeppelin/pull/4118#discussion_r634058596
##########
File path: zeppelin-plugins/pom.xml
##########
@@ -25,10 +25,8 @@
<artifactId>zeppelin</artifactId>
<groupId>org.apache.zeppelin</groupId>
<version>0.10.0-SNAPSHOT</version>
- <relativePath>..</relativePath>
Review comment:
I think `relativePath` should still be used at this point, but it should
point to the pom.xml.
```
<relativePath>../pom.xml</relativePath>
```
I know that the parent directory is the default and can be omitted, but
sometimes you don't run Maven over the whole project, like in our
[tests](https://github.com/apache/zeppelin/blob/97ce203a7fb72fd0300ff84ea5fa8e52f6125ebc/.github/workflows/core.yml#L67),
then we should reference the parent project with a relative path.
> However, that would work if the parent project was already installed in
our local repository or was in that specific directory structure (parent
pom.xml is one directory higher than that of the module's pom.xml).
https://maven.apache.org/guides/introduction/introduction-to-the-pom.html#Project_Inheritance
##########
File path: zeppelin-plugins/pom.xml
##########
@@ -25,10 +25,8 @@
<artifactId>zeppelin</artifactId>
<groupId>org.apache.zeppelin</groupId>
<version>0.10.0-SNAPSHOT</version>
- <relativePath>..</relativePath>
</parent>
- <groupId>org.apache.zeppelin</groupId>
Review comment:
When you clean up the pom files, you should also delete the versions.
>Alternatively, if you want the groupId or the version of your modules to be
the same as their parents, you can remove the groupId or the version identity
of your module in its POM.
https://maven.apache.org/guides/introduction/introduction-to-the-pom.html#Project_Inheritance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
