Reamer commented on a change in pull request #4116:
URL: https://github.com/apache/zeppelin/pull/4116#discussion_r634085242



##########
File path: flink/interpreter/pom.xml
##########
@@ -95,6 +96,13 @@
       <version>${project.version}</version>
     </dependency>
 
+    <dependency>
+      <groupId>io.fabric8</groupId>
+      <artifactId>kubernetes-client</artifactId>
+      <version>${kubernetes.client.version}</version>
+      <scope>compile</scope>

Review comment:
       I also have the requirement to add additional ingress k8s resources 
during the runtime of the zeppelin interpreter. See 
[ZEPPELIN-5145](https://issues.apache.org/jira/browse/ZEPPELIN-5145).
   
   In my opinion, the interpreter pod should **not** have the right to create 
ingress resources, but the Zeppelin server service user should have the right.
   
   So my plan is to add an additional interface to the Zeppelin interpreter 
project. Something like `ExternalURLSupported`.
   This interface should be implemented by the `InterpreterProcess` e.g. 
`K8sRemoteInterpreterProcess.java` on the ZeppelinServer side and any specific 
interpreter can query the function via `instanceof`.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to