[GitHub] [zeppelin] Reamer commented on a change in pull request #4122: [ZEPPELIN-5379] LIST_CONFIGURATIONS command cannot return the default…

[GitBox]

Reamer commented on a change in pull request #4122:
URL: https://github.com/apache/zeppelin/pull/4122#discussion_r635814385



##########
File path: 
zeppelin-interpreter/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java
##########
@@ -871,6 +871,10 @@ public boolean isPrometheusMetricEnabled() {
         completeConfiguration.put(c.getVarName(), 
sysConfig.getString(c.getVarName()));
       } else if (envConfig.containsKey(c.name())) {
         completeConfiguration.put(c.getVarName(), 
envConfig.getString(c.name()));
+      }else {
+        if (getString(c)!=null){
+          completeConfiguration.put(c.getVarName(),getString(c));
+        }

Review comment:
       @cuspymd You can find the order in the [current 
docs](https://github.com/apache/zeppelin/blob/master/docs/setup/operation/configuration.md).
   Comment by @zjffdu: 
https://github.com/apache/zeppelin/pull/4028#discussion_r560194922
   
   I noticed a small typo. PR #4123 should fix this.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org