cuspymd commented on a change in pull request #4121:
URL: https://github.com/apache/zeppelin/pull/4121#discussion_r635277266
##########
File path:
zeppelin-server/src/main/java/org/apache/zeppelin/service/NoAuthenticationService.java
##########
@@ -30,7 +30,7 @@
import org.slf4j.LoggerFactory;
public class NoAuthenticationService implements AuthenticationService {
- private static Logger logger =
LoggerFactory.getLogger(NoAuthenticationService.class);
+ private static final Logger logger =
LoggerFactory.getLogger(NoAuthenticationService.class);
Review comment:
In the example in the [Constant
names](https://google.github.io/styleguide/javaguide.html#s5.2.4-constant-names)
section of the Google java style document, it says that `Logger` is not a
constant. Could you check it out again?
> // Not constants
...
static final Logger logger = Logger.getLogger(MyClass.getName());
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
