cuspymd commented on a change in pull request #4121: URL: https://github.com/apache/zeppelin/pull/4121#discussion_r635299987
########## File path: zeppelin-server/src/main/java/org/apache/zeppelin/service/ShiroAuthenticationService.java ########## @@ -407,8 +407,8 @@ public boolean isAuthenticated() { Connection con = null; PreparedStatement ps = null; ResultSet rs = null; - DataSource dataSource = null; - String authQuery = ""; + DataSource dataSource; + String authQuery; Review comment: In the case of `con`, `ps`, and `rs` variables, they are used in the `finally` block, so if not initialized, a compilation error occurs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org