got so far as to hit the PORT_DUMP command which is currently not
implemented.
Signed-off-by: Nithin Raju
Tested-by: Nithin Raju
Reported-at: https://github.com/openvswitch/ovs-issues/issues/38
Acked-by: Samuel Ghinet
---
datapath-windows/ovsext/Datapath.c | 150 +++
The Windows kernel datapath needs the definition of 'IFNAMSIZ' for
specifying attribute sizes in netlink policies. Adding the definition
of 'IFNAMSIZ' to be part of OvsDpInterface.h similar to ETH_ADDR_LEN.
Signed-off-by: Nithin Raju
Acked-by: Samuel Ghinet
---
build-aux
cases and error coditions similar to Linux. Some of it is not
applicable yet. Eg. the Windows kernel does not embed an error
in the netlink message itself. There's userspace code nevertheless
for this.
Signed-off-by: Nithin Raju
Acked-by: Samuel Ghinet
Acked-by: Eitan Eliahu
---
lib/ne
In the flow related functions, there's a stack variable called
'linux_flow'. Since this code is not specific to Linux anymore,
in this patch, we rename the variable to 'datpath_flow'.
Signed-off-by: Nithin Raju
---
lib/dpif-netlink.c | 32
hi Folks,
Following are my findings (not many) from looking at netdev and how to go about
implementing it for Windows. I'm posting this as followup to the discussion we
had during IRC meeting. Pls. feel free to comment.
For reference, I looked at the code in the VMware repo (prior to opensourcin
hi Samuel,
Thanks for the re-spin. I'm afraid, there'll have to be another iteration. I
see a refCounting issue when origNbl->FirstNetBuffer->Next != NULL. I have
noted that down in the code.
Other comments are very minor.
Thanks again for working on this. I'll be on IRC if you want to chat.
t
we hold a field in vport,
> "isExternal"
>
> Signed-off-by: Samuel Ghinet
Acked-by: Nithin Raju
Thanks,
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju
> Sent: Tuesday, September 23, 2014 1:58 PM
> To: Samuel Ghinet
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH v2] datapath-windows: fix OVS_VPORT_TYPE
>
> On
> -Original Message-
> From: Samuel Ghinet [mailto:sghi...@cloudbasesolutions.com]
> Sent: Wednesday, September 24, 2014 7:01 AM
> To: dev@openvswitch.org
> Cc: Alin Serdean; Nithin Raju; Saurabh Shah; Eitan Eliahu; Ankur Sharma;
> Kaushik Guha
> Subject: [PATCH
ding Datapath.h in Netlink.c/h gives compilation error.
>
> b. OVS_MESSAGE defines netlink messages hence moving it to
> Netlink.h looked fine to me.
>
> Signed-off-by: Ankur Sharma
> Acked-by: Alin Gabriel Serdean
> Acked-b
> + UINT8 genlCmd, UINT8 genlVer, UINT32 dpNo)
We don't need msgOut and nlBuf both as parameters. One of them will suffice.
You can declare a local variable msgOut = NlBufAt(nlBuf, 0, sizeof *msgOut);
LG otherwise.
Acked-by: Nithin Raju
-- Nithin
___
tan Eliahu
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Sep 24, 2014, at 11:57 PM, Ankur Sharma wrote:
> Signed-off-by: Ankur Sharma
> Acked-by: Alin Gabriel Serdean
> Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
gt; Acked-by: Alin Gabriel Serdean
> Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
thing is, I'd add a command saying some of the actions/key fields
related to recirc and MPLS are not supported yet.
Acked-by: Nithin Raju
Thanks,
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
erdean
> Acked-by: Eitan Eliahu
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
_FLOW_CMD_SET,
> + .handler = OvsFlowNlNewCmdHandler,
> + .supportedDevOp = OVS_TRANSACTION_DEV_OP,
> + .validateDpIndex = FALSE
> }
> };
validateDpIndex should be TRUE for both the commands. But, LG otherwise.
Acked-by: Nithin Raju
-- Nithin
__
On Sep 24, 2014, at 11:58 PM, Ankur Sharma wrote:
> Registered FLOW_DEL command handler. The same command
> handler as FLOW_ADD is good enough to handle FLOW_DEL
> case as well with minor changes for checking to action
> attribute.
>
> Signed-off-by: Ankur Sharma
> Acked-by: Alin Gabriel Serde
On Sep 24, 2014, at 11:58 PM, Ankur Sharma wrote:
> Added changes to handle DEL_FLOWS (FLUSH) scenario.
>
> Signed-off-by: Ankur Sharma
> Acked-by: Alin Gabriel Serdean
> Acked-by: Eitan Eliahu
LG. Thanks for the feature.
Acked-by: Nithin Raju
Th
> LG. Maybe we should call the function as OvsFlowNlCmdHandler, and get rid of
> the 'New'.
>
> .validateDpindex should be TRUE.
Acked-by: Nithin Raju
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
hi Samuel,
I had some minor comments. Looks good otherwise.
Acked-by: Nithin Raju
On Sep 24, 2014, at 8:42 AM, Samuel Ghinet
wrote:
> The transactional get vport command.
> This command uses the netlink transactional errors.
>
> Signed-off-by: Samuel Ghinet
> ---
> datap
hi Sam,
Thanks for incorporating the comments in the latest patch.
On Sep 25, 2014, at 2:44 PM, Samuel Ghinet
wrote:
>> All of the vport commands are implemented in Vport.c. Pls. move this to that
>> file. Perhaps even the Vport dump. You can move all of them at once in a
>> subsequent commit
While calculating the hash on a VPORT name, we don't include the NUL character.
We should be doing the same while doing lookup as well.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/datapath-wi
On Sep 24, 2014, at 11:18 PM, Alin Serdean
wrote:
> The following script leverage's the advantages of WMI infrastructure
> offered in Hyper-V.
>
> This scripts allows the user to change the
> Msvm_EthernetPortAllocationSettingData property of a VM network adapter
> connected to a Hyper-V Virtu
Eitan,
I get the following error when I try to apply this patch. Looks like there's a
new line in build-aux/extract-odp-netlink-windows-dp-h.
---
[nithin@pa-dbc1122 openvswitch-review]$ git am <
../tmp/ovs-dev-v3-datapath-windows-Event-read-handler.patch
Applying: datapath-windows Event read han
.
> An entry for the handler will be added once the Control family (logically
> should have been added to the Vport family)
> implementation checked in.
> User mode code for setting the socket type will follow
>
> Signed-off-by: Eitan
issed packet.
>
>Signed-off-by: Sorin Vinturis
>Reported-by: Nithin Raju
>Reported-at:
> https://urldefense.proofpoint.com/v1/url?u=https://github.com/openvswitch/ovs-issues/issues/32&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=ubrOpIWavCMqX4l4j1LEVpTfDj%2FD5Qyn8KCoJI
While calculating the hash on a VPORT name, we don't include the NUL character.
We should be doing the same while doing lookup as well.
We set the required minimum length of the name to be 2 so that the string has
at least one valid character.
Signed-off-by: Nithin Raju
Acked-by: Eitan E
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/datapath-windows/ovsext/Datapath.c
b/datapath-windows/ovsext/Datapath.c
index b6dc55e..8f8499b 100644
--- a/datapath-windows/ovsext/Datapath.c
+++ b
Thanks Alin. I tested this script and it works!
It would be great if we can document the usage in INSTALL.Windows - both for
one vNIC case and 2 vNIC case. It does not have to be part of this checkin.
Tested-by: Nithin Raju
Acked-by: Nithin Raju
-- Nithin
On Sep 26, 2014, at 6:20 AM, Alin
On Sep 27, 2014, at 4:18 AM, Alin Serdean
wrote:
> Hello Nithin,
>
> I will update the documentation as soon as I can. Also I need to add the
> visualddk flag explanation.
>
> Thanks,
> Alin.
Thanks Alin.
One more thing is that I had to change my PowerShell security settings to
"Unrestri
On Sep 29, 2014, at 10:13 AM, Ankur Sharma
wrote:
> Recently we changed the signature of NlAttrParse.
> Function OvsGetVport was not updated accordingly.
>
> Fixed the same.
>
> Signed-off-by: Ankur Sharma
Acked-by: Nithin Raju
_
y comment I had was to use read_ioctl rather than readIoctl for naming
the variable.
Acked-by: Nithin Raju
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Sep 30, 2014, at 8:03 AM, Samuel Ghinet
wrote:
> If the hyper-v switch port type is external, then the function
> OvsInitConfiguredSwitchNics allocates a vport, and if allocation
> succeeds, it procedes with the initialization. However, at this
> point, virtPort may happen to be null, but ch
On Sep 30, 2014, at 9:16 AM, Samuel Ghinet
wrote:
> Nithin,
>
> basically, any userspace code that used flows was commented out. And code
> that was trying to set qos to the netdev was commented out (because it was
> retrying forever).
> And netlink functions that used rtnetlink (were used f
> From: Samuel Ghinet
> Sent: Tuesday, September 30, 2014 6:24 PM
> To: Nithin Raju
> Subject: RE: [PATCH] datapath-windows: NUL character should be left out
> during VPORT hash lookup
>
> The vport names given by the userspace using netlink command vport add are
&
On Sep 30, 2014, at 9:48 AM, Samuel Ghinet
wrote:
> Oh, that was a bug.
> Well, in my netlink command vport add I used the full name (including the
> null terminator) for the hash.
> And in the OvsFindVportByOvsName I use length = strlen(name) + 1.
>
> When I pulled the latest modifs from the
e existing
attributes for the events. I also considered adding new attributes to
the VPORT family, but we'll have to extend the standard datapath
interface for that.
In this patch, we fix the definition of 'OVS_WIN_CONTROL_ATTR_MAX' as
well.
Signed-off-by: Nithin Raju
---
In this patch, we add a lib/netdev-windows.c which mostly contains stub
code and in subsequent patches, would use the netlink interface to query
netdev information for a vport.
The code implements netdev functionality for "internal" and "system"
types of vports.
Signed
In this patch, we add stub handlers for the netdev commands.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 27 +--
datapath-windows/ovsext/Vport.c| 14 ++
2 files changed, 39 insertions(+), 2 deletions(-)
diff --git a/datapath
In this patch, we make some fixes in the vport get code as well as
elevating some utility functions from static to non-static.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 17 -
datapath-windows/ovsext/Datapath.h |8
2 files changed, 20
validation:
- Vport dump works now without printing any errors. I didn't go so far
as to test if vport add works.
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Vport.c | 242 +--
datapath-windows/ovsext/Vport.h |3 -
2 files changed
m to be required for the purposes of implement
'ovs-dpctl.exe show'.
Signed-off-by: Nithin Raju
---
lib/netdev-windows.c | 223 -
1 files changed, 218 insertions(+), 5 deletions(-)
diff --git a/lib/netdev-windows.c b/lib/netdev-windows.c
In this patch, we add support for family ID lookup of
OVS_WIN_NETDEV_FAMILY.
Signed-off-by: Nithin Raju
---
lib/netlink-socket.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
index 1717ab8..d5e5728 100644
--- a/lib
hi Alin/Sorin,
There were the items we had to discuss:
1. Netlink task status: vport, flow, events, packet.
2. Discussion on the vport addition workflow (and the document Alin sent out).
I'll have some initial comments on the patches and document by tomorrow.
3. Discussion on packet receive workf
hi Sorin,
I had minor comments. Pls. see inline.
> #define NETLINK_FAMILY_NAME_LEN 48
>
> +#ifndef IFNAMSIZ
> +#define IFNAMSIZ 16
> +#endif
This is defined in OvsDpInterface.h. We can avoid an extra definition. See
commit - f92156ae2c86cf1b7c2076f2bca88b6fa10ec632.
> +
>
> /*
> * Netlink me
Sending out meeting minutes for future reference.
Participants: Alin Serdean, Sorin Vinturis, Nithin Raju.
On Sep 30, 2014, at 6:54 PM, Nithin Raju wrote:
> hi Alin/Sorin,
> There were the items we had to discuss:
>
> 1. Netlink task status: vport, flow, events, packet.
Disc
> > -ASSERT(KeGetCurrentIrql() == DISPATCH_LEVEL);
> > OvsAcquireDatapathRead(datapath, &dpLockState, dispatch);
>
> We can pass NDIS_RWL_AT_DISPATCH_LEVEL instead of 'dispatch', and let the
> ASSERT be.
>
> SV: Here, I will leave the use of the 'dispatch' variable, due to
hi Ankur,
Thanks for making the change. Looks good mostly, I had minor comments.
I'll ack the v2.
On Sep 29, 2014, at 3:34 PM, Ankur Sharma wrote:
> In this patch we have added following new APIs.
>
> NlMsgAlignSize => Aligns the size of netlink message.
> NlMsgSetSize => Sets the value of nlm
> diff --git a/datapath-windows/ovsext/Netlink/NetlinkBuf.c
> b/datapath-windows/ovsext/Netlink/NetlinkBuf.c
> index 918bddd..bc079ef 100644
> --- a/datapath-windows/ovsext/Netlink/NetlinkBuf.c
> +++ b/datapath-windows/ovsext/Netlink/NetlinkBuf.c
> @@ -291,7 +291,7 @@ NlBufAt(PNL_BUFFER nlBuf, UIN
On Sep 29, 2014, at 3:34 PM, Ankur Sharma wrote:
> In this patch we have added basic changes for
> handler registeration for FLOW_GET command.
>
> Signed-off-by: Ankur Sharma
LG.
Acked-by: Nithin Raju
___
dev mailing list
dev@ope
On Sep 29, 2014, at 3:34 PM, Ankur Sharma wrote:
> +VOID
> +NlMsgAlignSize(const PNL_MSG_HDR nlh)
> +{
> +nlh->nlmsgLen = NLMSG_ALIGN(nlh->nlmsgLen);
One question I have here is what if nlmsgLen ends up being more than the
nlBufLen after adjusting for alignment?
Thanks,
-- Nithin
___
hi Ankur,
Thanks for working on this. LG but for minor comments I had.
Acked-by: Nithin Raju
On Sep 29, 2014, at 3:34 PM, Ankur Sharma wrote:
> In this patch we have implemented the flow dump.
>
> Signed-off-by: Ankur Sharma
> ---
> datapath-windows/ovse
hi Ankur,
Changes look good. I had some minor comments. You can get rid of the unused
parameters in OvsGetFlowIoctl(). The code has diverged quite a bit from the
non-NL interface now.
Acked-by: Nithin Raju
On Sep 29, 2014, at 3:34 PM, Ankur Sharma wrote:
> In this patch we have implemen
tch/ovs-issues/issues/47&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=ubrOpIWavCMqX4l4j1LEVpTfDj%2FD5Qyn8KCoJIBGvzo%3D%0A&m=LVqmkXrXC7s%2BOwPh44uIRyKZxvijNhocF4HrGM%2FLZpo%3D%0A&s=a95db0ca0e4ec82510fc3986ec762ffa91d12cfcac04e3e73c16c49d4004d203
Thanks for the change.
Acked-by: Nithin Raju
__
On Oct 3, 2014, at 12:37 AM, Sorin Vinturis
wrote:
> Hi Eitan,
>
> The reason for pushing this patch was to optimize the code when obtaining a
> lock. Thus I have set the flag parameters of NdisAcquireRWLockXXX() functions
> to appropriate values, i.e. NDIS_RWL_AT_DISPATCH_LEVEL, each time
On Sep 30, 2014, at 7:42 AM, Samuel Ghinet
wrote:
> The old IOCTL vport functions (using the non-netlink device) are no
> longer needed. They should be removed.
>
> Signed-off-by: Samuel Ghinet
Acked-by: Nithin Raju
___
dev mail
unctions are helper functions.
>
> Signed-off-by: Samuel Ghinet
Looks good.
Only suggestion I had was to call the functions:
OvsCreate*HV*Nic rather than HvOnCreateNic. Or even HVCreateNic. The 'On'
doesn't seem to add a lot of clarity.
But, I don't feel very strongly.
one;
> }
>
> +if (portParam->IsValidationPort) {
> +return NDIS_STATUS_SUCCESS;
> +}
LG. Only comment I had was that it would be nice if we could add a comment
about Validation ports when we return NDIS_STATUS_SUCCESS.
Acked-by: Nithin Raju
_
seless casts to POVS_VPORT_ENTRY, this patch changes the type
> from PVOID to POVS_VPORT_ENTRY.
>
> This patch does not cleanup the code that already uses casts to
> POVS_VPORT_ENTRY. This cleanup can be done later on as well.
>
> Signed-off-by: Samuel
declaration is
> moved from Vport.c to Vport.h, and becomes public.
>
> Signed-off-by: Samuel Ghinet
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
the comments.
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
n the bounds of the used portion
of the buffer.
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Any attempt
to change the 'portFriendlyName' while ovsPortName != "" should be failed, IMO.
We should not allow these two names to go out of sync.
If there's a good reason to keep 2 separate names, this change looks good.
Acked-by: Nithin Raju
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
gt; the port numbers to MAXUINT16.
>
> Signed-off-by: Samuel Ghinet
Looks good.
Acked-by: Nithin Raju
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
ex in OvsInitVportCommon() and
OvsCreateNic().
This patch as such is fine. If there are bugs, we can address them in future
patches.
Acked-by: Nithin Raju
On Sep 30, 2014, at 7:54 AM, Samuel Ghinet
wrote:
> For this, the old method of finding vports based on the
> ovs port numbers is remove
hi Alin,
Looks good but for the comments.
Acked-by: Nithin Raju
On Sep 30, 2014, at 7:55 AM, Samuel Ghinet
wrote:
> The port friendly name will be set by WMI / powershell script.
> It will be used from within the netlink command vport new to
> identify the hyper-v switch port it r
hi Alin,
This is a huge change, and I think you and Samuel are on the right track. I
have noted down a few comments. Pls. address them and also the comments from
Eitan and Ankur, and we should be in a good shape.
On Sep 30, 2014, at 7:58 AM, Samuel Ghinet
wrote:
> Does the following:
> a. bef
hi Alin,
LG, but for the comments I had.
Acked-by: Nithin Raju
On Sep 30, 2014, at 8:00 AM, Samuel Ghinet
wrote:
> Deletion of a vport is now handled both by the netlink command vport
> delete and the hyper-v switch port delete handler. If a netlink
> command vport delete is reque
hi Alin,
I understand that this patch mostly adds placeholder code for some sort of
completeness.
LG but for minor comments.
Acked-by: Nithin Raju
On Sep 30, 2014, at 8:01 AM, Samuel Ghinet
wrote:
> Signed-off-by: Samuel Ghinet
> ---
> datapath-windows/ovsext/Datapat
On Sep 30, 2014, at 8:03 AM, Samuel Ghinet
wrote:
> If the hyper-v switch port type is external, then the function
> OvsInitConfiguredSwitchNics allocates a vport, and if allocation
> succeeds, it procedes with the initialization. However, at this
> point, virtPort may happen to be null, but che
On Sep 30, 2014, at 7:40 AM, Samuel Ghinet
wrote:
> Hello guys,
>
> This patch number 00 is an introduction to the patch series.
>
> I am sorry we could not provide the design behind this much faster. This
> series of patches is based on that design.
> I have tested these vport commands with
On Oct 3, 2014, at 5:04 PM, Ankur Sharma
mailto:ankursha...@vmware.com>> wrote:
Hi,
Sorry i have a few minor comments in this patch.
a. There is a whitespace error:
Applying: lib/netdev-windows.c: add code to query netdev information
/home/ankur/Desktop/Studies/Codes/ovs_github_review/.git/reba
In this patch, we make some fixes in the vport get code as well as
elevating some utility functions from static to non-static.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
---
datapath-windows/ovsext/Datapath.c | 17 -
datapath-windows/ovsext/Datapath.h |8
In this patch, we add stub handlers for the netdev commands.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
---
datapath-windows/ovsext/Datapath.c | 27 +--
datapath-windows/ovsext/Vport.c| 14 ++
2 files changed, 39 insertions(+), 2 deletions
e existing
attributes for the events. I also considered adding new attributes to
the VPORT family, but we'll have to extend the standard datapath
interface for that.
In this patch, we fix the definition of 'OVS_WIN_CONTROL_ATTR_MAX' as
well.
Signed-off-by: Nithin Raju
Acked-by: Ankur Shar
In this patch, we add a lib/netdev-windows.c which mostly contains stub
code and in subsequent patches, would use the netlink interface to query
netdev information for a vport.
The code implements netdev functionality for "internal" and "system"
types of vports.
Signed-off-by
m to be required for the purposes of implement
'ovs-dpctl.exe show'.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
---
lib/netdev-windows.c | 229 -
1 files changed, 224 insertions(+), 5 deletions(-)
diff --git a/lib/netdev-windows.
validation:
- Vport dump works now without printing any errors. I didn't go so far
as to test if vport add works.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
---
datapath-windows/ovsext/Vport.c | 242 +--
datapath-windows/ovsext/Vport.h |3
In this patch, we add support for family ID lookup of
OVS_WIN_NETDEV_FAMILY.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
---
lib/netlink-socket.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
index 1717ab8
m to be required for the purposes of implement
'ovs-dpctl.exe show'.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
Acked-by: Alin Gabriel Serdean
Tested-by: Alin Gabriel Serdean
---
lib/netdev-windows.c | 229 -
1 files changed,
In this patch, we add stub handlers for the netdev commands.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
Acked-by: Alin Gabriel Serdean
Tested-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Datapath.c | 27 +--
datapath-windows/ovsext/Vport.c| 14
e existing
attributes for the events. I also considered adding new attributes to
the VPORT family, but we'll have to extend the standard datapath
interface for that.
In this patch, we fix the definition of 'OVS_WIN_CONTROL_ATTR_MAX' as
well.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharm
In this patch, we add a lib/netdev-windows.c which mostly contains stub
code and in subsequent patches, would use the netlink interface to query
netdev information for a vport.
The code implements netdev functionality for "internal" and "system"
types of vports.
Signed-off-by
validation:
- Vport dump works now without printing any errors. I didn't go so far
as to test if vport add works.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
Acked-by: Alin Gabriel Serdean
Tested-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Vport.c |
In this patch, we add support for family ID lookup of
OVS_WIN_NETDEV_FAMILY.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
Acked-by: Alin Gabriel Serdean
Tested-by: Alin Gabriel Serdean
---
lib/netlink-socket.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a
In this patch, we make some fixes in the vport get code as well as
elevating some utility functions from static to non-static.
Signed-off-by: Nithin Raju
Acked-by: Ankur Sharma
Acked-by: Alin Gabriel Serdean
Tested-by: Alin Gabriel Serdean
---
datapath-windows/ovsext/Datapath.c | 17
hi Alin/Sorin,
These were the items to discuss from out side:
1. vport add/del review comments
2. netlink integration status: vport, packet commands
Thanks,
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Oct 6, 2014, at 4:23 PM, Ankur Sharma
wrote:
> In this patch we have implemented the handler for
> OVS_PACKET_CMD_EXECUTE command.
>
> Signed-off-by: Ankur Sharma
Ankur,
Can you add a note on how you validated these changes?
-- Nithin
___
dev ma
value is set to 0, since
the vport add code is not checked in yet.
Sending out this patch to unblock the vport add code when it gets checked
in. There are other fixes also required, but they are being addressed as
part of the review comments for vport-add.
Signed-off-by: Nithin Raju
---
datapath
On Oct 6, 2014, at 5:52 PM, Ankur Sharma
wrote:
> Hi Nithin,
>
> I have not tested these changes yet.
> I am figuring out the user-space changes needed for simulating a
> PACKET_CMD_EXECUTE.
>
> If you want to hold the review till testing is done then we can do that.
No problem. Thanks for
We need to pass down the output buffer so that the kernel can return
transaction status - error or otherwise.
Signed-off-by: Nithin Raju
---
lib/netlink-socket.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
index 1aa76ae
hi Alin,
I also wanted to discuss the issues I had found while testing the vport-add
patches.
thanks,
-- Nithin
On Oct 6, 2014, at 2:08 PM, Nithin Raju wrote:
> hi Alin/Sorin,
> These were the items to discuss from out side:
>
> 1. vport add/del review comments
> 2. netl
> +if (vport->hvDeleted || OvsIsTunnelVportType(vport->ovsType)) {
> +/*
> + * The associated hyper-v switch port is not in created state, or,
> + * there is no hyper-v switch port counterpart (for logical ports).
> + * This means that this datapath port is not m
ed to process the reply
unconditionally, but making sure to copy the reply to the 'txn->reply'
only when it is not NULL. The reason for the unconditional processing is
we can pass up transactional errors in 'txn->error'. Otherwise, it
results in an endless loop of calling nl_
The init function must be dummy for the unit tests to pass. The
unit tests don't require the kernel datpaath to be loaded, and
without the kernel datapath, any calls netlink calls will fail.
Signed-off-by: Nithin Raju
Reported-by: Gurucharan Shetty
---
lib/netdev-windows.c |
The init function is not allowed to call into the kernel datapath
while running unit tests since the kernel datapath is not loaded.
Instead of making the function dummy, it is better to not have it
at all.
Signed-off-by: Nithin Raju
Reported-by: Gurucharan Shetty
---
lib/netdev-windows.c
On Oct 7, 2014, at 4:59 PM, Gurucharan Shetty
wrote:
> On Tue, Oct 7, 2014 at 4:35 PM, Nithin Raju wrote:
>> The init function must be dummy for the unit tests to pass. The
>> unit tests don't require the kernel datpaath to be loaded, and
>> without the kernel d
which makes the
following sequence of calls:
open_dpif_backer() -> dpif_create_and_open() -> dpif_create()
We also rename HandleDpTransaction() to HandleDpTransactionCommon().
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Datapath.c | 72 +--
Sending out meeting minutes for future reference:
Attendees: Alex Pilotti, Alin Serdean, Ben Pfaff, Eitan Eliahu, Nithin Raju,
Sorin Vinturis
On Oct 6, 2014, at 6:54 PM, Nithin Raju wrote:
>> 1. vport add/del review comments
- Alin said, he'll address the review comments fo
401 - 500 of 936 matches
Mail list logo
