On Oct 3, 2014, at 5:04 PM, Ankur Sharma <ankursha...@vmware.com<mailto:ankursha...@vmware.com>> wrote:
Hi, Sorry i have a few minor comments in this patch. a. There is a whitespace error: Applying: lib/netdev-windows.c: add code to query netdev information /home/ankur/Desktop/Studies/Codes/ovs_github_review/.git/rebase-apply/patch:14: trailing whitespace. static int query_netdev(const char *devname, warning: 1 line adds whitespace errors. Fixed. b. netdev_windows_alloc: check for alloc failures. Fixed c. netdev_windows_system_construct: i think it should be struct ofpbuf bufp instead of struct ofpbuf *bufp; I followed to example in dpif_netlink_is_internal_device(). Basically, query_port() allocates the ofpbuf and its associated memory and returns it to netdev_windows_system_construct(). There was a missing call to ofpbuf_delete(bufp). I've added it now. We are not checking return value of netdev_windows_netdev_to_ofpbuf Fixed. Acked-by: Ankur Sharma <ankursha...@vmware.com<mailto:ankursha...@vmware.com>> Thanks for the review. -- Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
