On Sep 30, 2014, at 9:48 AM, Samuel Ghinet <sghi...@cloudbasesolutions.com>
 wrote:

> Oh, that was a bug.
> Well, in my netlink command vport add I used the full name (including the 
> null terminator) for the hash.
> And in the OvsFindVportByOvsName I use length = strlen(name) + 1.
> 
> When I pulled the latest modifs from the repo, I noticed I was doing some 
> kind of revert to this patch.
> I would personally prefer to keep the null terminator both in lookups and in 
> hashing / insertion, instead of removing in both. As it is used in my latest 
> patches.

sounds good. I'll take a look at your patch. The fix I sent out was based on 
the existing code, and since you've modified the port add code, I'd imagine the 
lookup would also change.

-- Nithin
_______________________________________________
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev

Reply via email to