> -----Original Message----- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Nithin Raju > Sent: Tuesday, September 23, 2014 1:58 PM > To: Samuel Ghinet > Cc: dev@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v2] datapath-windows: fix OVS_VPORT_TYPE > > On Sep 23, 2014, at 5:45 AM, Samuel Ghinet <sghi...@cloudbasesolutions.com> > wrote: > > > The windows ovs kernel uses an OVS_VPORT_TYPE enum that is > > incompatible with the userspace counterpart (enum ovs_vport_type from > > openvswitch.h). We must use the same enum type for the netlink > communication to work properly. > > > > This patch makes the fix: "typedef enum ovs_vport_type OVS_VPORT_TYPE" > > and changes the afferent kernel driver code: > > o) vport types synthetic and emulated turn to: netdev > > o) vport type internal turns to: internal > > o) vport type external truns to: netdev (plus, we hold a field in > > vport, "isExternal" > > > > Signed-off-by: Samuel Ghinet <sghi...@cloudbasesolutions.com> > > Acked-by: Nithin Raju <nit...@vmware.com>
hi Samuel, I understand that this change might break the non-netlink based codepath. It is OK to make this change. Thanks! -- Nithin _______________________________________________ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev
