they don't seem to extrapolate
the above messages, is there a tool that I can use to get this level of
detailed monitoring?
best regards
Timothy
Hi Colin,
The Kibosh code is just a README for now, is it going to be published soon?
Tim
On Tue, Aug 22, 2017 at 11:44 AM, Colin McCabe wrote:
> Hi all,
>
> I've been working on a fault injector for Apache Kafka. The general
> idea is to create faults such as network partitions or disk failur
Congrats Guozhang!!
Tim
On Tue, Jun 16, 2015 at 8:19 AM, Aditya Auradkar
wrote:
> Congrats Guozhang!
>
>
> From: Ashish Singh [asi...@cloudera.com]
> Sent: Monday, June 15, 2015 10:53 PM
> To: dev@kafka.apache.org
> Cc: Jun Rao
> Subject: Re: Guozhang Wan
/HighwatermarkPersistenceTest.scala
60cd8249e6ec03349e20bb0a7226ea9cd66e6b17
core/src/test/scala/unit/kafka/utils/TestUtils.scala
17e9fe4c159a29033fe9a287db6ced2fdc3fa9d1
Diff: https://reviews.apache.org/r/36474/diff/
Testing
---
Thanks,
Timothy Chen
/kafka/utils/TestUtils.scala
17e9fe4c159a29033fe9a287db6ced2fdc3fa9d1
Diff: https://reviews.apache.org/r/36503/diff/
Testing
---
Thanks,
Timothy Chen
/HighwatermarkPersistenceTest.scala
60cd824
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala 00d5933
core/src/test/scala/unit/kafka/utils/TestUtils.scala 17e9fe4
Diff: https://reviews.apache.org/r/36474/diff/
Testing
---
Thanks,
Timothy Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19379/#review37668
---
Ship it!
Ship It!
- Timothy Chen
On March 19, 2014, 12:14 a.m
/ProducerPerformance.java
<https://reviews.apache.org/r/19388/#comment69332>
Not sure if this is intentional.
clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java
<https://reviews.apache.org/r/19388/#comment69333>
Should all the callers also check null now?
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19388/#review37791
---
Ship it!
Ship It!
- Timothy Chen
On March 19, 2014, 5:29 p.m
/browse/KAFKA-1312
Repository: kafka
Description
---
KAFKA-1312 Add IDE generated files into git ignore
Diffs
-
.gitignore 553a077d031a37d78f4921d9e7ab39132d979276
Diff: https://reviews.apache.org/r/19421/diff/
Testing
---
Thanks,
Timothy Chen
/ByteBufferOutputStream.java
<https://reviews.apache.org/r/18299/#comment69589>
Perhaps only provide a getter to avoid the stream state getting modified.
- Timothy Chen
On March 19, 2014, 11:32 p.m., Guozhang Wang wrote:
>
> ---
---
Thanks,
Timothy Chen
briefly but didn't know the frequency of the
call.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19490/#review37961
------
://reviews.apache.org/r/19490/diff/
Testing
---
Thanks,
Timothy Chen
27;t need to change this as getAbsolutePath matches the getParent folder path
string.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19490/#review37967
--
/test/scala/unit/kafka/server/HighwatermarkPersistenceTest.scala
02c188a412995f876dd6616d70027b84c07eb264
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala PRE-CREATION
Diff: https://reviews.apache.org/r/19490/diff/
Testing
---
Thanks,
Timothy Chen
8262e10ce4364f057e449172ace38320e44247db
Diff: https://reviews.apache.org/r/19577/diff/
Testing
---
Thanks,
Timothy Chen
/kafka/controller/TopicDeletionManager.scala
8262e10ce4364f057e449172ace38320e44247db
Diff: https://reviews.apache.org/r/19577/diff/
Testing
---
Thanks,
Timothy Chen
manager needs to hold on to the
same lock, as the signaling and awaiting seems to be indepedendent of other
operations (but I very well can be wrong).
Looking at KAFKA-1307 it seems that a patch is submitted for that already? Do
we still see issues from that?
- Timothy
-
/kafka/controller/TopicDeletionManager.scala
8262e10ce4364f057e449172ace38320e44247db
Diff: https://reviews.apache.org/r/19577/diff/
Testing
---
Thanks,
Timothy Chen
255be063ee247a849e527297c987da4625d749ca
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
b5936d4101b513baa805ab26361fe965bdf980aa
Diff: https://reviews.apache.org/r/19626/diff/
Testing
---
Thanks,
Timothy Chen
/scala/kafka/controller/TopicDeletionManager.scala
8262e10ce4364f057e449172ace38320e44247db
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala
20fe93e623319fd82236eb6364d7f80bf7a256aa
Diff: https://reviews.apache.org/r/19577/diff/
Testing
---
Thanks,
Timothy Chen
d it
mock log manager. Can definitely just rename the test method and make it
private.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19626/#review38565
--------
uses File objects, and LogManager constructor only
accepts array of File directories so I don't think relative/absolute or
different path trailing conventions has much meaning to be tested for LogMgr.
Thoughts?
- Timothy
---
This is a
/kafka/controller/TopicDeletionManager.scala
8262e10ce4364f057e449172ace38320e44247db
Diff: https://reviews.apache.org/r/19577/diff/
Testing
---
Thanks,
Timothy Chen
90e2dcf5434db546387302fb0219edfdb363592e
Diff: https://reviews.apache.org/r/19690/diff/
Testing
---
Thanks,
Timothy Chen
/kafka/controller/TopicDeletionManager.scala
8262e10ce4364f057e449172ace38320e44247db
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala
20fe93e623319fd82236eb6364d7f80bf7a256aa
Diff: https://reviews.apache.org/r/19577/diff/
Testing
---
Thanks,
Timothy Chen
488dfd08d9956dab2fb1ed3925d138cda637509d
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala
20fe93e623319fd82236eb6364d7f80bf7a256aa
Diff: https://reviews.apache.org/r/19696/diff/
Testing
---
Thanks,
Timothy Chen
---
Thanks,
Timothy Chen
---
Thanks,
Timothy Chen
Hi Roy,
I wonder if you were able to start the broker following the steps here:
http://kafka.apache.org/documentation.html#quickstart
That page also shows you how to create a topic and send/consume messages
using the console producer/consumer.
Let us know if you run into any problems,
Tim
On
/main/scala/kafka/controller/TopicDeletionManager.scala
8262e10ce4364f057e449172ace38320e44247db
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala
20fe93e623319fd82236eb6364d7f80bf7a256aa
Diff: https://reviews.apache.org/r/19577/diff/
Testing
---
Thanks,
Timothy Chen
/main/scala/kafka/controller/TopicDeletionManager.scala
488dfd08d9956dab2fb1ed3925d138cda637509d
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala
20fe93e623319fd82236eb6364d7f80bf7a256aa
Diff: https://reviews.apache.org/r/19696/diff/
Testing
---
Thanks,
Timothy Chen
e unit test in ReplicaManagerTest cover checkpointing, but we also need
> > to add coverage for log recovery and log cleaning since those are the
> > places that touch the directory mapping
>
> Timothy Chen wrote:
> I just looked at the LogManager and looks like they have their o
ng in trunk.
Interestingly if running the tests individually they pass, so I think it has
something to do with other tests affecting the outcome of this one.
I'll be looking into this.
- Timothy
---
This is an automaticall
b5936d4101b513baa805ab26361fe965bdf980aa
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala
20fe93e623319fd82236eb6364d7f80bf7a256aa
core/src/test/scala/unit/kafka/utils/TestUtils.scala
2054c25bbced6bd90c092a1974975732ad346146
Diff: https://reviews.apache.org/r/19696/diff/
Testing
---
Thanks,
Timothy
: https://reviews.apache.org/r/19626/diff/
Testing
---
Thanks,
Timothy Chen
b5936d4101b513baa805ab26361fe965bdf980aa
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala
20fe93e623319fd82236eb6364d7f80bf7a256aa
core/src/test/scala/unit/kafka/utils/TestUtils.scala
2054c25bbced6bd90c092a1974975732ad346146
Diff: https://reviews.apache.org/r/19696/diff/
Testing
---
Thanks,
Timothy
<https://reviews.apache.org/r/19696/#comment71296>
I think it wasn't atomic since it's assuming that the methods are called
within controllerContext lock.
To be safe we can make it AtomicBoolean and I don't think it has much
performance impact either way.
- Timot
tps://reviews.apache.org/r/19828/#comment71406>
Should we remove these guards? From profiling it does seem the
String.format can potentially be more expensive than we thought
- Timothy Chen
On March 30, 2014, 6:29 a.m., Neha Narkhede
tps://reviews.apache.org/r/19828/#comment71422>
Not sure if I'm missing something, but isn't the string format is going to
be called here no matter what? I don't think this is a lambda function right?
- Timothy Chen
On March 30, 2014, 6:29 a.m.
;t see any Popen.communicate
changes in this rb?
- Timothy Chen
On March 31, 2014, 5:32 p.m., Jun Rao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19510/#review39070
---
Ah found it! Was searching for popen earlier.
- Timothy Chen
On
/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
b5936d4101b513baa805ab26361fe965bdf980aa
Diff: https://reviews.apache.org/r/19626/diff/
Testing
---
Thanks,
Timothy Chen
37264
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
b5936d4101b513baa805ab26361fe965bdf980aa
Diff: https://reviews.apache.org/r/19690/diff/
Testing
---
Thanks,
Timothy Chen
.java
5d93965a33bedc471fe6126277992591e0560add
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java
99856e93f307e5e3db045653355bfb0d19114a0d
Diff: https://reviews.apache.org/r/19690/diff/
Testing
---
Thanks,
Timothy Chen
small test and comment on
> the jira.
Yes you are correct, this shouldn't be a issue if we use our logging trait.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19828/#r
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19828/#review39109
---
Ship it!
Ship It!
- Timothy Chen
On March 30, 2014, 6:29 a.m
/Selector.java
<https://reviews.apache.org/r/19879/#comment71554>
I'm not sure what our naming convention is, but one thing I notice is that
we sometimes add ns (nanoseconds) in the name and sometimes doesn't. Do we want
to have a convention for units or?
- Timothy Chen
On April 1
gt; > 1. All rates are in seconds (the default)
> > 2. All latencies are in ms unless otherwise noted.
> > 3. A few things require finer grained measurement than 1 ms and for
> > these I called it out in the name so this would not be confusing.
Then perhaps io-ratio ne
/test/scala/unit/kafka/server/ReplicaManagerTest.scala
b5936d4101b513baa805ab26361fe965bdf980aa
Diff: https://reviews.apache.org/r/19626/diff/
Testing
---
Thanks,
Timothy Chen
27;t seem to be random though, it seems like it's
going to favor the lower broker nodes first?
- Timothy Chen
On April 2, 2014, 6:49 p.m., Jun Rao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
c068ef69207c351eec413a595f1747c59f8b3983
Diff: https://reviews.apache.org/r/19957/diff/
Testing
---
Thanks,
Timothy Chen
/19972/diff/
Testing
---
Thanks,
Timothy Chen
iveBrokers.get).filter(_.isEmpty)
this is passed to a function that only accepts Seq[Broker] and even if you
filter the return type still is a Seq[Option[Broker]].
I think I'll just leave it as is
- Timothy
---
This is an automatica
> > (0 to numPartitions).map( ).toArray
(0 to numPartitions).map(null).toArray actually gives me a null pointer
exception :)
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://
/kafka/controller/KafkaController.scala
fcabd0da201ccd478f5884bcca9b75a8c8ea8373
core/src/main/scala/kafka/server/KafkaApis.scala
c068ef69207c351eec413a595f1747c59f8b3983
Diff: https://reviews.apache.org/r/19957/diff/
Testing
---
Thanks,
Timothy Chen
gt;
> Thanks again for the patch. I'll get this checked in.
>From profiling with 1000 topics actually the largest contribution looks like
>was the metadataCache.map(_.topic) call, which originally we call for each
>topic that is being requested.
gt;
> Thanks again for the patch. I'll get this checked in.
>
> Timothy Chen wrote:
> From profiling with 1000 topics actually the largest contribution looks
> like was the metadataCache.map(_.topic) call, which originally we call for
> each topic that is bein
's too complicated. However, most requests will
> have a small # of topics in the request. In those cases, there is no need to
> make a copy of all cached topics.
The original code actually does a toSet of all the topics in each t
/kafka/server/SimpleFetchTest.scala
22bb6f2847b8895f8fbba6c531963ebb0fffe2ca
core/src/test/scala/unit/kafka/utils/TestUtils.scala
2054c25bbced6bd90c092a1974975732ad346146
Diff: https://reviews.apache.org/r/19957/diff/
Testing
---
Thanks,
Timothy Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20038/#review39616
---
Ship it!
Ship It!
- Timothy Chen
On April 4, 2014, 8:51 p.m
create an empty one
> > of size numPartitions?
I realized I was using scala's immutable array when I was trying it, with a
mutable array it works. Fixing it now.
- Timothy
---
This is an automatically generated e-mail. To repl
/kafka/server/SimpleFetchTest.scala
22bb6f2847b8895f8fbba6c531963ebb0fffe2ca
core/src/test/scala/unit/kafka/utils/TestUtils.scala
2054c25bbced6bd90c092a1974975732ad346146
Diff: https://reviews.apache.org/r/19957/diff/
Testing
---
Thanks,
Timothy Chen
/kafka/server/SimpleFetchTest.scala
22bb6f2847b8895f8fbba6c531963ebb0fffe2ca
core/src/test/scala/unit/kafka/utils/TestUtils.scala
2054c25bbced6bd90c092a1974975732ad346146
Diff: https://reviews.apache.org/r/19957/diff/
Testing
---
Thanks,
Timothy Chen
ment72313>
Looks like the mock consumer doesn't follow the mutually exclusive rule.
- Timothy Chen
On March 27, 2014, 4:16 p.m., Neha Narkhede wrote:
>
> ---
> This is an automatic
/kafka/server/SimpleFetchTest.scala
22bb6f2847b8895f8fbba6c531963ebb0fffe2ca
core/src/test/scala/unit/kafka/utils/TestUtils.scala
2054c25bbced6bd90c092a1974975732ad346146
Diff: https://reviews.apache.org/r/19957/diff/
Testing
---
Thanks,
Timothy Chen
/
Testing
---
Thanks,
Timothy Chen
Diff: https://reviews.apache.org/r/20143/diff/
Testing
---
Thanks,
Timothy Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20130/#review39863
---
Ship it!
Ship It!
- Timothy Chen
On April 8, 2014, 11:18 p.m
Diff: https://reviews.apache.org/r/20143/diff/
Testing
---
Thanks,
Timothy Chen
tps://reviews.apache.org/r/20186/#comment72754>
I thought we want to assert here so we know from the output it's the leader
not being elected being the problem in test?
- Timothy Chen
On April 10, 2014, 1:22 a.m., Ju
/
Testing
---
Thanks,
Timothy Chen
: https://reviews.apache.org/r/20187/diff/
Testing
---
Thanks,
Timothy Chen
/
Testing
---
Thanks,
Timothy Chen
ate controllerEpoch if the new value is higher than the
> > current one. Perhaps we can add a util function in ReplicaManager to do
> > that.
Talked to Jun and we agree the previous check is sufficient here.
- Timothy
--
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20130/#review40078
---
Ship it!
Ship It!
- Timothy Chen
On April 8, 2014, 11:18 p.m
/unit/kafka/utils/TestUtils.scala
500eeca2f95d901536b1363b8c4b485c4893179f
Diff: https://reviews.apache.org/r/20252/diff/
Testing
---
Thanks,
Timothy Chen
1317b4c3c60b8d1835dd6a06bf9b250398f0d47d
core/src/test/scala/unit/kafka/utils/TestUtils.scala
500eeca2f95d901536b1363b8c4b485c4893179f
Diff: https://reviews.apache.org/r/20252/diff/
Testing
---
Thanks,
Timothy Chen
/server/SimpleFetchTest.scala
1317b4c3c60b8d1835dd6a06bf9b250398f0d47d
core/src/test/scala/unit/kafka/utils/TestUtils.scala
500eeca2f95d901536b1363b8c4b485c4893179f
Diff: https://reviews.apache.org/r/20252/diff/
Testing
---
Thanks,
Timothy Chen
tps://reviews.apache.org/r/20536/#comment74283>
Isn't this a unnecessary check? The parent if check already checks the flag.
- Timothy Chen
On April 21, 2014, 9:34 p.m., Joel Koshy wrote:
>
> ---
> This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20534/#review40968
---
Ship it!
Ship It!
- Timothy Chen
On April 21, 2014, 9:47 p.m
tps://reviews.apache.org/r/20540/#comment74401>
Do we no longer need to check for offset management topic?
- Timothy Chen
On April 22, 2014, 4:37 p.m., Jun Rao wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20540/#review41067
---
Ship it!
Ship It!
- Timothy Chen
On April 22, 2014, 8:51 p.m
+1 (Non-binding).
Tim
On Thu, Apr 24, 2014 at 5:32 PM, Joel Koshy wrote:
> +1
>
> One (non-critical) issue is that I think our packaging isn't complete
> for kafka-perf (we are only building for 2.8.0).
>
> On Tue, Apr 22, 2014 at 07:18:38PM -0400, Joe Stein wrote:
>> This is the first candidate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20713/#review41473
---
Ship it!
Ship It!
- Timothy Chen
On April 25, 2014, 2:54 p.m
/KafkaServerStartable.scala
acda52b801714bcc182edc0ced925f0e4b493fc1
Diff: https://reviews.apache.org/r/20718/diff/
Testing
---
Thanks,
Timothy Chen
going into another lifecycle state.
I think coming back to the high level of what we want for broker states, since
really a broker should really just be in a state at one point of time, setting
a particular state I think makes more sense.
Composite states probably makes more sense for different co
c208f83bed7fb91f07fae42f2b66892e6d46fecc
core/src/main/scala/kafka/server/KafkaServerStartable.scala
acda52b801714bcc182edc0ced925f0e4b493fc1
Diff: https://reviews.apache.org/r/20718/diff/
Testing
---
Thanks,
Timothy Chen
9c29e144bba2c9bafa91941b6ca5c263490693b3
core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala
b1c4ce9f66aa86c68f2e6988f67546fa63ed1f9b
Diff: https://reviews.apache.org/r/20745/diff/
Testing
---
Thanks,
Timothy Chen
ne failed replica. But it could
be that it is just queued up to be deleted the first time.
The effect is that in the logs you will see that the current code will log that
it attempts to retry topic deletion again, while it's just b
/unit/kafka/admin/DeleteTopicTest.scala
9c29e144bba2c9bafa91941b6ca5c263490693b3
core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala
b1c4ce9f66aa86c68f2e6988f67546fa63ed1f9b
Diff: https://reviews.apache.org/r/20745/diff/
Testing
---
Thanks,
Timothy Chen
/unit/kafka/admin/DeleteTopicTest.scala
9c29e144bba2c9bafa91941b6ca5c263490693b3
core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala
b1c4ce9f66aa86c68f2e6988f67546fa63ed1f9b
Diff: https://reviews.apache.org/r/20745/diff/
Testing
---
Thanks,
Timothy Chen
2#file569942line86>
> >
> > There seems to be no guarantee that the delete topic process is
> > completed before the controller was shutdown. So, I am not sure how
> > reliable the test is.
It's actually the reverse, where it tries to shutdown control
,
Timothy Chen
s to be the same as
> > testPartitionReassignmentDuringDeleteTopic().
Just the order of requests, but as well cannot gurantee what is processed first
as they're just asynchronous. Will remove.
- Timothy
---
This is an automatic
5c487968014b56490eb2bc876cef1c52efd1cdad
core/src/test/scala/unit/kafka/utils/TestUtils.scala
49c7790c995bb2e79322eb148ab80d0dcccefed4
Diff: https://reviews.apache.org/r/20745/diff/
Testing
---
Thanks,
Timothy Chen
5c487968014b56490eb2bc876cef1c52efd1cdad
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala
014e9644dba1d65142f6a9abc745858870a46230
core/src/test/scala/unit/kafka/utils/TestUtils.scala
49c7790c995bb2e79322eb148ab80d0dcccefed4
Diff: https://reviews.apache.org/r/20745/diff/
Testing
---
Thanks,
Timothy
the enums. One example is
in our custom kafka server startable we can inject more states that is specific
to different use cases.
- Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2
c208f83bed7fb91f07fae42f2b66892e6d46fecc
core/src/main/scala/kafka/server/KafkaServerStartable.scala
acda52b801714bcc182edc0ced925f0e4b493fc1
Diff: https://reviews.apache.org/r/20718/diff/
Testing
---
Thanks,
Timothy Chen
1 - 100 of 293 matches
Mail list logo
