> On March 26, 2014, 10:59 p.m., Neha Narkhede wrote: > > When I applied this patch to trunk, I started seeing unit test failures. In > > my last test run, kafka.log4j.KafkaLog4jAppenderTest fails. Before this, > > I've never seen unit test failures, so I wonder if this patch is causing > > the regression. Could you please double-check?
I see the test failure too now, which I thought it was odd to see it in a totally unrelated area. I grabbed latest trunk and ran the tests too and see the test failure as well, so I can confirm it's also happening in trunk. Interestingly if running the tests individually they pass, so I think it has something to do with other tests affecting the outcome of this one. I'll be looking into this. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19696/#review38670 ----------------------------------------------------------- On March 26, 2014, 10:19 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19696/ > ----------------------------------------------------------- > > (Updated March 26, 2014, 10:19 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1317 > https://issues.apache.org/jira/browse/KAFKA-1317 > > > Repository: kafka > > > Description > ------- > > KAFKA-1317 Fix Kafka shutdown with delete topic on > > > Diffs > ----- > > core/src/main/scala/kafka/controller/KafkaController.scala > 7dc27186dec23eccef934b0a1af9f320553e6c7c > core/src/main/scala/kafka/controller/TopicDeletionManager.scala > 488dfd08d9956dab2fb1ed3925d138cda637509d > core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala > 20fe93e623319fd82236eb6364d7f80bf7a256aa > > Diff: https://reviews.apache.org/r/19696/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >
