----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/#review39694 -----------------------------------------------------------
clients/src/main/java/kafka/clients/consumer/Consumer.java <https://reviews.apache.org/r/19731/#comment72276> I wonder if it's worth adding more comments about the poll behavior here, about what conditions will it return from poll (ie: when timeout hit, first topic data available, etc). clients/src/main/java/kafka/clients/consumer/Consumer.java <https://reviews.apache.org/r/19731/#comment72303> I know we return custom future objects for the producer, is there a reason we don't keep it consistent on the consumer? clients/src/main/java/kafka/clients/consumer/ConsumerConfig.java <https://reviews.apache.org/r/19731/#comment72277> What happens when you explicitly call commit when auto commit is enabled? clients/src/main/java/kafka/clients/consumer/ConsumerConfig.java <https://reviews.apache.org/r/19731/#comment72278> Don't we throw an exception instead of being stuck? Being stuck doesn't sounds like a acceptable behavior clients/src/main/java/kafka/clients/consumer/KafkaConsumer.java <https://reviews.apache.org/r/19731/#comment72305> How does one actually get the list of partitions that returns failure? clients/src/main/java/kafka/clients/consumer/KafkaConsumer.java <https://reviews.apache.org/r/19731/#comment72279> Potentially in this sample code you could throw an exception in your catch block and never call close. Is that ok too? clients/src/main/java/kafka/clients/consumer/MockConsumer.java <https://reviews.apache.org/r/19731/#comment72313> Looks like the mock consumer doesn't follow the mutually exclusive rule. - Timothy Chen On March 27, 2014, 4:16 p.m., Neha Narkhede wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19731/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 4:16 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1328 > https://issues.apache.org/jira/browse/KAFKA-1328 > > > Repository: kafka > > > Description > ------- > > Added license headers > > > Cleaned javadoc for ConsumerConfig > > > Fixed minor indentation in ConsumerConfig > > > Improve docs on ConsumerConfig > > > 1. Added ClientUtils 2. Added basic constructor implementation for > KafkaConsumer > > > Improved MockConsumer > > > Chris's feedback and also consumer rewind example code > > > Added commit() and commitAsync() APIs to the consumer and updated docs and > examples to reflect that > > > 1. Added consumer usage examples to javadoc 2. Changed signature of APIs that > accept or return offsets from list of offsets to map of offsets > > > Improved example for using ConsumerRebalanceCallback > > > Improved example for using ConsumerRebalanceCallback > > > Included Jun's review comments and renamed positions to seek. Also included > position() > > > Changes to javadoc for positions() > > > Changed the javadoc for ConsumerRebalanceCallback > > > Changing unsubscribe to also take in var args for topic list > > > Incorporated first round of feedback from Jay, Pradeep and Mattijs on the > mailing list > > > Updated configs > > > Javadoc for consumer complete > > > Completed docs for Consumer and ConsumerRebalanceCallback. Added MockConsumer > > > Added the initial interfaces and related documentation for the consumer. More > docs required to complete the public API > > > Diffs > ----- > > clients/src/main/java/kafka/clients/consumer/Consumer.java PRE-CREATION > clients/src/main/java/kafka/clients/consumer/ConsumerConfig.java > PRE-CREATION > clients/src/main/java/kafka/clients/consumer/ConsumerRebalanceCallback.java > PRE-CREATION > clients/src/main/java/kafka/clients/consumer/ConsumerRecord.java > PRE-CREATION > clients/src/main/java/kafka/clients/consumer/KafkaConsumer.java > PRE-CREATION > clients/src/main/java/kafka/clients/consumer/MockConsumer.java PRE-CREATION > clients/src/main/java/kafka/common/TopicPartitionOffset.java PRE-CREATION > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > 1ff9174870a8c9cd97eb6655416edd4124377b0e > clients/src/main/java/org/apache/kafka/common/utils/ClientUtils.java > PRE-CREATION > > clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerExampleTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/19731/diff/ > > > Testing > ------- > > > Thanks, > > Neha Narkhede > >
