> On April 3, 2014, 1:13 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 638 > > <https://reviews.apache.org/r/19957/diff/1/?file=546094#file546094line638> > > > > I think this really should have been > > isr.map(aliveBrokers.get).filter(_.isEmpty)
this is passed to a function that only accepts Seq[Broker] and even if you filter the return type still is a Seq[Option[Broker]]. I think I'll just leave it as is - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19957/#review39378 ----------------------------------------------------------- On April 2, 2014, 8:44 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19957/ > ----------------------------------------------------------- > > (Updated April 2, 2014, 8:44 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1356 > https://issues.apache.org/jira/browse/KAFKA-1356 > > > Repository: kafka > > > Description > ------- > > KAFKA-1356 Improve topic metadata handling in kafka api > > > Diffs > ----- > > core/src/main/scala/kafka/api/TopicMetadata.scala > 0513a59ed94e556894b3515dc38666ee9a66ae3d > core/src/main/scala/kafka/server/KafkaApis.scala > c068ef69207c351eec413a595f1747c59f8b3983 > > Diff: https://reviews.apache.org/r/19957/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >
