----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20540/#review41067 -----------------------------------------------------------
Ship it! Ship It! - Timothy Chen On April 22, 2014, 8:51 p.m., Jun Rao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20540/ > ----------------------------------------------------------- > > (Updated April 22, 2014, 8:51 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1410 > https://issues.apache.org/jira/browse/KAFKA-1410 > > > Repository: kafka > > > Description > ------- > > 1. Handle the creation of OffsetTopic properly. > > > 1. Move MetadataCache to its own class. 2. Avoid updating metadata cache if > the controller epoch is old. > > > 1. Remove ensureTopicExists(). 2. Move the update of controller epoc in topic > metadata request to ReplicaManager. > > > Diffs > ----- > > core/src/main/scala/kafka/server/KafkaApis.scala > 1a4ffcea37e32739b8360956b4a40c0101b97822 > core/src/main/scala/kafka/server/MetadataCache.scala PRE-CREATION > core/src/main/scala/kafka/server/ReplicaManager.scala > 5588f59783d5cd8f074263c207045625282af12d > core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala > 17b08e14f5e9bfec1233c80d74b50bc2ec38aa25 > > Diff: https://reviews.apache.org/r/20540/diff/ > > > Testing > ------- > > > Thanks, > > Jun Rao > >
