> On March 26, 2014, 12:55 a.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala, line 66 > > <https://reviews.apache.org/r/19626/diff/1/?file=535572#file535572line66> > > > > This method can be private. > > > > This method seems to indicate that it creates a mock log manager, but > > actually it creates a real LogManager object. I'm not sure I understand the > > motivation behind moving away from the mock object to an actual LogManager > > object?
Originally I just mocked LogManager with EasyMock, but encountered the problem where Partition.getOrCreateReplica is looking for properties in LogManager and seems like EasyMock only allows mocking methods not public properties. It's not a full mock, but I'm using a mocked object (MockTime) so I named it mock log manager. Can definitely just rename the test method and make it private. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19626/#review38565 ----------------------------------------------------------- On March 25, 2014, 6:54 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19626/ > ----------------------------------------------------------- > > (Updated March 25, 2014, 6:54 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1323 > https://issues.apache.org/jira/browse/KAFKA-1323 > > > Repository: kafka > > > Description > ------- > > KAFKA-1323 Fix log directory to support relative directories > > > Diffs > ----- > > core/src/main/scala/kafka/cluster/Partition.scala > 0b88f14c4855b27242906cd45930bae501e26226 > core/src/main/scala/kafka/server/ReplicaManager.scala > 255be063ee247a849e527297c987da4625d749ca > core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala > b5936d4101b513baa805ab26361fe965bdf980aa > > Diff: https://reviews.apache.org/r/19626/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >
