----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20130/#review39863 -----------------------------------------------------------
Ship it! Ship It! - Timothy Chen On April 8, 2014, 11:18 p.m., Joel Koshy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20130/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 11:18 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1373 > https://issues.apache.org/jira/browse/KAFKA-1373 > > > Repository: kafka > > > Description > ------- > > Set first dirty (uncompacted) offset to first offset of the log if no > checkpoint exists. > > > Diffs > ----- > > core/src/main/scala/kafka/log/LogCleanerManager.scala > 6a981345fd7dc711e6c4f058a42bd7f8f9d350fe > core/src/main/scala/kafka/server/KafkaConfig.scala > b0506d4881176cd95914847c4275e428a8d2ca10 > core/src/main/scala/kafka/server/OffsetCheckpoint.scala > 19f61a9718a7f8e6f9bf743ac9eb2118d0fdd9b0 > core/src/main/scala/kafka/server/OffsetManager.scala > 89a88a7e4055f804429b64e85b2f65312d1e2155 > core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala > 9aeb69d4934b9aa94e0899af14fc27e7c20f039f > > Diff: https://reviews.apache.org/r/20130/diff/ > > > Testing > ------- > > > Thanks, > > Joel Koshy > >
