----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20536/#review40959 -----------------------------------------------------------
core/src/main/scala/kafka/server/KafkaApis.scala <https://reviews.apache.org/r/20536/#comment74283> Isn't this a unnecessary check? The parent if check already checks the flag. - Timothy Chen On April 21, 2014, 9:34 p.m., Joel Koshy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20536/ > ----------------------------------------------------------- > > (Updated April 21, 2014, 9:34 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1380 > https://issues.apache.org/jira/browse/KAFKA-1380 > > > Repository: kafka > > > Description > ------- > > KAFKA-1356; follow-up - return unknown topic partition on non-existent topic > if auto.create is off > > > Diffs > ----- > > core/src/main/scala/kafka/server/KafkaApis.scala > 9e569eb8c3586b2fdb3b5904c5fa5f938cffada1 > > Diff: https://reviews.apache.org/r/20536/diff/ > > > Testing > ------- > > > Thanks, > > Joel Koshy > >
