[dpdk-dev] [PATCH v2 2/3] doc: update eventdev feature matrix for octeontx2

2019-11-20 Thread Sunil Kumar Kori
Patch updates eventdev and adapters feature matrices for octeontx2 platform. Signed-off-by: Sunil Kumar Kori --- v2: - Review comments incorporated doc/guides/eventdevs/features/octeontx2.ini | 17 + .../eventdevs/overview_adptr_feature_table.txt | 6 +++--- doc/guides/ev

[dpdk-dev] [PATCH v2 1/3] doc: add skeleton for eventdevs feature matrices

2019-11-20 Thread Sunil Kumar Kori
Patch adds skeleton for feature matrices for event dev and Rx/Tx adapters. Signed-off-by: Sunil Kumar Kori --- v2: - Review comments incorporated doc/guides/eventdevs/index.rst| 1 + doc/guides/eventdevs/overview.rst | 19 + .../overview_adptr_feature_table.txt

[dpdk-dev] [PATCH v2 3/3] doc: update eventdev feature matrix for octeontx

2019-11-20 Thread Sunil Kumar Kori
Patch updates eventdev and adapters feature matrices for octeontx platform. Signed-off-by: Sunil Kumar Kori --- v2: - Review comments incorporated doc/guides/eventdevs/features/octeontx.ini | 16 .../eventdevs/overview_adptr_feature_table.txt | 4 ++-- doc/guides/even

Re: [dpdk-dev] [PATCH] net/mlx5: fix incorrect L3 layer chosen in TTL action

2019-11-20 Thread Matan Azrad
Hi Mou From: Suanming Mou > For IPINIP flow, there are two L3 layer match pattern items, the inner layer > follows the outer layer as the latter L3 layer item, the TTL action handles > the > outer layer. > > Current the outer and inner L3 layers are both regared as the outer L3 layer, > it cau

Re: [dpdk-dev] [PATCH v4] net/ice: add flow mark hint support

2019-11-20 Thread Thomas Monjalon
21/11/2019 02:19, Zhang, Qi Z: > From: Thomas Monjalon > > 19/11/2019 07:14, Qi Zhang: > > > Since not all data paths support flow mark, the driver needs a hint > > > from application to select the correct data path if flow mark is > > > required. The patch introduces a devarg "flow-mark-support"

[dpdk-dev] [PATCH v2 3/5] event/octeontx2: improve chunk pool performance

2019-11-20 Thread pbhagavatula
From: Pavan Nikhilesh Enable mempool cache for internal mempool to improve alloc performance. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_tim_evdev.c | 4 ++-- drivers/event/octeontx2/otx2_tim_worker.h | 15 ++- 2 files changed, 16 insertions(+), 3 deletions(-

[dpdk-dev] [PATCH v2 5/5] event/octeontx2: update start timestamp periodically

2019-11-20 Thread pbhagavatula
From: Pavan Nikhilesh Update start timestamp periodically to prevent drift. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_tim_evdev.c | 28 +++ drivers/event/octeontx2/otx2_tim_evdev.h | 7 -- drivers/event/octeontx2/otx2_tim_worker.c | 19 +

[dpdk-dev] [PATCH v2 4/5] event/octeontx2: update SSO buffers based on timer count

2019-11-20 Thread pbhagavatula
From: Pavan Nikhilesh Update SSO internal XAQ buffers based on number of timers in event timer adapter. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_evdev.h | 6 +- drivers/event/octeontx2/otx2_evdev_adptr.c | 84 +- drivers/event/octeontx2/otx2_ti

[dpdk-dev] [PATCH v2 2/5] event/octeontx2: use opposite bucket to store current chunk

2019-11-20 Thread pbhagavatula
From: Pavan Nikhilesh Since TIM buckets are always aligned to 32B and our cache line size being 128B, we will always have a cache miss when reading current_chunk pointer. Avoid the cache miss by storing the current_chunk pointer in the bucket opposite to the current bucket. Signed-off-by: Pavan

[dpdk-dev] [PATCH v2 1/5] event/octeontx2: fix TIM HW race condition

2019-11-20 Thread pbhagavatula
From: Pavan Nikhilesh Fix HW race condition observed when timeout resolution is low (<5us). When HW traverses a given TIM bucket it will clear chunk_remainder, but since SW always decreases the chunk_remainder at the start of the arm routine it might cause a race where SW updates chunk_remainder

Re: [dpdk-dev] [PATCH v18 10/19] raw/ifpga: add SEU error handler

2019-11-20 Thread Zhang, Tianfei
> -Original Message- > From: David Marchand > Sent: Thursday, November 21, 2019 5:30 AM > To: Thomas Monjalon > Cc: Xu, Rosen ; dev ; Zhang, Tianfei > ; Pei, Andy ; Ye, Xiaolong > ; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH v18 10/19] raw/ifpga: add SEU error handler > > On Wed,

Re: [dpdk-dev] [PATCH] net/ixgbe: fix qos sched sample app performance drop

2019-11-20 Thread Wang, ShougangX
Hi, Xiaolong > -Original Message- [snip] > >+static void ixgbe_dev_macsec_init(struct rte_eth_dev *dev); > >+ > > /* > > * Define VF Stats MACRO for Non "cleared on read" register > > */ > >@@ -1095,6 +1097,8 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, > >void *init_params __rte_u

Re: [dpdk-dev] [PATCH v18 10/19] raw/ifpga: add SEU error handler

2019-11-20 Thread Xu, Rosen
Hi, > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, November 21, 2019 5:23 > To: Xu, Rosen > Cc: dev@dpdk.org; Zhang, Tianfei ; Pei, Andy > ; Ye, Xiaolong ; Yigit, Ferruh > ; david.march...@redhat.com > Subject: Re: [dpdk-dev] [PATCH v18 10/19]

Re: [dpdk-dev] [PATCH v3 0/2] fix FDIR support for GTPU

2019-11-20 Thread Ye Xiaolong
On 11/21, Yahui Cao wrote: >This patch series enables FDIR support for both GTP-U and GTP-U with >extension header. > >- Patch 1 renames GTPU with extension header related variables >- Patch 2 adds FDIR support for non-extension-header GTPU > >-- >v3: >* Change commit message > >v2: >* Re-organize

Re: [dpdk-dev] [PATCH v4] net/ice: fix FDIR flow type conflict

2019-11-20 Thread Ye Xiaolong
On 11/21, Qi Zhang wrote: >Flow type "IPv4 + UDP" or "IPv4 + TCP" is conflict with "IPv4 + any" >flow type. If a rule for IPv4 + any is created, we should reject any rule >for IPv4 + UDP otherwise the first rule may be impacted, same decision >should be made on a reverse order. >For IPv6 and IPv4 G

Re: [dpdk-dev] [PATCH v3 0/2] fix FDIR support for GTPU

2019-11-20 Thread Zhang, Qi Z
> -Original Message- > From: Cao, Yahui > Sent: Thursday, November 21, 2019 7:20 PM > To: Yang, Qiming ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Zhang, Qi Z ; Cao, Yahui > ; Ye, Xiaolong ; Wang, Ying A > ; Su, Simei ; Sun, Chenmin > > Subject: [PATCH v3 0/2] fix FDIR support for GTPU > > T

[dpdk-dev] [PATCH v3 2/2] net/ice: add missing FDIR support for GTPU without extension header

2019-11-20 Thread Yahui Cao
Add FDIR support for normal GTP-U packet, which doesn't contain GTP_PSC extension header. Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel") Cc: yahui@intel.com Signed-off-by: Yahui Cao --- drivers/net/ice/ice_fdir_filter.c | 9 +++-- drivers/net/ice/ice_generic_flow.c

[dpdk-dev] [PATCH v3 0/2] fix FDIR support for GTPU

2019-11-20 Thread Yahui Cao
This patch series enables FDIR support for both GTP-U and GTP-U with extension header. - Patch 1 renames GTPU with extension header related variables - Patch 2 adds FDIR support for non-extension-header GTPU -- v3: * Change commit message v2: * Re-organize patch Yahui Cao (2): net/ice: fix p

[dpdk-dev] [PATCH v3 1/2] net/ice: fix pattern name of GTPU with extension header

2019-11-20 Thread Yahui Cao
Pattern name of GTP-U flow with extension header should be xxx_gtpu_eh_xxx. So it will not conflict with the pattern name of a GTP-U flow that does not contains extension header. Fixes: 3e4eab9c2192 ("net/ice: add pattern manifest") Cc: ying.a.w...@intel.com Signed-off-by: Yahui Cao --- drivers

[dpdk-dev] [PATCH] net/mlx5: fix incorrect L3 layer chosen in TTL action

2019-11-20 Thread Suanming Mou
For IPINIP flow, there are two L3 layer match pattern items, the inner layer follows the outer layer as the latter L3 layer item, the TTL action handles the outer layer. Current the outer and inner L3 layers are both regared as the outer L3 layer, it caueses TTL action uses the incorrect latter in

Re: [dpdk-dev] [PATCH v18 10/19] raw/ifpga: add SEU error handler

2019-11-20 Thread Ye Xiaolong
On 11/20, Thomas Monjalon wrote: >Rosen (and most of your colleagues), >Please use --in-reply-to when sending a new version. >All versions must be a reply to the very first cover letter. I'll broadcast this message to our team. Thanks, Xiaolong > >14/11/2019 10:02, Rosen Xu: >> +IFPGA_RAWDEV

Re: [dpdk-dev] [PATCH 1/5] event/octeontx2: fix TIM HW race condition

2019-11-20 Thread Jerin Jacob
On Wed, Nov 20, 2019 at 10:26 AM wrote: > > From: Pavan Nikhilesh > > Fix HW race condition observed when timeout resolution is low (<5us). > When HW traverses a given TIM bucket it will clear chunk_remainder, > but since SW always decreases the chunk_remainder at the start of the > arm routine i

[dpdk-dev] [PATCH v4] net/ice: fix FDIR flow type conflict

2019-11-20 Thread Qi Zhang
Flow type "IPv4 + UDP" or "IPv4 + TCP" is conflict with "IPv4 + any" flow type. If a rule for IPv4 + any is created, we should reject any rule for IPv4 + UDP otherwise the first rule may be impacted, same decision should be made on a reverse order. For IPv6 and IPv4 GTPU inner case, we have the sam

Re: [dpdk-dev] [PATCH v2 0/6] octeontx: sync with latest SDK

2019-11-20 Thread Jerin Jacob
On Wed, Nov 20, 2019 at 9:18 AM wrote: > > From: Pavan Nikhilesh > > Sync octeontx mailbox with the latest version (10.1.2.x) of SDK available. Series applied to dpdk-next-eventdev/master. Thanks. > > Pavan Nikhilesh (6): > octeontx: update mbox definition to version 1.1.3 > net/octeontx:

Re: [dpdk-dev] [EXT] Re: [PATCH v2] kni: increase kernel version requirement for VA

2019-11-20 Thread Vamsi Krishna Attunuru
> -Original Message- > From: Jerin Jacob > Sent: Thursday, November 21, 2019 7:28 AM > To: David Marchand > Cc: Vamsi Krishna Attunuru ; Jerin Jacob > Kollanukkaran ; John McNamara > ; Marko Kovacevic > ; dev ; Kiran Kumar > Kokkilagadda ; Igor Ryzhov > ; Ferruh Yigit > Subject: [EXT]

[dpdk-dev] [Bug 315] Virtio crypto does not work . Tried with vhost crypto as backend and dpdk test application (cryptodev_virtio_autotest )

2019-11-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=315 Maxime Coquelin (maxime.coque...@redhat.com) changed: What|Removed |Added CC||maxime.coque...@redh

[dpdk-dev] [Bug 356] Building dpdk with rte_vhost sometimes fails due to missing rte_hash.h

2019-11-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=356 Maxime Coquelin (maxime.coque...@redhat.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

Re: [dpdk-dev] [PATCH v2] kni: increase kernel version requirement for VA

2019-11-20 Thread Jerin Jacob
On Wed, Nov 20, 2019 at 10:59 PM David Marchand wrote: > > On Wed, Nov 20, 2019 at 6:22 PM Ferruh Yigit wrote: > > > > A build error reported related to the selected > > 'get_user_pages_remote()' kernel API: > > > > .../kernel/linux/kni/kni_dev.h:113:8: > > error: too few arguments to function

Re: [dpdk-dev] [PATCH v4] net/ice: add flow mark hint support

2019-11-20 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, November 21, 2019 2:57 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Ye, Xiaolong ; Yigit, Ferruh > ; arybche...@solarflare.com; or...@mellanox.com > Subject: Re: [dpdk-dev] [PATCH v4] net/ice: add flow mark hint support > > 19

Re: [dpdk-dev] [PATCH] net/virtio-user: drop attribute "unused" for memory callback

2019-11-20 Thread Maxime Coquelin
On 11/19/19 8:12 AM, Tiwei Bie wrote: > The "addr" param has been used since the event callbacks are enabled > for external memory. So the "__rte_unused" should be dropped. > > Besides, slightly refine the coding style by consistently assuming > tabs are 8 characters. > > Fixes: f32c7c9de961 (

[dpdk-dev] [dpdk-announce] release candidate 19.11-rc3

2019-11-20 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v19.11-rc3 142 patches were integrated. The release notes so far: http://doc.dpdk.org/guides/rel_notes/release_19_11.html It should be completed with a list of tested hardware. Highlights of 19.11

Re: [dpdk-dev] [PATCH] power: handle frequency increase with turbo disabled

2019-11-20 Thread Thomas Monjalon
14/11/2019 17:23, Hunt, David: > Hi Mattias, > > On 14/11/2019 14:10, Mattias Rönnblom wrote: > > Calling pstate's or acpi's rte_power_freq_up() when on the highest > > non-turbo frequency results in an error, if turbo is disabled. The > > error is in the form of a return code and a RTE_LOG() entr

Re: [dpdk-dev] [PATCH] devtools: reduce list of Arm builds tested with meson

2019-11-20 Thread Thomas Monjalon
21/11/2019 00:42, Thomas Monjalon: > The list of Arm configs is growing: > config/arm/arm64_armada_linux_gcc > config/arm/arm64_armv8_linux_gcc > config/arm/arm64_bluefield_linux_gcc > config/arm/arm64_dpaa_linux_gcc > config/arm/arm64_emag_linux_gcc > config/arm

[dpdk-dev] [PATCH] devtools: reduce list of Arm builds tested with meson

2019-11-20 Thread Thomas Monjalon
The list of Arm configs is growing: config/arm/arm64_armada_linux_gcc config/arm/arm64_armv8_linux_gcc config/arm/arm64_bluefield_linux_gcc config/arm/arm64_dpaa_linux_gcc config/arm/arm64_emag_linux_gcc config/arm/arm64_n1sdp_linux_gcc config

Re: [dpdk-dev] [PATCH v2] lib/bpf: fix clang build warnings for aarch64

2019-11-20 Thread Thomas Monjalon
15/11/2019 08:14, Jerin Jacob: > On Fri, Nov 15, 2019 at 12:18 PM Ruifeng Wang wrote: > > > > Clang has different prototype for __builtin___clear_cache(). It requires > > 'char *' parameters while gcc requires 'void *'. > > > > Clang version 8.0 was used. > > Warning messages during build: > > ../

[dpdk-dev] [PATCH] testpmd: fix memory leak in iterator

2019-11-20 Thread Stephen Hemminger
The RTE_FOREACH_MATCHING_DEV iterator requires that if a break is done before the end of the loop, the function rte_eth_iterator_cleanup() must be called. Fixes: 55e51c962432 ("app/testpmd: add device related commands") Cc: ndabilpu...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Stephen Hemming

Re: [dpdk-dev] [PATCH v4] build: add emag target

2019-11-20 Thread Thomas Monjalon
14/10/2019 11:34, Gavin Hu: > From: Jerry Hao OS > > Add the make and meson based build infrastructure for the eMAG platform > from Ampere Computing corp., which is a 64-bit ARM processor with 32 > Armv8 64-bit CPU cores. For more information, refer to: > https://amperecomputing.com/product/ > >

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] bus/pci: fix driver detach clear

2019-11-20 Thread David Marchand
On Wed, Nov 20, 2019 at 10:48 AM Matan Azrad wrote: > > When a rte_device is unplugged, the driver should be detached from the > device. > > The PCI detach driver operation wrongly didn't clear the driver from the > device structure what remain the device in probe state from the EAL > point of vie

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] app/testpmd: fix invalid port detaching

2019-11-20 Thread David Marchand
On Tue, Nov 12, 2019 at 12:21 PM Iremonger, Bernard wrote: > > > -Original Message- > > From: Matan Azrad > > Sent: Tuesday, November 12, 2019 8:48 AM > > To: dev@dpdk.org > > Cc: Gaetan Rivet ; Iremonger, Bernard > > ; tho...@monjalon.net; sta...@dpdk.org > > Subject: [PATCH 2/2] app/tes

Re: [dpdk-dev] [PATCH v3 0/3] add arm N1SDP and A76 configurations

2019-11-20 Thread Thomas Monjalon
11/11/2019 06:41, Gavin Hu: > Gavin Hu (3): > test/rcu: fix the compiling error for armv8.2 > config: add arm neoverse N1 SDP configuration > config: add cortex-a76 configuration Applied, without first patch. Please re-submit a fix for RCU test.

Re: [dpdk-dev] [PATCH v2] kni: increase kernel version requirement for VA

2019-11-20 Thread David Marchand
On Wed, Nov 20, 2019 at 6:28 PM David Marchand wrote: > > On Wed, Nov 20, 2019 at 6:22 PM Ferruh Yigit wrote: > > > > A build error reported related to the selected > > 'get_user_pages_remote()' kernel API: > > > > .../kernel/linux/kni/kni_dev.h:113:8: > > error: too few arguments to function ‘

Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/3] test/rcu: fix the compiling error for armv8.2

2019-11-20 Thread Thomas Monjalon
11/11/2019 06:41, Gavin Hu: > With "-march=armv8.2-a" specified, a compiling error generated: > app/test/test_rcu_qsbr.c:234:10: error: comparison of integer > expressions of different signedness: ‘unsigned int’ and ‘int’ > [-Werror=sign-compare] > > Fixes: b87089b0bb19 ("test/rcu: add API and fun

Re: [dpdk-dev] [PATCH v8 00/12] Implement the new ABI policy and add helper scripts

2019-11-20 Thread David Marchand
On Wed, Nov 20, 2019 at 9:17 PM Thomas Monjalon wrote: > > 20/11/2019 18:23, Anatoly Burakov: > > This patchset prepares the codebase for the new ABI policy and > > adds a few helper scripts. > > > > 379 files changed, 1172 insertions(+), 3409 deletions(-) > > Thanks for the great work Anatoly >

Re: [dpdk-dev] [PATCH v8 01/12] config: change ABI versioning to global

2019-11-20 Thread David Marchand
On Wed, Nov 20, 2019 at 8:51 PM David Marchand wrote: > > On Wed, Nov 20, 2019 at 6:23 PM Anatoly Burakov > wrote: > > > > From: Marcin Baran > > > > As per new ABI policy [1], all of the libraries are now versioned using > > one global ABI version. Stable libraries use the MAJOR.MINOR ABI > > v

Re: [dpdk-dev] [PATCH v2 0/2] support older pkg-config

2019-11-20 Thread Thomas Monjalon
18/11/2019 12:48, Ferruh Yigit: > On 11/15/2019 3:16 PM, Bruce Richardson wrote: > > Not all pkg-config installs support --define-prefix and --path flags, so > > ensure we can still build examples without those flags, and that we > > don't get errors when using test-meson-builds.sh with/without tho

Re: [dpdk-dev] [PATCH v18 10/19] raw/ifpga: add SEU error handler

2019-11-20 Thread David Marchand
On Wed, Nov 20, 2019 at 10:23 PM Thomas Monjalon wrote: > > Rosen (and most of your colleagues), > Please use --in-reply-to when sending a new version. > All versions must be a reply to the very first cover letter. > > 14/11/2019 10:02, Rosen Xu: > > + IFPGA_RAWDEV_PMD_INFO("seu emr low: 0x%lx

Re: [dpdk-dev] [PATCH v18 10/19] raw/ifpga: add SEU error handler

2019-11-20 Thread Thomas Monjalon
Rosen (and most of your colleagues), Please use --in-reply-to when sending a new version. All versions must be a reply to the very first cover letter. 14/11/2019 10:02, Rosen Xu: > + IFPGA_RAWDEV_PMD_INFO("seu emr low: 0x%lx\n", val); Using %lx is usually wrong. val is 64-bit. On 32-bit machi

Re: [dpdk-dev] [PATCH v8 00/12] Implement the new ABI policy and add helper scripts

2019-11-20 Thread Thomas Monjalon
20/11/2019 18:23, Anatoly Burakov: > This patchset prepares the codebase for the new ABI policy and > adds a few helper scripts. > > 379 files changed, 1172 insertions(+), 3409 deletions(-) Thanks for the great work Anatoly Acked-by: Thomas Monjalon

[dpdk-dev] [PATCH] eal/freebsd: fix queuing duplicate eal_alarm_callbacks

2019-11-20 Thread Mit Matelske
The source callback list grows infinitely when more than alarm is queued. This fix recognizes that an alarm interrupt in FreeBSD should never have more than one callback on its list, so if rte_intr_callback_register() is called with an interrupt handle type of RTE_INTR_HANDLE_ALARM, so if such an

Re: [dpdk-dev] [PATCH] doc: update git fixline alias with cc to stable

2019-11-20 Thread Thomas Monjalon
19/11/2019 12:22, Bruce Richardson: > On Tue, Nov 19, 2019 at 11:03:57AM +, Reshma Pattan wrote: > > --- a/doc/guides/contributing/patches.rst > > +++ b/doc/guides/contributing/patches.rst > > - git config alias.fixline "log -1 --abbrev=12 --format='Fixes: %h > > (\"%s\")%nCc: %ae'" > > +

Re: [dpdk-dev] [PATCH v8 04/12] buildtools: add script for updating symbols abi version

2019-11-20 Thread David Marchand
On Wed, Nov 20, 2019 at 6:24 PM Anatoly Burakov wrote: > diff --git a/buildtools/update_version_map_abi.py > b/buildtools/update_version_map_abi.py > new file mode 100755 > index 00..87fed54653 > --- /dev/null > +++ b/buildtools/update_version_map_abi.py > @@ -0,0 +1,175 @@ > +#!/usr/bin/

Re: [dpdk-dev] [PATCH v8 01/12] config: change ABI versioning to global

2019-11-20 Thread David Marchand
On Wed, Nov 20, 2019 at 6:23 PM Anatoly Burakov wrote: > > From: Marcin Baran > > As per new ABI policy [1], all of the libraries are now versioned using > one global ABI version. Stable libraries use the MAJOR.MINOR ABI > version for their shared objects, while experimental libraries > use the 0

Re: [dpdk-dev] [PATCH v8 03/12] build: remove individual library versions

2019-11-20 Thread David Marchand
On Wed, Nov 20, 2019 at 6:24 PM Anatoly Burakov wrote: > > Since the library versioning for both stable and experimental ABI's is > now managed globally, the LIBABIVER and version variables no longer > serve any useful purpose, and can be removed. > > The replacement in Makefiles was done using th

Re: [dpdk-dev] [PATCH v4] net/ice: add flow mark hint support

2019-11-20 Thread Thomas Monjalon
19/11/2019 07:14, Qi Zhang: > Since not all data paths support flow mark, the driver needs > a hint from application to select the correct data path if > flow mark is required. The patch introduces a devarg > "flow-mark-support" as a workaround solution, since a standard > way is still ongoing. >

Re: [dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen

2019-11-20 Thread Wiles, Keith
> On Nov 20, 2019, at 6:09 AM, Nirmal Sarkar wrote: > > Hello, > > Thanks for the help. > As I'm using DPDK-18.11.1, I did not find the definition of > "RTE_ETHER_MAX_LEN" in lib/librte_net/rte_ether.h file. > So I set "ETHER_MAX_LEN" value to 9600. > Apart from that I took rest of the changes

[dpdk-dev] [PATCH] mbuf: display more fields in dump

2019-11-20 Thread Stephen Hemminger
The rte_pktmbuf_dump should display offset, refcount, and vlan info since these are often useful during debugging. Signed-off-by: Stephen Hemminger --- lib/librte_mbuf/rte_mbuf.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/li

[dpdk-dev] [PATCH v8 03/12] build: remove individual library versions

2019-11-20 Thread Anatoly Burakov
Since the library versioning for both stable and experimental ABI's is now managed globally, the LIBABIVER and version variables no longer serve any useful purpose, and can be removed. The replacement in Makefiles was done using the following regex: ^(#.*\n)?LIBABIVER\s*:=\s*\d+\n(\s*\n)?

[dpdk-dev] [PATCH v8 11/12] build: change ABI version to 20.0

2019-11-20 Thread Anatoly Burakov
From: Pawel Modrak Merge all vesions in linker version script files to DPDK_20.0. This commit was generated by running the following command: :~/DPDK$ buildtools/update-abi.sh 20.0 Signed-off-by: Pawel Modrak Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- .../rte_pmd_bbdev_f

Re: [dpdk-dev] [PATCH v7 01/10] config: change ABI versioning to global

2019-11-20 Thread Kinsella, Ray
+1 - that's a plan. Ray K > -Original Message- > From: Thomas Monjalon > Sent: Wednesday 20 November 2019 13:32 > To: Kinsella, Ray ; Burakov, Anatoly > > Cc: dev@dpdk.org; Baran, MarcinX ; Richardson, > Bruce ; Mcnamara, John > ; david.march...@redhat.com; Pawel Modrak > ; Yigit, Ferru

Re: [dpdk-dev] [PATCH v7 01/10] config: change ABI versioning to global

2019-11-20 Thread Kinsella, Ray
> -Original Message- > From: Burakov, Anatoly > Sent: Friday 8 November 2019 16:25 > To: dev@dpdk.org > Cc: Baran, MarcinX ; Thomas Monjalon > ; Richardson, Bruce ; > Mcnamara, John ; Kinsella, Ray > ; david.march...@redhat.com; Pawel Modrak > > Subject: [PATCH v7 01/10] config: change

Re: [dpdk-dev] Jumbo Frame in pktgen & dpdk-pktgen

2019-11-20 Thread Nirmal Sarkar
Hello, Thanks for the help. As I'm using DPDK-18.11.1, I did not find the definition of "RTE_ETHER_MAX_LEN" in lib/librte_net/rte_ether.h file. So I set "ETHER_MAX_LEN" value to 9600. Apart from that I took rest of the changes and with these I'm able to send jumbo frame. Took tcpdump on the receiv

Re: [dpdk-dev] [PATCH v2] kni: increase kernel version requirement for VA

2019-11-20 Thread David Marchand
On Wed, Nov 20, 2019 at 6:22 PM Ferruh Yigit wrote: > > A build error reported related to the selected > 'get_user_pages_remote()' kernel API: > > .../kernel/linux/kni/kni_dev.h:113:8: > error: too few arguments to function ‘get_user_pages_remote’ > ret = get_user_pages_remote(tsk, tsk->mm, io

[dpdk-dev] [PATCH v8 07/12] lpm: remove deprecated code

2019-11-20 Thread Anatoly Burakov
From: Marcin Baran Remove code for old ABI versions ahead of ABI version bump. Signed-off-by: Marcin Baran Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- Notes: v2: - Moved this to before ABI version bump to avoid compile breakage lib/librte_lpm/rte_lpm.c |

[dpdk-dev] [PATCH v8 12/12] buildtools: add ABI versioning check script

2019-11-20 Thread Anatoly Burakov
From: Marcin Baran Add a shell script that checks whether built libraries are versioned with expected ABI (current ABI, current ABI + 1, or EXPERIMENTAL). The following command was used to verify current source tree (assuming build directory is in ./build): find ./build/lib ./build/drivers -nam

[dpdk-dev] [PATCH v8 09/12] distributor: rename v2.0 ABI to _single suffix

2019-11-20 Thread Anatoly Burakov
From: Marcin Baran The original ABI versioning was slightly misleading in that the DPDK 2.0 ABI was really a single mode for the distributor, and is used as such throughout the distributor code. Fix this by renaming all _v20 API's to _single API's, and remove symbol versioning. Signed-off-by: M

[dpdk-dev] [PATCH v8 08/12] distributor: remove deprecated code

2019-11-20 Thread Anatoly Burakov
From: Marcin Baran Remove code for old ABI versions ahead of ABI version bump. Signed-off-by: Marcin Baran Signed-off-by: Anatoly Burakov Acked-by: David Hunt --- Notes: v5: - Fixed shared library linking error due to versioning still enabled v2: - Moved this to before A

[dpdk-dev] [PATCH v8 10/12] drivers/octeontx: add missing public symbol

2019-11-20 Thread Anatoly Burakov
The logtype symbol was missing from the .map file. Add it. Fixes: d8dd31652cf4 ("common/octeontx: move mbox to common folder") Cc: pbhagavat...@caviumnetworks.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- Notes: v2: - add this patch to avoid comp

[dpdk-dev] [PATCH v8 06/12] timer: remove deprecated code

2019-11-20 Thread Anatoly Burakov
From: Marcin Baran Remove code for old ABI versions ahead of ABI version bump. Signed-off-by: Marcin Baran Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson Acked-by: Erik Gabriel Carrillo --- lib/librte_timer/rte_timer.c | 100 +++-- lib/librte_timer/r

[dpdk-dev] [PATCH v8 05/12] buildtools: add ABI update shell script

2019-11-20 Thread Anatoly Burakov
In order to facilitate mass updating of version files, add a shell script that recurses into lib/ and drivers/ directories and calls the ABI version update script. Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- Notes: v3: - Switch to sh rather than bash, and remove bash-i

[dpdk-dev] [PATCH v8 04/12] buildtools: add script for updating symbols abi version

2019-11-20 Thread Anatoly Burakov
From: Pawel Modrak Add a script that automatically merges all stable ABI's under one ABI section with the new version, while leaving experimental section exactly as it is. Signed-off-by: Pawel Modrak Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- Notes: v7: - Do not re

[dpdk-dev] [PATCH v8 02/12] config: remove CONFIG_RTE_MAJOR_ABI option

2019-11-20 Thread Anatoly Burakov
The CONFIG_RTE_MAJOR_ABI option was introduced to permit multiple DPDK versions installed side by side. The problem is now addressed through the new ABI policy, and thus can be removed. Signed-off-by: Anatoly Burakov --- config/common_base | 5 - 1 file changed, 5 deletions(-) diff --git a/

[dpdk-dev] [PATCH v8 01/12] config: change ABI versioning to global

2019-11-20 Thread Anatoly Burakov
From: Marcin Baran As per new ABI policy [1], all of the libraries are now versioned using one global ABI version. Stable libraries use the MAJOR.MINOR ABI version for their shared objects, while experimental libraries use the 0.MAJORMINOR convention for their versioning. Experimental library ver

[dpdk-dev] [PATCH v8 00/12] Implement the new ABI policy and add helper scripts

2019-11-20 Thread Anatoly Burakov
This patchset prepares the codebase for the new ABI policy and adds a few helper scripts. There are two new scripts for managing ABI versions added. The first one is a Python script that will read in a .map file, flatten it and update the ABI version to the ABI version specified on the command-lin

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] bus/pci: fix driver detach clear

2019-11-20 Thread David Marchand
On Wed, Nov 20, 2019 at 2:54 PM Thomas Monjalon wrote: > But about this patch 1, it is resetting rte_device.driver, > which is used by the function rte_dev_is_probed(). > It says rte_device has no rte_driver attached anymore. > This patch is the same idea as > 391797f04208 ("drivers/bus: move driv

[dpdk-dev] [PATCH v2] kni: increase kernel version requirement for VA

2019-11-20 Thread Ferruh Yigit
A build error reported related to the selected 'get_user_pages_remote()' kernel API: .../kernel/linux/kni/kni_dev.h:113:8: error: too few arguments to function ‘get_user_pages_remote’ ret = get_user_pages_remote(tsk, tsk->mm, iova, 1 ^ Currently there are three ver

Re: [dpdk-dev] [pull-request] next-crypto 19.11 rc3

2019-11-20 Thread Thomas Monjalon
20/11/2019 12:38, Akhil Goyal: > http://dpdk.org/git/next/dpdk-next-crypto Pulled, thanks

Re: [dpdk-dev] [PATCH 3/3] doc: update release notes for Broadcom PMD

2019-11-20 Thread Ajit Khaparde
On Wed, Nov 20, 2019 at 1:45 AM Ferruh Yigit wrote: > On 11/20/2019 9:34 AM, Ferruh Yigit wrote: > > On 11/19/2019 6:56 PM, Ajit Khaparde wrote: > >> Update release doc briefly describing updates to bnxt PMD for > >> 19.11 release. > >> > >> Signed-off-by: Ajit Khaparde > >> --- > >> doc/guides

Re: [dpdk-dev] [PATCH 1/2] doc: update bnxt feature list

2019-11-20 Thread Ajit Khaparde
On Wed, Nov 20, 2019 at 1:42 AM Ferruh Yigit wrote: > On 11/20/2019 4:29 AM, Ajit Khaparde wrote: > > Updating bnxt.ini file. > > > > Signed-off-by: Ajit Khaparde > > --- > > doc/guides/nics/features/bnxt.ini | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/doc/guides/nics/feat

Re: [dpdk-dev] [PATCH] kni: increase kernel version requirement for VA

2019-11-20 Thread Ferruh Yigit
On 11/20/2019 4:24 PM, Igor Ryzhov wrote: > Hi Ferruh, > > There is a typo in "version incread to > 4.9.0 ...". > incread > increased Thanks Igor, I will fix in next version. > > Igor > > On Wed, Nov 20, 2019 at 7:00 PM Ferruh Yigit wrote: > >> A build error reported related to the selected

Re: [dpdk-dev] [PATCH] kni: increase kernel version requirement for VA

2019-11-20 Thread Igor Ryzhov
Hi Ferruh, There is a typo in "version incread to > 4.9.0 ...". incread > increased Igor On Wed, Nov 20, 2019 at 7:00 PM Ferruh Yigit wrote: > A build error reported related to the selected > 'get_user_pages_remote()' kernel API: > > .../kernel/linux/kni/kni_dev.h:113:8: > error: too few arg

[dpdk-dev] [PATCH] kni: increase kernel version requirement for VA

2019-11-20 Thread Ferruh Yigit
A build error reported related to the selected 'get_user_pages_remote()' kernel API: .../kernel/linux/kni/kni_dev.h:113:8: error: too few arguments to function ‘get_user_pages_remote’ ret = get_user_pages_remote(tsk, tsk->mm, iova, 1 ^ Currently there are three ver

Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private structure

2019-11-20 Thread Stephen Hemminger
On Wed, 20 Nov 2019 07:01:26 + Shahaf Shuler wrote: > Wednesday, November 20, 2019 1:51 AM, Stephen Hemminger: > > Subject: Re: [dpdk-dev] [PATCH] mbuf: extend pktmbuf pool private > > structure > > > > On Tue, 19 Nov 2019 23:30:15 +0100 > > Thomas Monjalon wrote: > > > > > 19/11/2019 17

Re: [dpdk-dev] [PATCH] net/ixgbe: fix qos sched sample app performance drop

2019-11-20 Thread Ye Xiaolong
Hi, Guinan, could you take a look at this patch as well. On 11/20, Shougang Wang wrote: >Currently MACsec register is set without any conditions when start port. >It should be set only when user needs. To avoid wild value, I add init >function. This patch fixes the issue. > >Fixes: 50556c88104c (

[dpdk-dev] PCI memory sync (kvm,dpdk,e1000,packet stalled)

2019-11-20 Thread ASM
Hi folks! I trying solve the problem, with packets stopping (e1000,tap,kvm). My studies led to the following: 1. From flatview_write_continue() I see, what e1000 writes the number "7" to the STAT register. 2. The driver from target OS reads STAT register with number "7" and writes to the register

Re: [dpdk-dev] [RFC 0/4] cpu-crypto API choices

2019-11-20 Thread Jerin Jacob
On Mon, Nov 18, 2019 at 5:27 PM Ananyev, Konstantin wrote: > > Hi Jerin, Hi Konstantin, > > Thanks for input, my answers inline. > Other guys - please provide your input. > Thanks > Konstantin > > > > Originally both SW and HW crypto PMDs use rte_crypot_op based API to > > > process the crypto w

Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release assertions

2019-11-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Matan Azrad > Sent: Wednesday, November 20, 2019 11:21 AM > To: dev@dpdk.org > Cc: Slava Ovsiienko ; Ori Kam > > Subject: [dpdk-dev] [PATCH] net/mlx5: fix Rx queue release assertions > > In debug mode, there is assertion to validate the

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] bus/pci: fix driver detach clear

2019-11-20 Thread Thomas Monjalon
20/11/2019 14:03, David Marchand: > On Wed, Nov 20, 2019 at 10:48 AM Matan Azrad wrote: > > > > When a rte_device is unplugged, the driver should be detached from the > > device. > > > > The PCI detach driver operation wrongly didn't clear the driver from the > > device structure what remain the d

Re: [dpdk-dev] [PATCH] maintainers: add git repo information for libraries

2019-11-20 Thread Yigit, Ferruh
On 3/13/2019 7:35 AM, Thomas Monjalon wrote: > 13/03/2019 02:59, Ferruh Yigit: >> Add target git sub-tree information for libraries, this is mainly to >> reduce apply failures of the patches by automating target sub-tree >> selection for a patch for automation. >> >> Also can be useful for develope

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] bus/pci: fix driver detach clear

2019-11-20 Thread Matan Azrad
Hi David From: David Marchand > On Wed, Nov 20, 2019 at 10:48 AM Matan Azrad > wrote: > > > > When a rte_device is unplugged, the driver should be detached from the > > device. > > > > The PCI detach driver operation wrongly didn't clear the driver from > > the device structure what remain the de

Re: [dpdk-dev] [PATCH v4 1/6] lib/eal: implement the family of rte bitoperation APIs

2019-11-20 Thread Morten Brørup
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Joyce Kong > Sent: Wednesday, November 20, 2019 11:12 AM > > There are a lot functions of bit operations scattered and > duplicated in PMDs, consolidating them into a common API > family is necessary. Furthermore,

Re: [dpdk-dev] [PATCH v2 1/3] test/event_crypto: fix missing IV value for AES algo

2019-11-20 Thread Jerin Jacob
On Thu, Nov 7, 2019 at 2:34 PM Hemant Agrawal wrote: > > The IV was not set, which was causing HW based SEC on DPAA1 > to fail. > > Fixes: ce02103ad072 ("test/event_crypto: change the SEC cipher algo") > > Signed-off-by: Hemant Agrawal > --- > Sending only the fixes. dropped the functional change

Re: [dpdk-dev] [PATCH v7 01/10] config: change ABI versioning to global

2019-11-20 Thread Thomas Monjalon
20/11/2019 13:10, Kinsella, Ray: > From: Burakov, Anatoly > > --- a/drivers/meson.build > > +++ b/drivers/meson.build > > + if is_experimental != 0 > > + lib_version = '0.1' > [rk] This all makes sense - except this part. > [rk] I would expect the experi

Re: [dpdk-dev] [PATCH v2 1/2] lib: fix log typos

2019-11-20 Thread Kevin Traynor
On 20/11/2019 08:00, David Marchand wrote: > On Tue, Nov 19, 2019 at 10:56 PM Kevin Traynor wrote: >> >> On 19/11/2019 21:18, David Marchand wrote: >>> On Wed, Nov 13, 2019 at 5:11 PM Kevin Traynor wrote: Fix these as they are user visible. Found with codespell. Fixes: bacaa27

[dpdk-dev] [PATCH] doc: add info about codespell config

2019-11-20 Thread Kevin Traynor
Document the config to use codespell with checkpatches.sh. Signed-off-by: Kevin Traynor --- doc/guides/contributing/patches.rst | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/doc/guides/contributing/patches.rst b/doc/guides/contributing/patches.rst index 2140303

Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element size

2019-11-20 Thread David Marchand
On Wed, Nov 20, 2019 at 3:12 AM Xueming(Steven) Li wrote: > > > -Original Message- > > From: David Marchand > > Sent: Wednesday, November 20, 2019 4:47 AM > > To: Xueming(Steven) Li ; Anatoly Burakov > > > > Cc: Asaf Penso ; dev ; dpdk stable > > > > Subject: Re: [dpdk-stable] [PATCH 2/

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] bus/pci: fix driver detach clear

2019-11-20 Thread David Marchand
On Wed, Nov 20, 2019 at 10:48 AM Matan Azrad wrote: > > When a rte_device is unplugged, the driver should be detached from the > device. > > The PCI detach driver operation wrongly didn't clear the driver from the > device structure what remain the device in probe state from the EAL > point of vie

Re: [dpdk-dev] [PATCH v6 1/1] net/hinic: fix secondary process issue

2019-11-20 Thread Ferruh Yigit
On 11/19/2019 3:21 PM, Ferruh Yigit wrote: > On 11/19/2019 12:31 PM, Xiaoyun wang wrote: >> The secondary process does not need to register interrupt handle, >> remove rte_intr_callback_register from secondary process branch. >> >> Fixes: 06b6a81bbabf ("net/hinic: document missing features") > > I

Re: [dpdk-dev] [PATCH v2] app/testpmd: report invalid command line parameter

2019-11-20 Thread Ferruh Yigit
On 11/19/2019 7:18 PM, Pallavi Kadam wrote: > > On 11/18/2019 8:18 AM, Ferruh Yigit wrote: >> On 11/18/2019 3:37 PM, David Marchand wrote: >>> We currently do not check that a non option string has been passed to >>> testpmd. >>> >>> Example: >>> $ ./master/app/testpmd --no-huge -m 512 --vdev net_

[dpdk-dev] [pull-request] next-crypto 19.11 rc3

2019-11-20 Thread Akhil Goyal
The following changes since commit 3be76aa9294f3788b4f9c615642e6027f1b7948a: ci: add 32-bit travis builds (2019-11-19 22:23:31 +0100) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to 539b74b9d8e8567f4679c118951f0fc025b9c717:

Re: [dpdk-dev] [PATCH v7 03/10] buildtools: add ABI update shell script

2019-11-20 Thread Burakov, Anatoly
On 19-Nov-19 5:38 PM, Thomas Monjalon wrote: 08/11/2019 17:25, Anatoly Burakov: In order to facilitate mass updating of version files, add a shell script that recurses into lib/ and drivers/ directories and calls the ABI version update script. Signed-off-by: Anatoly Burakov Acked-by: Bruce Ric

  1   2   >