> -----Original Message----- > From: Jerin Jacob <[email protected]> > Sent: Thursday, November 21, 2019 7:28 AM > To: David Marchand <[email protected]> > Cc: Vamsi Krishna Attunuru <[email protected]>; Jerin Jacob > Kollanukkaran <[email protected]>; John McNamara > <[email protected]>; Marko Kovacevic > <[email protected]>; dev <[email protected]>; Kiran Kumar > Kokkilagadda <[email protected]>; Igor Ryzhov > <[email protected]>; Ferruh Yigit <[email protected]> > Subject: [EXT] Re: [dpdk-dev] [PATCH v2] kni: increase kernel version > requirement for VA > > External Email > > ---------------------------------------------------------------------- > On Wed, Nov 20, 2019 at 10:59 PM David Marchand > <[email protected]> wrote: > > > > On Wed, Nov 20, 2019 at 6:22 PM Ferruh Yigit <[email protected]> > wrote: > > > > > > A build error reported related to the selected > > > 'get_user_pages_remote()' kernel API: > > > > > > .../kernel/linux/kni/kni_dev.h:113:8: > > > error: too few arguments to function ‘get_user_pages_remote’ > > > ret = get_user_pages_remote(tsk, tsk->mm, iova, 1 > > > ^~~~~~~~~~~~~~~~~~~~~ > > > > > > Currently there are three version of the 'get_user_pages_remote()' > > > supported, based on kernel version > > > < 4.9, = 4.9, > 4.9 > > > > > > These version based checks are not working fine with the distro > > > kernels which is the cause of reported build error. The error > > > reported by the kernel version 4.8, but it is using API defined in > 4.9. > > > > > > To be able to take control of this, and possible more, related build > > > error, increasing the minimum supported kernel version for iova=va > > > with KNI to kernel version 4.9. > > > > > > This leaves us with single version of the kernel API and more > > > manageable. > > > > > > Signed-off-by: Ferruh Yigit <[email protected]> > > > > Jerin, Vamsi, > > > > Is this okay for you? > > Acked-by: Jerin Jacob <[email protected]> >
Acked-by: Vamsi Attunuru <[email protected]> > > > Thanks. > > > > > > -- > > David Marchand > >
